From: Arun Parameswaran <arun.parameswaran@broadcom.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 5/7] net: phy: Add support to configure clock in Broadcom iProc mdio mux
Date: Thu, 26 Jul 2018 12:20:46 -0700 [thread overview]
Message-ID: <8c163cc7-aa52-4a17-9cba-762c8542e721@broadcom.com> (raw)
In-Reply-To: <20180726191340.GH10686@lunn.ch>
On 18-07-26 12:13 PM, Andrew Lunn wrote:
>> @@ -175,6 +198,12 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev)
>> return PTR_ERR(md->base);
>> }
>>
>> + md->core_clk = devm_clk_get(&pdev->dev, NULL);
>> + if (IS_ERR(md->core_clk)) {
>> + dev_info(&pdev->dev, "core_clk not specified\n");
>> + md->core_clk = NULL;
>> + }
>> +
>
> In the binding, you say the clock is optional. This is a rather strong
> message for something which is optional. I think it would be better to
> not output anything.
>
> Andrew
>
Will remove the message.
Thanks
Arun
next prev parent reply other threads:[~2018-07-26 19:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 18:36 [PATCH 0/7] Add clock config and pm support to bcm " Arun Parameswaran
2018-07-26 18:36 ` [PATCH 1/7] dt-bindings: net: Fix Broadcom iProc mdio mux driver base address Arun Parameswaran
2018-07-26 19:01 ` Andrew Lunn
2018-07-26 19:15 ` Arun Parameswaran
2018-07-26 18:36 ` [PATCH 2/7] net: phy: Fix the register offsets in Broadcom iProc mdio mux driver Arun Parameswaran
2018-07-26 19:06 ` Andrew Lunn
2018-07-26 19:16 ` Arun Parameswaran
2018-07-26 19:25 ` Ray Jui
2018-07-26 19:29 ` Andrew Lunn
2018-07-26 18:36 ` [PATCH 3/7] arm64: dts: Fix the base address of the Broadcom iProc mdio mux Arun Parameswaran
2018-07-26 18:36 ` [PATCH 4/7] dt-bindings: net: Add clock handle to " Arun Parameswaran
2018-07-26 18:36 ` [PATCH 5/7] net: phy: Add support to configure clock in " Arun Parameswaran
2018-07-26 19:13 ` Andrew Lunn
2018-07-26 19:20 ` Arun Parameswaran [this message]
2018-07-26 19:26 ` Andrew Lunn
2018-07-26 20:00 ` Arun Parameswaran
2018-07-26 18:36 ` [PATCH 6/7] net: phy: Add pm support to Broadcom iProc mdio mux driver Arun Parameswaran
2018-07-26 19:16 ` Andrew Lunn
2018-07-26 18:36 ` [PATCH 7/7] net: phy: Add pm support for scan ctrl register to bcm mdio mux Arun Parameswaran
2018-07-26 19:20 ` Andrew Lunn
2018-07-26 19:33 ` Arun Parameswaran
2018-07-26 19:36 ` Andrew Lunn
2018-07-26 19:51 ` Arun Parameswaran
2018-07-26 18:52 ` [PATCH 0/7] Add clock config and pm support to bcm iProc " Andrew Lunn
2018-07-26 19:00 ` Arun Parameswaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c163cc7-aa52-4a17-9cba-762c8542e721@broadcom.com \
--to=arun.parameswaran@broadcom.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®