From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
luto@kernel.org, Jiufei Xue <jiufei.xue@linux.alibaba.com>,
Xu Yu <xuyu@linux.alibaba.com>,
peterz@infradead.org, mingo@redhat.com
Subject: Re: [bug report][stable] perf probe: failed to add events
Date: Thu, 28 Feb 2019 10:07:20 +0800 [thread overview]
Message-ID: <8e798942-0e71-c88f-866f-88e55177e286@linux.alibaba.com> (raw)
In-Reply-To: <3b233ff2-e87a-1c61-d516-6c4cdecb4f01@intel.com>
Hi Adrian,
On 19/2/27 20:39, Adrian Hunter wrote:
> Seems to be fixed by this:
>
> From: Adrian Hunter <adrian.hunter@intel.com>
> Date: Wed, 27 Feb 2019 05:35:25 +0200
> Subject: [PATCH] perf probe: Fix getting the kernel map
>
> Since commit 4d99e4136580 ("perf machine: Workaround missing maps for x86
> PTI entry trampolines"), perf tools has been creating more than one kernel
> map, however 'perf probe' assumed there could be only one.
>
> Fix by using machine__kernel_map() to get the main kernel map.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> Fixes: 4d99e4136580 ("perf machine: Workaround missing maps for x86 PTI entry trampolines")
Below is my investigation result before, FYI.
the first bad commit (v4.18 ~ v4.19):
d83212d5dd67 kallsyms, x86: Export addresses of PTI entry trampolines
revert this commit on 4.19.0, it works.
the first good commit again (v4.19 ~ v4.20):
bf904d2762ee x86/pti/64: Remove the SYSCALL64 entry trampoline
backported this commit as well as the related commit 98f05b5138f0 on
v4.19.24, it works.
And I've tested your fix on v4.19.24, it also works.
Tested-by: Joseph Qi <joseph.qi@linux.alibaba.com>
next prev parent reply other threads:[~2019-02-28 2:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 7:31 Joseph Qi
2019-02-26 9:05 ` Greg KH
2019-02-26 12:32 ` Joseph Qi
2019-02-26 13:08 ` Greg KH
2019-02-26 14:20 ` Arnaldo Carvalho de Melo
2019-02-27 12:39 ` Adrian Hunter
2019-02-28 2:07 ` Joseph Qi [this message]
2019-02-28 7:19 ` Adrian Hunter
2019-03-02 10:58 ` Joseph Qi
2019-03-04 13:13 ` [PATCH] perf probe: Fix getting the kernel map Adrian Hunter
2019-03-08 14:39 ` Arnaldo Carvalho de Melo
2019-03-11 9:23 ` Masami Hiramatsu
2019-03-22 22:01 ` [tip:perf/urgent] " tip-bot for Adrian Hunter
2019-03-21 10:10 ` [bug report][stable] perf probe: failed to add events Greg KH
2019-03-25 10:02 ` Adrian Hunter
2019-02-27 1:53 ` Joseph Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e798942-0e71-c88f-866f-88e55177e286@linux.alibaba.com \
--to=joseph.qi@linux.alibaba.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiufei.xue@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=xuyu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®