mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>,
	Peter Rosin <peda@axentia.se>,
	linux-kernel@vger.kernel.org
Cc: Hartmut Knaack <knaack.h@gmx.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 0/4] IIO wrapper drivers, dpot-dac and envelope-detector
Date: Sat, 22 Oct 2016 15:27:47 +0100	[thread overview]
Message-ID: <923bbaf8-f065-bc05-1f9a-ed703d6746f3@kernel.org> (raw)
In-Reply-To: <30a4b562-f553-2620-e961-c2904bce9c51@metafoo.de>

On 20/10/16 16:29, Lars-Peter Clausen wrote:
> On 10/20/2016 04:53 PM, Peter Rosin wrote:
> [...]
>> Good idea! Then the "envelope-detector,inverted" bool can go, and be
>> implied by the compatible string. If some way to rebind the irq trigger
>> is later discovered that can be added as a channel attr without
>> deprecating any dt bindings stuff. While at it, the other properties
>> ("envelope-detector,dac-max" and "envelope-detector,comp-interval-ms")
>> could also be implied from the compatible string. Would that be better?
>> I think so.
>>
>> But, the compatible string is one thing and the driver name is another.
>> "axentia,tse850-envelope-detector" doesn't seem like the best of driver
>> names...
> 
> The driver name is not that important we can still change that later if we
> have to, the DT compatible string on the other hand is fixed.
> 
>>
>> Are there any existing examples of drivers for (generic) things built
>> with discrete components like this that could perhaps provide guidance?
> 
> Not that I'm aware of.
> 
Me neither.  Always interesting to break new ground ;)

J

  reply	other threads:[~2016-10-22 14:27 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-20  9:25 Peter Rosin
2016-10-20  9:25 ` [PATCH 1/4] dt-bindings: iio: document dpot-dac bindings Peter Rosin
2016-10-22 14:36   ` Jonathan Cameron
2016-10-20  9:26 ` [PATCH 2/4] iio: dpot-dac: DAC driver based on a digital potentiometer Peter Rosin
2016-10-20 11:29   ` Peter Meerwald-Stadler
2016-10-20 13:48     ` Peter Rosin
2016-10-20 14:08       ` Peter Meerwald-Stadler
2016-10-20 14:51         ` Peter Rosin
2016-10-22 14:47   ` Jonathan Cameron
2016-10-20  9:26 ` [PATCH 3/4] dt-bindings: iio: document envelope-detector bindings Peter Rosin
2016-10-20 11:29   ` Peter Meerwald-Stadler
2016-10-22 14:53   ` Jonathan Cameron
2016-10-20  9:26 ` [PATCH 4/4] iio: envelope-detector: ADC driver based on a DAC and a comparator Peter Rosin
2016-10-22 15:03   ` Jonathan Cameron
2016-10-20 12:55 ` [PATCH 0/4] IIO wrapper drivers, dpot-dac and envelope-detector Lars-Peter Clausen
2016-10-20 14:53   ` Peter Rosin
2016-10-20 15:29     ` Lars-Peter Clausen
2016-10-22 14:27       ` Jonathan Cameron [this message]
2016-10-22 14:31     ` Jonathan Cameron
2016-10-20 17:30   ` Jonathan Cameron
2016-10-20 17:37     ` Jonathan Cameron
2016-10-20 18:17       ` Peter Rosin
2016-10-21  7:17         ` jic23
2016-10-21  8:24           ` Peter Rosin
2016-10-21 22:58           ` Peter Rosin
2016-10-22 14:26             ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=923bbaf8-f065-bc05-1f9a-ed703d6746f3@kernel.org \
    --to=jic23@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=peda@axentia.se \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®