mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Subject: [PATCH 03/13] staging: rtl8723bs: Remove #if 1 in function hal_EfuseGetCurrentSize_BT
Date: Sun,  3 Nov 2024 09:14:24 +0100	[thread overview]
Message-ID: <9259ce43226333a4ab4ba400bbfcaa2eead3f5d1.1730619982.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1730619982.git.philipp.g.hortmann@gmail.com>

Remove #if 1 in function hal_EfuseGetCurrentSize_BT to shorten code.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 28 -------------------
 1 file changed, 28 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 2659999404a3..49b6507f991c 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -1028,7 +1028,6 @@ static u16 hal_EfuseGetCurrentSize_BT(struct adapter *padapter, u8 bPseudoTest)
 		/*  only when bank is switched we have to reset the efuse_addr. */
 		if (bank != startBank)
 			efuse_addr = 0;
-#if 1
 
 		while (AVAILABLE_EFUSE_ADDR(efuse_addr)) {
 			if (efuse_OneByteRead(padapter, efuse_addr,
@@ -1057,33 +1056,6 @@ static u16 hal_EfuseGetCurrentSize_BT(struct adapter *padapter, u8 bPseudoTest)
 			/* read next header */
 			efuse_addr += (word_cnts*2)+1;
 		}
-#else
-	while (
-		bContinual &&
-		efuse_OneByteRead(padapter, efuse_addr, &efuse_data, bPseudoTest) &&
-		AVAILABLE_EFUSE_ADDR(efuse_addr)
-	) {
-			if (efuse_data != 0xFF) {
-				if ((efuse_data&0x1F) == 0x0F) { /* extended header */
-					efuse_addr++;
-					efuse_OneByteRead(padapter, efuse_addr, &efuse_data, bPseudoTest);
-					if ((efuse_data & 0x0F) == 0x0F) {
-						efuse_addr++;
-						continue;
-					} else {
-						hworden = efuse_data & 0x0F;
-					}
-				} else {
-					hworden =  efuse_data & 0x0F;
-				}
-				word_cnts = Efuse_CalculateWordCnts(hworden);
-				/* read next header */
-				efuse_addr = efuse_addr + (word_cnts*2)+1;
-			} else
-				bContinual = false;
-		}
-#endif
-
 
 		/*  Check if we need to check next bank efuse */
 		if (efuse_addr < retU2)
-- 
2.43.0


  parent reply	other threads:[~2024-11-03  8:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-03  8:14 [PATCH 00/13] staging: rtl8723bs: Replace function pointers and #if 1 Philipp Hortmann
2024-11-03  8:14 ` [PATCH 01/13] staging: rtl8723bs: Replace function thread_enter Philipp Hortmann
2024-11-03  8:14 ` [PATCH 02/13] staging: rtl8723bs: Remove #if 1 in function hal_EfusePartialWriteCheck Philipp Hortmann
2024-11-03  8:14 ` Philipp Hortmann [this message]
2024-11-03  8:14 ` [PATCH 04/13] staging: rtl8723bs: Remove #if 1 in function ReadChipVersion8723B Philipp Hortmann
2024-11-03  8:14 ` [PATCH 05/13] staging: rtl8723bs: Remove function pointer check_ips_status Philipp Hortmann
2024-11-03  8:14 ` [PATCH 06/13] staging: rtl8723bs: Remove function pointer SetHwRegHandler Philipp Hortmann
2024-11-03  8:14 ` [PATCH 07/13] staging: rtl8723bs: Remove function pointer GetHwRegHandler Philipp Hortmann
2024-11-03  8:14 ` [PATCH 08/13] staging: rtl8723bs: Remove function pointer SetHwRegHandlerWithBuf Philipp Hortmann
2024-11-03  8:14 ` [PATCH 09/13] staging: rtl8723bs: Remove function pointer GetHalDefVarHandler Philipp Hortmann
2024-11-03  8:14 ` [PATCH 10/13] staging: rtl8723bs: Remove function pointer SetHalDefVarHandler Philipp Hortmann
2024-11-03  8:14 ` [PATCH 11/13] staging: rtl8723bs: Remove function pointer hal_xmit Philipp Hortmann
2024-11-03  8:14 ` [PATCH 12/13] staging: rtl8723bs: Remove function pointer mgnt_xmit Philipp Hortmann
2024-11-03  8:14 ` [PATCH 13/13] staging: rtl8723bs: Remove function pointer hal_xmitframe_enqueue Philipp Hortmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9259ce43226333a4ab4ba400bbfcaa2eead3f5d1.1730619982.git.philipp.g.hortmann@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®