From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xen.org, linux-kernel@vger.kernel.org,
jgross@suse.com, Stefano Stabellini <stefano@aporeto.com>
Subject: Re: [PATCH v5 11/13] xen/pvcalls: implement poll command
Date: Tue, 24 Oct 2017 10:02:21 -0400 [thread overview]
Message-ID: <92f2c56f-223e-9e47-12eb-6ff0c3d183d1@oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1710231604480.574@sstabellini-ThinkPad-X260>
On 10/23/2017 07:06 PM, Stefano Stabellini wrote:
> On Tue, 17 Oct 2017, Boris Ostrovsky wrote:
>>> +static unsigned int pvcalls_front_poll_passive(struct file *file,
>>> + struct pvcalls_bedata *bedata,
>>> + struct sock_mapping *map,
>>> + poll_table *wait)
>>> +{
>>> + int notify, req_id, ret;
>>> + struct xen_pvcalls_request *req;
>>> +
>>> + if (test_bit(PVCALLS_FLAG_ACCEPT_INFLIGHT,
>>> + (void *)&map->passive.flags)) {
>>> + uint32_t req_id = READ_ONCE(map->passive.inflight_req_id);
>>> +
>>> + if (req_id != PVCALLS_INVALID_ID &&
>>> + READ_ONCE(bedata->rsp[req_id].req_id) == req_id)
>>> + return POLLIN | POLLRDNORM;
>>
>> Same READ_ONCE() question as for an earlier patch.
> Same answer :-)
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>
>
>>> +
>>> + poll_wait(file, &map->passive.inflight_accept_req, wait);
>>> + return 0;
>>> + }
>>> +
next prev parent reply other threads:[~2017-10-24 14:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-07 0:30 [PATCH v5 00/13] introduce the Xen PV Calls frontend:wq Stefano Stabellini
2017-10-07 0:30 ` [PATCH v5 01/13] xen/pvcalls: introduce the pvcalls xenbus frontend Stefano Stabellini
2017-10-07 0:30 ` [PATCH v5 02/13] xen/pvcalls: implement frontend disconnect Stefano Stabellini
2017-10-17 16:01 ` Boris Ostrovsky
2017-10-23 22:44 ` Stefano Stabellini
2017-10-07 0:30 ` [PATCH v5 03/13] xen/pvcalls: connect to the backend Stefano Stabellini
2017-10-07 0:30 ` [PATCH v5 04/13] xen/pvcalls: implement socket command and handle events Stefano Stabellini
2017-10-17 16:59 ` Boris Ostrovsky
2017-10-20 1:26 ` Stefano Stabellini
2017-10-20 14:24 ` Boris Ostrovsky
2017-10-07 0:30 ` [PATCH v5 05/13] xen/pvcalls: implement connect command Stefano Stabellini
2017-10-07 0:30 ` [PATCH v5 06/13] xen/pvcalls: implement bind command Stefano Stabellini
2017-10-17 17:39 ` Boris Ostrovsky
2017-10-20 1:31 ` Stefano Stabellini
2017-10-20 14:40 ` Boris Ostrovsky
2017-10-07 0:30 ` [PATCH v5 07/13] xen/pvcalls: implement listen command Stefano Stabellini
2017-10-07 0:30 ` [PATCH v5 08/13] xen/pvcalls: implement accept command Stefano Stabellini
2017-10-17 18:34 ` Boris Ostrovsky
2017-10-23 23:03 ` Stefano Stabellini
2017-10-24 13:52 ` Boris Ostrovsky
2017-10-24 16:42 ` Stefano Stabellini
2017-10-07 0:30 ` [PATCH v5 09/13] xen/pvcalls: implement sendmsg Stefano Stabellini
2017-10-17 21:06 ` Boris Ostrovsky
2017-10-20 1:41 ` Stefano Stabellini
2017-10-20 14:44 ` Boris Ostrovsky
2017-10-07 0:30 ` [PATCH v5 10/13] xen/pvcalls: implement recvmsg Stefano Stabellini
2017-10-17 21:35 ` Boris Ostrovsky
2017-10-20 1:38 ` Stefano Stabellini
2017-10-20 14:43 ` Boris Ostrovsky
2017-10-07 0:30 ` [PATCH v5 11/13] xen/pvcalls: implement poll command Stefano Stabellini
2017-10-17 22:15 ` Boris Ostrovsky
2017-10-23 23:06 ` Stefano Stabellini
2017-10-24 14:02 ` Boris Ostrovsky [this message]
2017-10-07 0:30 ` [PATCH v5 12/13] xen/pvcalls: implement release command Stefano Stabellini
2017-10-24 14:17 ` Boris Ostrovsky
2017-10-24 17:17 ` Stefano Stabellini
2017-10-07 0:30 ` [PATCH v5 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92f2c56f-223e-9e47-12eb-6ff0c3d183d1@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=stefano@aporeto.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®