From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DFF94AE8A0 for ; Wed, 7 Oct 2026 14:05:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791381941; cv=none; b=K69CK9UIeq4gVwZekbFhC8UXiXijb1WCn4YSI0ELbQPXo6GP0J79jvxjiav7VxueRzDWCC+REtsQROnKmRmQSq60F7MZ0uG2Zp1vXnFRCBMMoglkXFEZJfDhamCEFqhlbPLBCVgmgDqh8KF2+XK0OFo+MlDWhgGDa293+VLAYpY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791381941; c=relaxed/simple; bh=V7wCXFfMiY8I3U4QW7xgovTFawhq2OF8NsZcAprNCLc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bRbgJjcM/z+uHHxwQBMhV9i229g93NZ8RuTKYcSeezJCB9sa2zs9oOGG+MwD4uJSlYJG5s+Uw2o5kMXW2BOCqevhsRvAwn/A/Bxla7DrA0GTdObLxckWpe/alzWyz409cI0D1taS5hOkQA7cOk2/FLVISmVq2mO+Hf6GY04Ym7M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b=PDA4CzXZ; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b="PDA4CzXZ" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-3a80d1c98f5so2306356a91.0 for ; Wed, 07 Oct 2026 07:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20251104.gappssmtp.com; s=20251104; t=1791381933; x=1791986733; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2tZULonu7kKZiIqDdMHG3M16ndJSJFse/YYFR6ZGm68=; b=PDA4CzXZVp6XIMVR4rSohNCjpWBfkxope7IT5M2ZWrsgom480Z/UP01vKISCHF2G2Z CCpY+z5xLDtaGFvhS2U/L74Jm9YVzBJVqHUn+OBzaPEXtDCna5adkSXhG8h6FFIQ87ks LvJEMmHWWSyWBy9scoIlPZjgNX/EtGID24DRyYNg2B9sfk8OkpbDxeuXhUeNjhJwEpmm heiICQJXz+gjxuQXlR6+Pz3YwyEj1fXtUCkRotDcOuNbpEmrhtt7LAM8WvS6CF43vj7L Vne4sw9XzFQ19KaacvBgudTsfUoept3pFiO5znr3scvW1kgrig6bjCR/tRiZI6VBFc+2 rJHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791381933; x=1791986733; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2tZULonu7kKZiIqDdMHG3M16ndJSJFse/YYFR6ZGm68=; b=oOWbHimUJlik+QhcJ38n9xDxO1WR8B+xRhU+AYjiYIniyMTFoF5Bb1Uoc4oGFhHJ8Y OPfrezbRTxzBa3L81pLmz+8d+c2zVPLvYNEvaUvqyW4C/KjNT8N5/DiSPH3UV0VG2gcN xhuejGkwXyv5PpYYp4nRN8o/Gj/O3RxLGN7aTFoWKVmvrloSNwczxx3o20K2hDi2ewTK PTauF9sKvJ+gTLLlOHA3eVpsXQh0F4TpVrC4+sQ1trJebIclISmixAoYnFL983KI3B6J hRdwZYzG+OAiK/RtMaj/3hUvbb6KuoLLTcqsLpx0ykdBcqZGwrCoR2qbIaAnURXCx33g hzlg== X-Forwarded-Encrypted: i=1; AKwUvBxXFo1X5yHmgcKLv6gsvbKMaWyq0ubggkX/lbU3POiVnXPE7KqMBxdcAo9TFkxIjbejyNkVdJglp/UwqnU=@vger.kernel.org X-Gm-Message-State: AFq9FYJ2SkvtFbD5j0L8ihNIkgzz4U1iefLo/VjI20x/74utB2UJp0ew 8ZQ3QilgX8DtOCA0c16LIVWoq/qyjfW4HpTqCZugPNWPeCVkfJB8mip8ViZ630uhgIA= X-Gm-Gg: AYBFou0+yWcrWHZp1O6UTyqr6wWJCEoIqEqdF0IJN7WSd3IfJc080wuTylStbIKam5t rAIAt4D9EYTDIIi7rqqwxGFBgq/2Cukiv+tOTwh6SzBLlwSSdQ8fzd4wsdppUTAqnlo/bsCHV7/ kda9m4JjGPSAw/egrcuXvzE/87ifPDW4c4zlWzNtC1kPyqosiA7fDsUDB/Aucw7YnWF1qR0YUO6 9Ir7hNC4vwwvZ3lgQLf3n4cjOg5o3EowitC+pqL6mEFPBU2JZLezX6RteXPZgNyIyM3Fcbbf6P/ H3s9MoCW2oIPWhHw9bmFTn5xkwdVAFOqaZZ+CjhfpAmixzv3gjrBwUBDkH1aV+0rpNGV4eox4Bw QHKdMdKPZCJHh84/5BBOuBXyFB8/h2prfxeIe3xOAJfmWUTsgbRcv/+nxceW2uDIse9Yn4aA/Rk bEqY87q3yYt2M9md7v5Ky73MPF5bPhObWjb+RPBApZsM2JQs12wJ9E8YMbSjyed8E2TQCr74Yv/ BV0cLVoFGVtNJLseNx6TGz4bCg27PBTxt4X3udtP0gPotCwN+KvQwhudA== X-Received: by 2002:a17:90b:4d02:b0:3a4:6f38:f2a2 with SMTP id 98e67ed59e1d1-3a8a1ac0562mr1978385a91.25.1791381933049; Wed, 07 Oct 2026 07:05:33 -0700 (PDT) Received: from [192.168.1.106] ([198.8.77.135]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a8543b0c1fsm13716636a91.14.2026.10.07.07.05.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Oct 2026 07:05:32 -0700 (PDT) Message-ID: <960b1305-c5a6-4554-8bab-1cf4244fa11b@kernel.dk> Date: Wed, 7 Oct 2026 08:05:23 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/9] block device fixes for large block sizes, IOCB_NOWAIT, and direct I/O To: Tal Zussman , Christoph Hellwig , Johannes Thumshirn , Luis Chamberlain , Hannes Reinecke , "Matthew Wilcox (Oracle)" , John Garry , Christian Brauner , "Darrick J. Wong" , Keith Busch , "Martin K. Petersen" Cc: Shin'ichiro Kawasaki , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Sashiko References: <20260923-blkdev-fixes-v5-0-89e60d66eb38@columbia.edu> Content-Language: en-US From: Jens Axboe In-Reply-To: <20260923-blkdev-fixes-v5-0-89e60d66eb38@columbia.edu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/23/26 5:56 PM, Tal Zussman wrote: > A set of independent fixes for the block device file operations. The > first two were found by Sashiko while reviewing the RWF_DONTCACHE series > [1]. The fourth and fifth were found by Sashiko's review of v1 of this > series, and the rest came from asking an LLM to find any similar or > related issues. Each issue has been reproduced, with the fixes resolving > the issues. > > Patch 1 fixes silently lost mmap writes with CONFIG_BUFFER_HEAD=n. > > Patches 2 and 3 take i_rwsem around the direct I/O write fallback and > the splice read path, which race set_blocksize() changing the mapping's > minimum folio order. > > Patch 4 makes the buffered read path honor IOCB_NOWAIT instead of > blocking on i_rwsem. > > Patch 5 makes IOCB_ATOMIC writes fail instead of tearing, and patch 6 > stops the buffered fallback from retrying an atomic write. Block > devices can reject both paths into the fallback before submitting any > I/O, so we fail rather than issue a WARN() like ext4 does. Patch 7 > makes iomap_file_buffered_write() reject IOCB_ATOMIC, so no other > buffered fallback can complete an atomic write either. > > Patch 8 fixes leaked page pins in bio_iov_iter_align_down(), and patch > 9 removes dead metadata handling in the async direct I/O path. > > These issues are currently unlikely to be hit in practice due to the > specific configurations required to trigger them. > > The reproducer for patch 1 is in blktests as block/048, and tests for > patches 2, 3 and 8 are posted at [2]. This is based against the 7.3 series for some reason, can you please resend against the 7.4 based branch, for-7.4/block. -- Jens Axboe