From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0601F3B0AED for ; Tue, 9 Jun 2026 16:26:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781022418; cv=none; b=Ic3hF6Bo05ts9Bt4x762ooE/JnADWZPjSRgLjPDjh80cWb7ekDKXJn5Mp11Dv85cWeE8anVXaHKa6Z9hj5b6q18n/2fM9a7f+if2ag9jbuhMkyMr/M3vaGFeQ3ajPehkgJpaS+fVbb+y0p69b9T0KkAhIMpGMYACWbZSkaVVnUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781022418; c=relaxed/simple; bh=b6i0QHfI6vHptPMgKOzUBkSEqr9l+Lzk9lV+EwXdi3w=; h=Content-Type:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To; b=cLtIabNZPEr5aCFnzyHdi1FksD31lXkHSOJos19Eh+Jw2bjZMgFB0n+E4o2O3Rv38kz5lOfsenXhsb17VCN1HsXKB9AkzbfcAitsiYVyPBtH5GmLRNonsY8u1ENr7kZ39aCh9T1l1maNYb42RLRq/OVtdPMkb7zHpKt1OT1X7jI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jR1aK/7B; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jR1aK/7B" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1781022416; x=1812558416; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to; bh=b6i0QHfI6vHptPMgKOzUBkSEqr9l+Lzk9lV+EwXdi3w=; b=jR1aK/7BxYi1Aaxts8Gl5lIFPR4FnNMUZJrUb1a8pz8+5tYTR/vbbIlU U620d49N3BN5QDBZ1b+BLRd7ZLj7jwFjMnLTwMnTniJ/TbFvQxgZdFSVR G0MA50RoqL8V5La4AiOlGjQVo1TKWLwGXUz++X/EUDFLYfZRD+4gSDuF+ L5EY+KLgji7z22gAfanVMPTAngXTX0+0z5kT7yMnyx20PLDQCEqOTi0sc rK1WPfHeYzWm8l2+SiBhZl++MACeMkfI4vg/Jl0KcbPAL4H73AHMg2g80 SlyDPnm9X46qf4Kua7Ky2oSsZ9AvNTOQBuKFiw4pot+COD8b6Us8i07/Z Q==; X-CSE-ConnectionGUID: OQawOjy4RjqwvQAmiB0aUA== X-CSE-MsgGUID: a6YjU6asT+aO2MDo7ppFLg== X-IronPort-AV: E=McAfee;i="6800,10657,11812"; a="92111167" X-IronPort-AV: E=Sophos;i="6.24,196,1774335600"; d="scan'208,223";a="92111167" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2026 09:26:55 -0700 X-CSE-ConnectionGUID: fkxjASyEQHGPNBqQCVbH+w== X-CSE-MsgGUID: HBoQv+OtTbmf2sM7oyUL9A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,196,1774335600"; d="scan'208,223";a="245061601" Received: from bradocaj-mobl.ger.corp.intel.com (HELO [10.125.109.207]) ([10.125.109.207]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2026 09:26:55 -0700 Content-Type: multipart/mixed; boundary="------------Ki0AG70TQ0yItZZLiQG4DWIr" Message-ID: <96f75bf8-6aac-4fd1-b272-c29e726aead8@intel.com> Date: Tue, 9 Jun 2026 09:26:51 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/mm: Consolidate SME comments and use break To: Thorsten Blum Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org References: <20260609113016.296259-2-thorsten.blum@linux.dev> <26e29657-1e41-4f88-b2f6-8111a3b6e6ff@intel.com> Content-Language: en-US From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: This is a multi-part message in MIME format. --------------Ki0AG70TQ0yItZZLiQG4DWIr Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/9/26 08:32, Thorsten Blum wrote: > On Tue, Jun 09, 2026 at 07:23:14AM -0700, Dave Hansen wrote: >> On 6/9/26 04:30, Thorsten Blum wrote: >>> Combine the two SME comments and use break instead of return to exit the >>> switch consistently with the other cases. >> Hey Thorsten, >> >> While this arguably makes the code a wee bit more consistent, it does it >> at the cost of churn. Churn can introduce bugs. It creates conflicts >> with other work and it muddies the git history. I don't think the >> risk/return on this kind of thing is worth it. >> >> Also, for pure cleanups, I'd personally appreciate seeing them >> concentrated really close after -rc1. > I initially just wanted to fix the broken indentation/formatting here: > > if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT)) { > /* > * SME is mutually exclusive with any of the SEV > * features below. > */ > pr_cont(" SME\n"); > return; > } > > And then decided to combine both comments and replace return with break > while at it. Yeah, you saw the loose thread and kept pulling. ;) There are tons of things in the tree that are ugly or don't meet modern standards. If they're not a hindrance to development, I tend to just grumble and leave them alone. Otherwise, all I would be doing all day is fixing these things up. If I took every patch to fix them up, all I'd be doing all day was merging patches to fix them up. I actually spend a time regularly doing archaeology to figure out how code came to be the way it is. More than half of that time is spent tracking through "cleanups" that don't help me get the answers I seek. If the code is ever moved or refactored or changed, I'm all for fixing these. But that's a privilege folks earn doing a series that fixes bugs or refactors code to prepare for a new feature. Oh, and there's also the problem of: ❯ find me three coding style problems in arch/x86 and commit patches to fix them being able to produce streams of patches like I've attached. --------------Ki0AG70TQ0yItZZLiQG4DWIr Content-Type: text/x-patch; charset=UTF-8; name="0001-x86-xen-remove-trailing-whitespace-on-include-line.patch" Content-Disposition: attachment; filename*0="0001-x86-xen-remove-trailing-whitespace-on-include-line.patc"; filename*1="h" Content-Transfer-Encoding: base64 RnJvbSBjMzhjYjU3MWU5ZjQ3Nzg1ODMwMzI5Nzg3MDgyYWQyYmZjNDBiNzliIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZlIEhhbnNlbiA8ZGF2ZUBzcjcxLm5ldD4KRGF0 ZTogVHVlLCA5IEp1biAyMDI2IDA5OjIxOjUzIC0wNzAwClN1YmplY3Q6IFtQQVRDSCAxLzNd IHg4Ni94ZW46IHJlbW92ZSB0cmFpbGluZyB3aGl0ZXNwYWNlIG9uICNpbmNsdWRlIGxpbmUK CkEgc3RyYXkgc3BhY2UgYXQgdGhlIGVuZCBvZiB0aGUgI2luY2x1ZGUgPGFzbS9lODIwL2Fw aS5oPiBsaW5lIHRyaXBzCmNoZWNrcGF0Y2gncyAidHJhaWxpbmcgd2hpdGVzcGFjZSIgRVJS T1IuIE5vIGZ1bmN0aW9uYWwgY2hhbmdlLgoKQ28tQXV0aG9yZWQtQnk6IENsYXVkZSBPcHVz IDQuNyAoMU0gY29udGV4dCkgPG5vcmVwbHlAYW50aHJvcGljLmNvbT4KLS0tCiBhcmNoL3g4 Ni94ZW4vZW5saWdodGVuLmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24o KyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9hcmNoL3g4Ni94ZW4vZW5saWdodGVu LmMgYi9hcmNoL3g4Ni94ZW4vZW5saWdodGVuLmMKaW5kZXggMjNiOTFiZjliNjYzLi44ZmIy YTc5ZWEwY2MgMTAwNjQ0Ci0tLSBhL2FyY2gveDg2L3hlbi9lbmxpZ2h0ZW4uYworKysgYi9h cmNoL3g4Ni94ZW4vZW5saWdodGVuLmMKQEAgLTE3LDcgKzE3LDcgQEAKICNpbmNsdWRlIDxh c20veGVuL2h5cGVyY2FsbC5oPgogI2luY2x1ZGUgPGFzbS94ZW4vaHlwZXJ2aXNvci5oPgog I2luY2x1ZGUgPGFzbS9jcHUuaD4KLSNpbmNsdWRlIDxhc20vZTgyMC9hcGkuaD4gCisjaW5j bHVkZSA8YXNtL2U4MjAvYXBpLmg+CiAjaW5jbHVkZSA8YXNtL3NldHVwLmg+CiAKICNpbmNs dWRlICJ4ZW4tb3BzLmgiCi0tIAoyLjM0LjEKCg== --------------Ki0AG70TQ0yItZZLiQG4DWIr Content-Type: text/x-patch; charset=UTF-8; name="0003-x86-lib-iomem-add-spaces-around-in-string_memcpy_-fr.patch" Content-Disposition: attachment; filename*0="0003-x86-lib-iomem-add-spaces-around-in-string_memcpy_-fr.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAxZWMwYjY4OWI1OGQxODY0YTQ5ZDhlOGQ0NTk0NGY1MGJkNDA1NjA4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZlIEhhbnNlbiA8ZGF2ZUBzcjcxLm5ldD4KRGF0 ZTogVHVlLCA5IEp1biAyMDI2IDA5OjIyOjM2IC0wNzAwClN1YmplY3Q6IFtQQVRDSCAzLzNd IHg4Ni9saWIvaW9tZW06IGFkZCBzcGFjZXMgYXJvdW5kICctPScgaW4KIHN0cmluZ19tZW1j cHlfe2Zyb20sdG99aW8oKQoKQm90aCBzdHJpbmdfbWVtY3B5X2Zyb21pbygpIGFuZCBzdHJp bmdfbWVtY3B5X3RvaW8oKSBkZWNyZW1lbnQgdGhlCnJlbWFpbmluZyBieXRlIGNvdW50IGFm dGVyIGEgMi1ieXRlIG1vdnMgd2l0aCAnbi09MjsnLiBjaGVja3BhdGNoCmZsYWdzIHRoZSBt aXNzaW5nIHNwYWNlczoKCiAgRVJST1I6IHNwYWNlcyByZXF1aXJlZCBhcm91bmQgdGhhdCAn LT0nIChjdHg6VnhWKQoKSW5zZXJ0IHRoZSBjb252ZW50aW9uYWwgc3BhY2VzLiBObyBmdW5j dGlvbmFsIGNoYW5nZS4KCkNvLUF1dGhvcmVkLUJ5OiBDbGF1ZGUgT3B1cyA0LjcgKDFNIGNv bnRleHQpIDxub3JlcGx5QGFudGhyb3BpYy5jb20+Ci0tLQogYXJjaC94ODYvbGliL2lvbWVt LmMgfCA0ICsrLS0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvYXJjaC94ODYvbGliL2lvbWVtLmMgYi9hcmNoL3g4Ni9s aWIvaW9tZW0uYwppbmRleCBjMjBlMDQ3NjRlZGMuLmY2YWNkYWZkNDgwMiAxMDA2NDQKLS0t IGEvYXJjaC94ODYvbGliL2lvbWVtLmMKKysrIGIvYXJjaC94ODYvbGliL2lvbWVtLmMKQEAg LTM4LDcgKzM4LDcgQEAgc3RhdGljIHZvaWQgc3RyaW5nX21lbWNweV9mcm9taW8odm9pZCAq dG8sIGNvbnN0IHZvbGF0aWxlIHZvaWQgX19pb21lbSAqZnJvbSwgc2kKIAl9CiAJaWYgKG4g PiAxICYmIHVubGlrZWx5KDIgJiAodW5zaWduZWQgbG9uZylmcm9tKSkgewogCQltb3ZzKCJ3 IiwgdG8sIGZyb20pOwotCQluLT0yOworCQluIC09IDI7CiAJfQogCXJlcF9tb3ZzKHRvLCAo Y29uc3Qgdm9pZCAqKWZyb20sIG4pOwogCS8qIEtNU0FOIG11c3QgdHJlYXQgdmFsdWVzIHJl YWQgZnJvbSBkZXZpY2VzIGFzIGluaXRpYWxpemVkLiAqLwpAQCAtNTksNyArNTksNyBAQCBz dGF0aWMgdm9pZCBzdHJpbmdfbWVtY3B5X3RvaW8odm9sYXRpbGUgdm9pZCBfX2lvbWVtICp0 bywgY29uc3Qgdm9pZCAqZnJvbSwgc2l6ZQogCX0KIAlpZiAobiA+IDEgJiYgdW5saWtlbHko MiAmICh1bnNpZ25lZCBsb25nKXRvKSkgewogCQltb3ZzKCJ3IiwgdG8sIGZyb20pOwotCQlu LT0yOworCQluIC09IDI7CiAJfQogCXJlcF9tb3ZzKCh2b2lkICopdG8sIChjb25zdCB2b2lk ICopIGZyb20sIG4pOwogfQotLSAKMi4zNC4xCgo= --------------Ki0AG70TQ0yItZZLiQG4DWIr Content-Type: text/x-patch; charset=UTF-8; name="0002-x86-pci-add-missing-space-after-for-keyword-in-pci_f.patch" Content-Disposition: attachment; filename*0="0002-x86-pci-add-missing-space-after-for-keyword-in-pci_f.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA5NTEyZTYyMzk3MjMzZTI2NDY4NTNmMGNjYTJlNWI1OTBmMTA4YTVhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZlIEhhbnNlbiA8ZGF2ZUBzcjcxLm5ldD4KRGF0 ZTogVHVlLCA5IEp1biAyMDI2IDA5OjIyOjEyIC0wNzAwClN1YmplY3Q6IFtQQVRDSCAyLzNd IHg4Ni9wY2k6IGFkZCBtaXNzaW5nIHNwYWNlIGFmdGVyICdmb3InIGtleXdvcmQgaW4KIHBj aV9maXh1cF9pNDUwbngoKSBhbmQgcGNpX2ZpeHVwX3VtY19pZGUoKQoKVHdvIGZvci1sb29w cyBpbiBhcmNoL3g4Ni9wY2kvZml4dXAuYyB3ZXJlIHdyaXR0ZW4gYXMgJ2ZvcignIGluc3Rl YWQgb2YKJ2ZvciAoJywgd2hpY2ggY2hlY2twYXRjaCBmbGFncyBhczoKCiAgRVJST1I6IHNw YWNlIHJlcXVpcmVkIGJlZm9yZSB0aGUgb3BlbiBwYXJlbnRoZXNpcyAnKCcKCk5vIGZ1bmN0 aW9uYWwgY2hhbmdlLgoKQ28tQXV0aG9yZWQtQnk6IENsYXVkZSBPcHVzIDQuNyAoMU0gY29u dGV4dCkgPG5vcmVwbHlAYW50aHJvcGljLmNvbT4KLS0tCiBhcmNoL3g4Ni9wY2kvZml4dXAu YyB8IDQgKystLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9hcmNoL3g4Ni9wY2kvZml4dXAuYyBiL2FyY2gveDg2L3Bj aS9maXh1cC5jCmluZGV4IGIzMDFjNmM4ZGY3NS4uMGVlOTBiMjI0Zjk5IDEwMDY0NAotLS0g YS9hcmNoL3g4Ni9wY2kvZml4dXAuYworKysgYi9hcmNoL3g4Ni9wY2kvZml4dXAuYwpAQCAt MjMsNyArMjMsNyBAQCBzdGF0aWMgdm9pZCBwY2lfZml4dXBfaTQ1MG54KHN0cnVjdCBwY2lf ZGV2ICpkKQogCiAJZGV2X3dhcm4oJmQtPmRldiwgIlNlYXJjaGluZyBmb3IgaTQ1ME5YIGhv c3QgYnJpZGdlc1xuIik7CiAJcmVnID0gMHhkMDsKLQlmb3IocHhiID0gMDsgcHhiIDwgMjsg cHhiKyspIHsKKwlmb3IgKHB4YiA9IDA7IHB4YiA8IDI7IHB4YisrKSB7CiAJCXBjaV9yZWFk X2NvbmZpZ19ieXRlKGQsIHJlZysrLCAmYnVzbm8pOwogCQlwY2lfcmVhZF9jb25maWdfYnl0 ZShkLCByZWcrKywgJnN1YmEpOwogCQlwY2lfcmVhZF9jb25maWdfYnl0ZShkLCByZWcrKywg JnN1YmIpOwpAQCAtNjEsNyArNjEsNyBAQCBzdGF0aWMgdm9pZCBwY2lfZml4dXBfdW1jX2lk ZShzdHJ1Y3QgcGNpX2RldiAqZCkKIAlpbnQgaTsKIAogCWRldl93YXJuKCZkLT5kZXYsICJG aXhpbmcgYmFzZSBhZGRyZXNzIGZsYWdzXG4iKTsKLQlmb3IoaSA9IDA7IGkgPCA0OyBpKysp CisJZm9yIChpID0gMDsgaSA8IDQ7IGkrKykKIAkJZC0+cmVzb3VyY2VbaV0uZmxhZ3MgfD0g UENJX0JBU0VfQUREUkVTU19TUEFDRV9JTzsKIH0KIERFQ0xBUkVfUENJX0ZJWFVQX0hFQURF UihQQ0lfVkVORE9SX0lEX1VNQywgUENJX0RFVklDRV9JRF9VTUNfVU04ODg2QkYsIHBjaV9m aXh1cF91bWNfaWRlKTsKLS0gCjIuMzQuMQoK --------------Ki0AG70TQ0yItZZLiQG4DWIr--