From: Johannes Berg <johannes@sipsolutions.net>
To: Devin Wittmayer <lucid_duck@justthetip.ca>,
linux-wireless@vger.kernel.org
Cc: Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo@kernel.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Oscar Alfonso Diaz <oscar.alfonso.diaz@gmail.com>,
fjhhz1997@gmail.com
Subject: Re: [PATCH v4] wifi: mac80211: fix monitor mode frame capture for real chanctx drivers
Date: Wed, 03 Jun 2026 14:10:09 +0200 [thread overview]
Message-ID: <978c9a11cf836680b1fd9365f3b90f028ddf5372.camel@sipsolutions.net> (raw)
In-Reply-To: <20260519235713.49109-2-lucid_duck@justthetip.ca>
On Tue, 2026-05-19 at 16:57 -0700, Devin Wittmayer wrote:
>
> Cc: stable@vger.kernel.org # 6.9+
No. It's known to crash drivers on some versions, so it should
explicitly opt out of stable by
Cc: <stable+noautosel@kernel.org> # causes some older drivers to crash
> - if (chanctx_conf)
> + if (chanctx_conf) {
> chandef = &chanctx_conf->def;
> - else if (local->emulate_chanctx)
> - chandef = &local->hw.conf.chandef;
> - else
> - goto fail_rcu;
> + } else {
> + struct ieee80211_chanctx *ctx;
> +
> + ctx = list_first_or_null_rcu(&local->chanctx_list,
> + struct ieee80211_chanctx, list);
> + if (!ctx ||
> + rcu_access_pointer(ctx->list.next) != &local->chanctx_list)
> + goto fail_rcu;
This results in a sparse warning, maybe my loop approach was better
after all.
johannes
next prev parent reply other threads:[~2026-06-03 12:10 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 16:45 [PATCH] " 傅继晗
2026-03-09 6:53 ` Johannes Berg
2026-03-09 10:45 ` 傅继晗
2026-03-16 10:38 ` Johannes Berg
[not found] ` <CA+bbHrX+xby2_drzo0457raoz-kgQ6eTCCHU91pR5BkvzMiq_A@mail.gmail.com>
2026-03-19 11:40 ` Óscar Alfonso Díaz
2026-03-25 0:15 ` 傅继晗
2026-03-25 10:59 ` Óscar Alfonso Díaz
2026-03-26 1:37 ` [PATCH v2] wifi: mac80211: fix the issue of NULL pointer access when deleting the virtual interface 傅继晗
2026-03-26 12:16 ` Óscar Alfonso Díaz
2026-03-29 21:55 ` Óscar Alfonso Díaz
2026-04-02 0:06 ` Óscar Alfonso Díaz
2026-04-21 8:50 ` Óscar Alfonso Díaz
2026-04-24 12:08 ` [PATCH] wifi: mac80211: restore monitor injection when coexisting with another VIF Brite
2026-04-24 12:17 ` Greg KH
2026-04-24 13:55 ` Johannes Berg
2026-04-24 14:17 ` Óscar Alfonso Díaz
2026-04-24 17:22 ` Brite
2026-04-25 0:34 ` Brite
2026-04-25 1:47 ` Lachlan Hodges
2026-04-25 2:43 ` Brite
2026-04-26 9:25 ` Óscar Alfonso Díaz
2026-05-18 6:38 ` [PATCH v2 0/1] wifi: mac80211: fix monitor mode frame capture for real chanctx drivers Devin Wittmayer
2026-05-18 6:40 ` [PATCH v2 1/1] " Devin Wittmayer
2026-05-18 6:42 ` Johannes Berg
2026-05-18 17:01 ` [PATCH v3 0/1] " Devin Wittmayer
2026-05-18 17:01 ` [PATCH v3] " Devin Wittmayer
2026-05-19 7:02 ` Johannes Berg
2026-05-19 23:56 ` Devin Wittmayer
2026-05-19 23:57 ` [PATCH v4 0/1] " Devin Wittmayer
2026-05-19 23:57 ` [PATCH v4] " Devin Wittmayer
2026-05-20 6:49 ` Óscar Alfonso Díaz
2026-05-20 7:42 ` Johannes Berg
2026-05-20 8:02 ` Óscar Alfonso Díaz
2026-05-20 8:58 ` Johannes Berg
2026-05-20 9:51 ` Óscar Alfonso Díaz
2026-05-20 9:53 ` Johannes Berg
2026-05-20 9:55 ` Óscar Alfonso Díaz
2026-06-02 8:29 ` Óscar Alfonso Díaz
2026-06-03 11:54 ` Óscar Alfonso Díaz
2026-06-03 12:09 ` Johannes Berg
2026-06-03 12:10 ` Johannes Berg [this message]
2026-06-03 19:28 ` [PATCH v5 0/1] " Devin Wittmayer
2026-06-03 19:28 ` [PATCH v5 1/1] " Devin Wittmayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=978c9a11cf836680b1fd9365f3b90f028ddf5372.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=fjhhz1997@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=lucid_duck@justthetip.ca \
--cc=nbd@nbd.name \
--cc=oscar.alfonso.diaz@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®