From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 705DDC77B73 for ; Wed, 31 May 2023 08:32:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234604AbjEaIb7 (ORCPT ); Wed, 31 May 2023 04:31:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234745AbjEaIb4 (ORCPT ); Wed, 31 May 2023 04:31:56 -0400 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09E4411F for ; Wed, 31 May 2023 01:31:49 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R741e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0Vjwun5s_1685521906; Received: from 30.221.133.46(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0Vjwun5s_1685521906) by smtp.aliyun-inc.com; Wed, 31 May 2023 16:31:47 +0800 Message-ID: <997002c8-2008-3209-3542-2ac0bbda99c3@linux.alibaba.com> Date: Wed, 31 May 2023 16:31:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 4/5] erofs: unify inline/share xattr iterators for listxattr/getxattr To: Jingbo Xu , xiang@kernel.org, chao@kernel.org, huyue2@coolpad.com, linux-erofs@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org References: <20230531031330.3504-1-jefflexu@linux.alibaba.com> <20230531031330.3504-5-jefflexu@linux.alibaba.com> <349a1523-6d1c-9e96-d948-78dd4f2a209d@linux.alibaba.com> From: Gao Xiang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/5/31 16:16, Jingbo Xu wrote: > > > On 5/31/23 2:57 PM, Gao Xiang wrote: >> >> >> On 2023/5/31 11:13, Jingbo Xu wrote: >>>   -static int inline_xattr_iter_begin(struct erofs_xattr_iter *it, >>> -                   struct inode *inode) >>> -{ >>> -    struct erofs_inode *const vi = EROFS_I(inode); >>> -    unsigned int xattr_header_sz, inline_xattr_ofs; >>> - >>> -    xattr_header_sz = sizeof(struct erofs_xattr_ibody_header) + >>> -              sizeof(u32) * vi->xattr_shared_count; >>> -    if (xattr_header_sz >= vi->xattr_isize) { >>> -        DBG_BUGON(xattr_header_sz > vi->xattr_isize); >>> -        return -ENOATTR; >>> -    } > > In the original implementation, here when xattr_header_sz >= > vi->xattr_isize, inline_xattr_iter_begin() will return -ENOATTR rather > than a negative integer (i.e. vi->xattr_isize - xattr_header_sz). Ah, sorry I misreaded that. Thanks, Gao Xiang