From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF8823F484B for ; Mon, 15 Jun 2026 12:30:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781526666; cv=none; b=VgF15oOCO/iHhOl8nUdyXdKCDUMwFwJSuDzrI84V4HgI+V0n2MC9R8q3zWzpL1C9AYyHQagKHt24XNiUTOQNl9Q20Gn0fOHSz35OK4YFtPjmDlZfbgSvq3cNaY6wPuoEBbqcI3JvzUBQyQoB9RoDiRvPp7cajQIcJOrWZXsBne0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781526666; c=relaxed/simple; bh=4nzEpuGwgNL0R2NblpKrggs9ml7l1I1ZGGJOsujlLzg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Iiv+IQXtqQwpb+KduiTYvI4LW7hzYyGSBRsnhqfBok4xpZAs416yOcj3VpGuVjYD74VewY649drmopwRcLmzoKV4aa6EqB9c6EJ9Tz0jReEnB5eZz5rxWYIUXf7lAsrpQDgpTCfIwwGqWuIv01VpF8puutXgsMh1qNfEUg6OdZ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=R51mfMBx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ELsRiAeh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="R51mfMBx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ELsRiAeh" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FApRt6298290 for ; Mon, 15 Jun 2026 12:30:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KiXHBkLlgkRaXk44sFimwo5t89c600tXG9f+rJEMgMI=; b=R51mfMBxrAYMYcOE Xy8Kn+eR8j/pJLt7NGydvGed32wbCQAW0d8UEsEsl147osIxIdl3VrmMiA2137ag rnKtpFD1XuDtDKXSv+ltL1OvXHp+7bbilNTZ155ZKPnSdfPIN5uuD1daEPctXyZf U2J5OxjGpYc+5WGI0hr9WnG6LObZV+aZAt5uDaUUmoiJzG0+21PHeWOkCgfTAUPF 4HjLBmTP8FSWI+ugJCM8+1BXK+E5tLXiuqNanewOk1IGN7iIP/xJtrWkadwJxGQ6 Tzq2Tp3oLmmMt8Z++VHpFVo6QxEUuRYlbX8mb7d6m9xr6gHlyPPc+R7/5X8ChaSN y+BWLA== Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eter20pc7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 12:30:53 +0000 (GMT) Received: by mail-oi1-f200.google.com with SMTP id 5614622812f47-486417cc069so5059313b6e.0 for ; Mon, 15 Jun 2026 05:30:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781526653; x=1782131453; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KiXHBkLlgkRaXk44sFimwo5t89c600tXG9f+rJEMgMI=; b=ELsRiAehlCoKQp9E1oAFvqF4o5PhJLvFhC3MEVROEgyVg7npOqLMli50g3hptkluup mSQk5Ctj9Sh+3+QFi77YoACppjBCt3Mc7+MipnEVfPQtlOiceIbHJ11c6ZnJNY/VgYZy lXvIwbqcU2lKGZ2Ch+Vp/mV64GntRokI8/KF+QB56tiyRJYOi7z+wr9O2YZq6dTBUJgj 4TOY/UrJIwdPZTO/pRdEfzNWP59W8QKwL8V6yRnUcKzNistXxaR3aIPz3ntzuNES24bb NM+ShxXY5MG8sYd3J2TCFQ+7gQnaKqi6ccvIyEkCkwa4dHZLXsZWWujTEHMtfCG7dXa5 gMjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781526653; x=1782131453; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KiXHBkLlgkRaXk44sFimwo5t89c600tXG9f+rJEMgMI=; b=C0893coMTVa699gP76yTqmKlMeI1BowB1YI4CNwCLsys6qBvre8wAIaZbkvobnZU/E YFM82TiVthMOQoJ4tB9qrD6fguVrT+8lv0/outLmqdTztBADDkhjdEZ7H6Q3Tk5/oxq1 n5n1eKUUx8//nQrugTxinuiQNNLsTrYLqbhqqgRPJ6BtrkliT7Ba9IJsLdC5GL2VDvyO 50PTSBmQuKEkLTot10df1tluqdSS5F/CxptpAKxWpsVpMHEv3fcdAsRv62GK9D52fZtd 38WzPgEcho8Nk9DQRvcLo/M8oTq1hwe4+JbUa6V1ANxuiWjss3DbRWOe8jVyxvxRb1iB v02g== X-Forwarded-Encrypted: i=1; AFNElJ+SOC04JPpx2l/xz4h99IrSccsY2gPHQp7cG+Wnow+OB9WyX963BCkgJv2p4F0liXXsUcley4JIBFZQMk4=@vger.kernel.org X-Gm-Message-State: AOJu0YwWQqIYlnlsxVmzMpk7YPQ2Hub4nJRlDVuvdJDmD1a3McSpYt/+ lwd+xZxPwrTwDPeOPvswF222JG20dFvkhGB4pjfWHSzWXYu6cMns6n7ZhDO7G1lloqyZv1xnV3j S3H9dgtkrQ89EB3/H+1eYiPllEL+v//UmEiMzxw2BaZ+XvxMuvqKmX06lNINqFe1CmcA= X-Gm-Gg: Acq92OFwULmZm8FdCX8N+FmMb33EyvBsWSalD4UR2SN8q1kgHmbkhYf/RqBeyFhW1ia 0iEuehQEAvv1o4b1vhyTrkJIRBiXi1MiTlTHCJWAtF8HvBXqTjFMmcNeGLHaba36oP4HEYZt3CU ZzjLFYTKep2uBw+NwgtoFKoBXDEnaSQtX4dhbrWt29O/ne72LK5tIjz0QlcDgsE9m3DxytBGaRA 8RE2lLmdK1LRL0RYH2MW45OcCCa1Q0QWvC4V4QgIVthIqIGAYza52x/ikVXJYzJS4/+PkPGTy06 B2N5bcfRoV3S7DwZvvs1AScsDwy8O3e5jj39UpNTFVrs5UGEOYCdd/rOgvhzgeVS33GYH69saT5 IHMBt1TTI5s3o4t6q0lSg0wYXt3U8k3Kl+AhXruGwzejYdAcDUSz98YNgjXHw8dvciARlmLHcT8 BTUdV8O7qqb8XJag== X-Received: by 2002:a05:6808:6f91:b0:486:7e34:ebac with SMTP id 5614622812f47-4872f608696mr9488782b6e.42.1781526652567; Mon, 15 Jun 2026 05:30:52 -0700 (PDT) X-Received: by 2002:a05:6808:6f91:b0:486:7e34:ebac with SMTP id 5614622812f47-4872f608696mr9488748b6e.42.1781526652092; Mon, 15 Jun 2026 05:30:52 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:b0eb:75fa:2a81:cf30? ([2a05:6e02:1041:c10:b0eb:75fa:2a81:cf30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490ea963cf8sm203208835e9.2.2026.06.15.05.30.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 05:30:51 -0700 (PDT) Message-ID: <9a31bb29-75d7-42fa-b8a8-4155cf85cadf@oss.qualcomm.com> Date: Mon, 15 Jun 2026 14:30:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/8] dt-bindings: remoteproc: qcom,pas: add thermal mitigation properties To: Gaurav Kohli , Krzysztof Kozlowski Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Amit Kucheria , Manivannan Sadhasivam , Konrad Dybcio , Kees Cook , "Gustavo A. R. Silva" , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Manaf Meethalavalappu Pallikunhi References: <20260609-qmi-tmd-v3-0-291a2ff4c634@oss.qualcomm.com> <20260609-qmi-tmd-v3-1-291a2ff4c634@oss.qualcomm.com> <20260610-ocelot-of-stimulating-excellence-bcb0fe@quoll> <03d863ee-2caa-41f2-94b5-7332fc930b42@oss.qualcomm.com> <7f1e46fb-15e3-4638-9930-8abc1dd5a778@oss.qualcomm.com> <3cbcaf8c-357e-42d2-91c1-9d1a32c55ed0@oss.qualcomm.com> Content-Language: en-US From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDEzMiBTYWx0ZWRfX+5q0q2En60DC 95+TNxfTxn8gnUm7tmaH29fD7mpfu7mw6L0CIE7gz7Ze+dc6BcrJ7Ahw9micEhY43dd/uuprIUZ lO6woZxxvd7G73mMLV/6vSXkWVFJlYQ= X-Proofpoint-GUID: 5uVvbbSPnj3S3i2twRfVTuwL0sDr_QAE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDEzMiBTYWx0ZWRfX3yATFUV3OSDz eLWvya0rT1SfoaxfI8VC80WCw1g4pvSt+k12l5Sh9VTEHNO//0E09dCZJ+iJpH5ojf06rRM7/78 PC8oT1qc13vMGoBhE211b4BN1FF02bd1ItEz0hJgxTkmFzIrFcbGz1RqZMtVEBVJNr38ZCjmljz 9JIA8UbPcndTsmQPbIfftVeeWZX5TEED1V8zMm5Tq9R7ZyjF24+fPaTPvpHBkdmJQHCMUFwZUd9 MqM+6pPJmyPbmPTxhG2ns5QC37zHsAz6a7aCCMfd9XcRgtB/ypVDf3koino797td7QaCYzKYnIw HTrAYAwbfy32XqiOmhuHWfHWBcEG0c39a9GU3fee3cvzRPqEwuh/tmtFB/zutHs68vQx7d1pFWi v6rqi7gjzSJ13FlKFOzpGD6Wca0472Qrx48mMtYsl7onHkJLzP20rMX8L8un6vVIt4T3Ct3ecpW 80bm0zj8MZGknJGqbfw== X-Authority-Analysis: v=2.4 cv=F4tnsKhN c=1 sm=1 tr=0 ts=6a2ff07d cx=c_pps a=AKZTfHrQPB8q3CcvmcIuDA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=vdW527L6AYu-INn279QA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=pF_qn-MSjDawc0seGVz6:22 X-Proofpoint-ORIG-GUID: 5uVvbbSPnj3S3i2twRfVTuwL0sDr_QAE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_03,2026-06-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 clxscore=1015 impostorscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150132 Hi Gaurav, Le 15/06/2026 à 14:12, Gaurav Kohli a écrit : > > > On 6/15/2026 4:04 PM, Daniel Lezcano wrote: >> On 6/13/26 13:05, Gaurav Kohli wrote: >>> >>> >>> On 6/13/2026 1:11 PM, Krzysztof Kozlowski wrote: >>>> On 12/06/2026 15:52, Gaurav Kohli wrote: >>>>> >>>>> >>>>> On 6/11/2026 5:53 PM, Krzysztof Kozlowski wrote: >>>>>> On 11/06/2026 13:12, Gaurav Kohli wrote: >>>>>>>> Why? And where is this generic property defined? You cannot just >>>>>>>> sprinkle generic properties in random bindings. >>>>>>>> >>>>>>> >>>>>>> Ack, will add why part. >>>>>>> These names are matched with the thermal mitigation device >>>>>>> identifiers >>>>>>> populated by remote firmware over QMI and define mitigation >>>>>>> devices are >>>>>>> exposed as cooling devices. >>>>>> >>>>>> No, -names correspond to values passed via DT, not some remote >>>>>> firmware. >>>>>> The remote firmware should give you interface which is explicit >>>>>> and does >>>>>> not need such properties. >>>>> >>>>> thanks Krzysztof for review, We need tmd-names because of following >>>>> reasons: >>>>> >>>>> Following Daniel's series [1], the thermal framework supports >>>>> mapping multiple cooling devices per remoteproc/device via indexed >>>>> cooling-cells. >>>>> >>>>> 1) The thermal framework's cooling-maps reference >>>>> cooling devices by index (for #cooling-cells = <3>). Without tmd- >>>>> names, >>>>> there's no way to know which index corresponds to which TMD, as >>>>> firmware >>>>> may return tmd-names in any order. >>>>> >>>>> below are the changes post new thermal mapping changes: >>>>> DT: tmd-names = "cdsp_sw", "xyz"; >>>>> Firmware: ["cdsp_sw", "xyz1", "xyz2",] >>>>> Driver registers: Only "cdsp_sw" (index 0) and "xyz" (index 1) >>>> >>>> names property are not to instruct drivers to register or not to >>>> register something. >>>> >>>> I don't understand the problem and explanation in the binding is >>>> basically non-existing. >>>> >>>> Remember that all lists and indices ARE FIXED, so driver knows exactly >>>> which index means what. >>>> >>> >>> thanks for review, shall i use driver data, which is basically pas >>> data structure like below: >>> >>> static const struct qcom_pas_data { >>>      .crash_reason_smem = 601, >>>      .firmware_name = "cdsp.mdt", >>>      .tmd_names = (const char *[]){"xyz", NULL}, >>>      .num_tmds = 1, >>> >>> Is something like above acceptable? and this will also help to filter >>> tmd names as well? >> >> >> How the thermal framework will bind the thermal zone with the TMD ? >> (node pointer, id) ? >> > > Hi Daniel, > > thanks for review. > > With id only, in this case instead of taking tmd names from device tree, > qmi_tmd will take tmd name from pas_data(driver) and register with the > cooling framework with id only. Please let us know if this looks fine. May be I'm missing something but: - The QMI TMD returns a list of names, not ids - The QMI TMD may return the list in different order than assumed - The cooling map index points to the name of the TMD in the DT - This name is used to match the name in the aformentionned list - The index in the list and the id in the DT can differ Krzysztof , I don't get why having the TMD names as properties is wrong, they describes the existing TMDs on the system and the cooling maps index points to the one to be connected with thermal zone.