From: "Jesper Juhl" <jesper.juhl@gmail.com>
To: "Adrian Bunk" <bunk@stusta.de>
Cc: "Peter Zijlstra" <a.p.zijlstra@chello.nl>,
"Trond Myklebust" <trond.myklebust@fys.uio.no>,
linux-kernel@vger.kernel.org
Subject: Re: [-mm patch] #if 0 mm/backing-dev.c:congestion_wait_interruptible()
Date: Tue, 12 Jun 2007 14:40:06 +0200 [thread overview]
Message-ID: <9a8748490706120540p29d00d3cg9d8a4def0d57b783@mail.gmail.com> (raw)
In-Reply-To: <20070612110733.GU3588@stusta.de>
On 12/06/07, Adrian Bunk <bunk@stusta.de> wrote:
> congestion_wait_interruptible() is no longer used.
>
Remind me again why it is that we add all these #if 0 blocks instead
of simply removing the unused code?
It's just creating a janitorial task to go and remove all the #if 0
bits at a later time, seems like pointless churn to me. If the code
needs to go, let's just get rid of it in one go instead of two.
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
next prev parent reply other threads:[~2007-06-12 12:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-12 11:07 Adrian Bunk
2007-06-12 12:23 ` Trond Myklebust
2007-06-12 12:40 ` Jesper Juhl [this message]
2007-06-12 22:57 ` Adrian Bunk
2007-06-15 15:31 ` Jesper Juhl
2007-07-01 20:20 Adrian Bunk
2007-07-03 21:48 ` Andrew Morton
2007-07-03 22:35 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8748490706120540p29d00d3cg9d8a4def0d57b783@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®