From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-99.mta1.migadu.com [95.215.58.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8598F442FAE for ; Thu, 1 Oct 2026 13:12:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790860336; cv=none; b=TKXMQjBrJnjvB6VZ+URmiJVd0u5FOZyUrT5C5clnQdPNKyVWL3TuP9N6gRRkT5yyWAHeFUZAXFYocjA9n+gFCAdDF0VdqRyHclwb5gdHr9jWcr8Zv2fYpX+RMgs9vJ4s73iSlM8Bvhcps6+KkDG9mdaYv897uEF9JFnxklisTmU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790860336; c=relaxed/simple; bh=B1MeEhDRbJ1+eBXmdpTqqYccTAe1bu1lIrhcKUuTIqA=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=ke/sRLh6ryfGOxsdWRJadaRywHO8IEGg6U5vpno1yDQuM8+A5vPSsQWP35WpYJU9c/PC4/TWRO6HO1JAGKFEjeEmwD0AiudFqFS+sI3MCsMZA8axxlI4xMqJpyOa9k1FU2S3UC0/7o3Wsy2W+7B4P79kT++odtuuDz55XtPaZcg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=UZE4ZLvQ; arc=none smtp.client-ip=95.215.58.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="UZE4ZLvQ" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=B1MeEhDRbJ1+eBXmdpTqqYccTAe1bu1lIrhcKUuTIqA=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1790860330; v=1; x=1791465130; b=UZE4ZLvQz1+kRB7m72Y6rgUAz8o2NFrzh/ikH88YscgR97/qIWRhfPoLVssh58UEHYq0yEdp lvBa47bFRpkkDBR1mTXMv6zRAwsLVNTDVcPxAdTMwO6AyHRZF0TftIdzih2qJMYT2Y9ueQXzr3W p8EsUY5tkyifcBs79+INAkfc= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id dc790c4b5c3eabf0; Thu, 01 Oct 2026 13:12:10 +0000 X-Mizu-Trace-ID: dc790c4b5c3eabf0 X-Migadu-Flow: FLOW_OUT Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-5ba4065fa07so7595e87.0 for ; Thu, 01 Oct 2026 06:12:06 -0700 (PDT) X-Forwarded-Encrypted: i=1; AKwUvBzYaN4R6R5BudpPHML+M28jP6z40SB0tUIFZUUmt2/rohtbqCjBDj8vzIrdtrFFnNvEkj9MIc+746Jy3CI=@vger.kernel.org X-Gm-Message-State: AFq9FYIjtx8NfwthCjasmW9O0U5HCnpAL0KvFC91ZSDxjMoRFdNJleX1 HXwuZwKwGHwe9h1ziOaSIleNaYp1Vj8rmlLVfq8tUeOk+4bzbgBTQ3gjs/TT5xN+Ka5QJsyWVKo KGE9c6DYZEnlDIzEg9G7zLOw8LkuxdNNxLLYvcJZF X-Received: by 2002:a05:6512:b8b:b0:5b4:74e2:4171 with SMTP id 2adb3069b0e04-5ba43819ed1mr170584e87.4.1790860325842; Thu, 01 Oct 2026 06:12:05 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260914113338.159227-1-fuad.tabba@linux.dev> <20260914113338.159227-11-fuad.tabba@linux.dev> In-Reply-To: From: Fuad Tabba Date: Thu, 1 Oct 2026 14:11:29 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: AclHuK-BYP5-ESF0Lkngn2s3wyk7cTX09ixjLrcRsslFsyjwg-j-q23Rg_ftXRs Message-ID: Subject: Re: [PATCH v3 10/18] KVM: arm64: Handle PSCI calls for protected VMs at EL2 To: Will Deacon Cc: maz@kernel.org, oupton@kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, mark.rutland@arm.com, steven.price@arm.com, vdonnefort@google.com, qperret@google.com Content-Type: text/plain; charset="UTF-8" On Thu, 01 Oct 2026 13:59:27 +0100, Will Deacon wrote: [...] > > + if (prev != PSCI_0_2_AFFINITY_LEVEL_ON_PENDING) { > > + /* The only other writer of ON_PENDING is the rollback. */ > > + WARN_ON(prev != PSCI_0_2_AFFINITY_LEVEL_OFF); > > If you go with the idea we're discussing later in the thread, then I think > you need to drop this WARN_ON() and the comment that goes with it. Will do, both go in v4. /fuad