From: Linus Walleij <linusw@kernel.org>
To: Ernest Van Hoecke <ernestvanhoecke@gmail.com>
Cc: "Rob Herring" <robh@kernel.org>,
"Saravana Kannan" <saravanak@kernel.org>,
"Miquel Raynal (Schneider Electric)" <miquel.raynal@bootlin.com>,
"Frank Li" <Frank.li@oss.nxp.com>,
"Kieran Bingham" <kieran.bingham@ideasonboard.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Stephen Boyd" <sboyd@kernel.org>,
"Brian Masney" <bmasney@redhat.com>,
"Bartosz Golaszewski" <brgl@kernel.org>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Herve Codina" <herve.codina@bootlin.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Leonardo Costa" <leonardo.costa@toradex.com>,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Ernest Van Hoecke" <ernest.vanhoecke@toradex.com>,
stable@vger.kernel.org
Subject: Re: [PATCH RFC 1/2] of: property: fw_devlink: Follow GPIO nexus maps
Date: Wed, 16 Sep 2026 18:58:56 +0200 [thread overview]
Message-ID: <CAD++jL=qaXxEr_sVnAF7BLUvp4ik+f8Zsg2sKY6n0=DwWqEYYw@mail.gmail.com> (raw)
In-Reply-To: <20260902-fw-devlink-nexus-ready-v1-1-68fe1996e78a@toradex.com>
On Wed, Sep 2, 2026 at 1:42 PM Ernest Van Hoecke
<ernestvanhoecke@gmail.com> wrote:
> From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
>
> GPIO consumers use of_parse_phandle_with_args_map() to resolve specifiers
> through gpio-map properties. fw_devlink instead parses GPIO properties as
> direct phandle references, so it records the nexus node as the supplier
> rather than the mapped GPIO provider.
>
> A nexus is a translation node, not the GPIO provider, and need not be
> populated as a device. The resulting fwnode link can therefore remain
> unresolved and indefinitely defer the consumer while
> device_links_check_suppliers() waits for the nexus.
>
> Use the map-aware parser for all supported GPIO property spellings. This
> makes fw_devlink resolve the same provider as the GPIO consumer API. Direct
> GPIO references continue to work because the map-aware parser returns the
> original provider when no gpio-map property is present.
>
> Add OF unittest coverage for mapped and direct GPIO suppliers, including
> the deprecated singular and unprefixed property spellings.
>
> Fixes: 7f00be96f125 ("of: property: Add device link support for interrupt-parent, dmas and -gpio(s)")
> Reported-by: Leonardo Costa <leonardo.costa@toradex.com>
> Link: https://lore.kernel.org/all/juuc4af7ndbajcl7gzf4tg5qz2q2j5tt3rvql4jbauradujrre@gc5nbdhhixaf/
> Tested-by: Leonardo Costa <leonardo.costa@toradex.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
I feel it needs a compulsory review by Rob, but AFAICT this is
in line with the Nexus ideas.
Acked-by: Linus Walleij <linusw@kernel.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2026-09-16 16:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 11:41 [PATCH RFC 0/2] of: property: Make fw_devlink follow GPIO and PWM " Ernest Van Hoecke
2026-09-02 11:41 ` [PATCH RFC 1/2] of: property: fw_devlink: Follow GPIO " Ernest Van Hoecke
2026-09-02 12:30 ` Bartosz Golaszewski
2026-09-02 13:22 ` Ernest Van Hoecke
2026-09-02 16:55 ` Herve Codina
2026-09-03 9:57 ` Miquel Raynal
2026-09-03 11:51 ` Ernest Van Hoecke
2026-09-03 11:48 ` Ernest Van Hoecke
2026-09-03 9:18 ` Bartosz Golaszewski
2026-09-09 17:12 ` Uwe Kleine-König
2026-09-16 16:58 ` Linus Walleij [this message]
2026-09-02 11:41 ` [PATCH RFC 2/2] of: property: fw_devlink: Follow PWM " Ernest Van Hoecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD++jL=qaXxEr_sVnAF7BLUvp4ik+f8Zsg2sKY6n0=DwWqEYYw@mail.gmail.com' \
--to=linusw@kernel.org \
--cc=Frank.li@oss.nxp.com \
--cc=bmasney@redhat.com \
--cc=brgl@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ernest.vanhoecke@toradex.com \
--cc=ernestvanhoecke@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=herve.codina@bootlin.com \
--cc=kernel@pengutronix.de \
--cc=kieran.bingham@ideasonboard.com \
--cc=leonardo.costa@toradex.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=robh@kernel.org \
--cc=saravanak@kernel.org \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®