From: Bjorn Helgaas <bhelgaas@google.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Dave Jones <davej@redhat.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
x86@kernel.org, linux-pci@vger.kernel.org
Subject: Re: Add Dell Studio 1557 to pci=nocrs blacklist
Date: Wed, 11 Jan 2012 09:07:55 -0700 [thread overview]
Message-ID: <CAErSpo7tvCz4Bi6TF2Khi9aY7wHyWL9Fu2dSD5v8zuOLYmL6oA@mail.gmail.com> (raw)
In-Reply-To: <20120104183712.GB14966@elte.hu>
On Wed, Jan 4, 2012 at 11:37 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Dave Jones <davej@redhat.com> wrote:
>
>> The Dell Studio 1557 also doesn't suspend correctly when CRS is enabled.
>> Details at https://bugzilla.redhat.com/show_bug.cgi?id=769657
>>
>> Reported-by: Gregory S. Hoerner <ghoerner@transcendingthought.com>
>> Signed-off-by: Dave Jones <davej@redhat.com>
>>
>> --- linux-3.1.noarch/arch/x86/pci/acpi.c~ 2012-01-04 11:19:36.783664477 -0500
>> +++ linux-3.1.noarch/arch/x86/pci/acpi.c 2012-01-04 11:23:42.403666272 -0500
>> @@ -75,6 +75,16 @@ static const struct dmi_system_id pci_us
>> /* https://bugzilla.redhat.com/show_bug.cgi?id=769657 */
>> {
>> .callback = set_nouse_crs,
>> + .ident = "Dell Studio 1557",
>> + .matches = {
>> + DMI_MATCH(DMI_BOARD_VENDOR, "Dell Inc."),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "Studio 1557");
>> + DMI_MATCH(DMI_BIOS_VERSION, "A09"),
>
> Btw., should we perhaps match on all things 'Studio*'? For these
> two systems i'm sure there's 20 other models we have not covered
> yet ...
+linux-pci
I think we should hold off on merging this patch upstream. We don't
understand the root cause yet, and I haven't seen any evidence that
setting "pci=nocrs" actually makes a difference in PCI resource
allocation (https://bugzilla.redhat.com/show_bug.cgi?id=769657#c27)
Bjorn
prev parent reply other threads:[~2012-01-11 16:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 19:37 Dell Studio 1536 needs pci=nocrs to boot Dave Jones
2012-01-01 14:53 ` Ingo Molnar
2012-01-03 17:30 ` Jesse Barnes
2012-01-03 17:55 ` Bjorn Helgaas
2012-01-03 18:00 ` Dave Jones
2012-01-06 17:32 ` Bjorn Helgaas
2012-01-06 17:57 ` Dave Jones
2012-01-06 20:10 ` Jesse Barnes
2012-01-04 16:33 ` Add Dell Studio 1557 to pci=nocrs blacklist Dave Jones
2012-01-04 17:08 ` Jesse Barnes
2012-01-04 18:37 ` Ingo Molnar
2012-01-11 16:07 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAErSpo7tvCz4Bi6TF2Khi9aY7wHyWL9Fu2dSD5v8zuOLYmL6oA@mail.gmail.com \
--to=bhelgaas@google.com \
--cc=davej@redhat.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®