From: Aaron Kling <webgeek1234@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Weidong Wang <wangweidong.a@awinic.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
Val Packett <val@packett.cool>
Subject: Re: [PATCH 6/6] ASoC: codecs: aw88166: make volume control usable
Date: Fri, 25 Sep 2026 11:05:42 -0500 [thread overview]
Message-ID: <CALHNRZ-ofi9J6SZpKih5pogtH4aL_HDy3WmUQJ=w_nVd=YskTw@mail.gmail.com> (raw)
In-Reply-To: <721467a7-6b7e-4234-8321-660eb43f1f9c@sirena.org.uk>
On Fri, Sep 25, 2026 at 9:18 AM Mark Brown <broonie@kernel.org> wrote:
>
> On Fri, Sep 25, 2026 at 02:47:34AM -0500, Aaron Kling via B4 Relay wrote:
> > From: Aaron Kling <webgeek1234@gmail.com>
> >
> > - Invert the value to match userspace expectations (in the hardware,
> > positive numbers represent negative dB attenuation)
>
> That's a very bad compatibility break, if anyone has a profile saved
> they might get excessively loud volume from their existing configuration
> which could be distressing. It might be better to rename the control.
Mmm. At the risk of sounding like a broken record, is this any
different from the accepted aw88261 change? I wouldn't be specifically
opposed to a new control as my use case, Android, is very tightly
controlled and I can just update the audio config I ship. But more
standard Linux use cases that rely on a standardize control name would
be stuck with a non-standard inverted control forever.
Aaron
next prev parent reply other threads:[~2026-09-25 16:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 7:47 [PATCH 0/6] ASoC: codecs: aw88166: fixes and cleanup Aaron Kling via B4 Relay
2026-09-25 7:47 ` [PATCH 1/6] ASoC: codecs: aw88166: support changing sample rate and bit width Aaron Kling via B4 Relay
2026-09-25 14:00 ` Mark Brown
2026-09-25 15:56 ` Aaron Kling
2026-09-25 7:47 ` [PATCH 2/6] ASoC: codecs: aw88166: add TDM support Aaron Kling via B4 Relay
2026-09-25 7:47 ` [PATCH 3/6] ASoC: codecs: aw88166: reduce log spam Aaron Kling via B4 Relay
2026-09-25 7:47 ` [PATCH 4/6] ASoC: codecs: aw88166: remove fade in/out on start/stop Aaron Kling via B4 Relay
2026-09-25 14:11 ` Mark Brown
2026-09-25 15:59 ` Aaron Kling
2026-09-25 16:27 ` Mark Brown
2026-09-25 7:47 ` [PATCH 5/6] ASoC: codecs: aw88166: remove async start Aaron Kling via B4 Relay
2026-09-25 14:12 ` Mark Brown
2026-09-25 15:44 ` Aaron Kling
2026-09-25 16:06 ` Mark Brown
2026-09-25 16:16 ` Aaron Kling
2026-09-25 16:27 ` Mark Brown
2026-09-25 14:35 ` Cezary Rojewski
2026-09-25 15:42 ` Aaron Kling
2026-09-25 7:47 ` [PATCH 6/6] ASoC: codecs: aw88166: make volume control usable Aaron Kling via B4 Relay
2026-09-25 14:18 ` Mark Brown
2026-09-25 16:05 ` Aaron Kling [this message]
2026-09-25 16:18 ` Mark Brown
2026-09-25 16:25 ` Aaron Kling
2026-09-25 16:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALHNRZ-ofi9J6SZpKih5pogtH4aL_HDy3WmUQJ=w_nVd=YskTw@mail.gmail.com' \
--to=webgeek1234@gmail.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=val@packett.cool \
--cc=wangweidong.a@awinic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®