From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpbgsg2.qq.com (smtpbgsg2.qq.com [54.254.200.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9EAD422E37 for ; Tue, 22 Sep 2026 09:28:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.254.200.128 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790069339; cv=none; b=t7jhZ0rgnexwZT4e99SGahlpe2GDgSf9qsVS8fgT0LaBGMRBkcheBrH/6vXpz1Lg+Ra3cKZ7EnyXhsTm308UtyWDoZowJG4RfL6bVCMzCNbzeZvF8BHjl+jZmbCd6U47kD8vLzma/l7DiuK2TwBO9uBf0oIdHzDRlHl5a+hQAYk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790069339; c=relaxed/simple; bh=Q9gZjzEG8eqqtIXa1GCIg+oajKTGvuL2w+lld+u2M7w=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=juLbNBHVPf/zdPBozYAFJT+GiFPRoIADzEeuX9UNrfsuevn9b0ElATDyMSfAV+3Uv0HUeYxiIVCgXn8CYZNYb7q84heQcAFH6gMd3NtTlcmP6J0/vBYNCFPs0Fca+wsbVQ2+uihCjhJ9OBY9m0yKBuh4OoxA5iCRXPFKwZtSdok= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com; spf=none smtp.mailfrom=linux.spacemit.com; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b=yF1dkCxc; arc=none smtp.client-ip=54.254.200.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b="yF1dkCxc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.spacemit.com; s=mxsw2412; t=1790069116; bh=MqF3JT5Ag+/84VYxDV0JRl7knayiQkoPpeM2DvkLl/0=; h=Mime-Version:Date:Message-Id:Subject:From:To; b=yF1dkCxcmEM+uf2mx/nkBm1nIE85t0VniLdhcXqvPs9NDNv6IUVQQfbvRMjhfwNUN F77q4rNEuK/ApEUW8mUa75Vb9A7XSL2JW5tstv4gt4LFHlKsFBsEWESt/8nMgdnXCj foRNl0ValeXXn1fnSYAwlAYsK+eexLPeRIc/XNuw= X-QQ-mid: esmtpgz10t1790069108teb6a8f46 X-QQ-Originating-IP: X3aDg93GYWSWkmWKw2TeisR1sv3OIpjcWXfaT9hhycM= Received: from = ( [120.237.158.181]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 22 Sep 2026 17:25:05 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 18293615287119513376 EX-QQ-RecipientCnt: 23 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: multipart/signed; boundary=c50080b08dfc874b0cb25ecf11d489b0d1e616c2128732cb9c89443b278c; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Tue, 22 Sep 2026 17:25:03 +0800 Message-Id: Cc: "Anirudh Srinivasan" , "Aurelien Jarno" , "Jennifer Berringer" , , , , , , "Troy Mitchell" Subject: Re: [PATCH v6 2/2] scsi: ufs: spacemit: k3: Add UFS Host Controller driver From: "Troy Mitchell" To: "Yixun Lan" , "Alim Akhtar" , "Avri Altman" , "Bart Van Assche" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "James E.J. Bottomley" , "Philipp Zabel" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Alexandre Ghiti" , "Martin K. Petersen" Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.21.0-reader-ipc2 References: <20260921-08-k3-ufs-support-v6-0-3479768a2299@kernel.org> <20260921-08-k3-ufs-support-v6-2-3479768a2299@kernel.org> In-Reply-To: <20260921-08-k3-ufs-support-v6-2-3479768a2299@kernel.org> X-QQ-SENDSIZE: 520 Feedback-ID: esmtpgz:linux.spacemit.com:qybglogicsvrgz:qybglogicsvrgz3a-0 X-QQ-XMAILINFO: NuVTqMOgygVl/uH81H+rVPO7vXO6xh+Apb8/ViQcPw/mkBtiIQd1SNCZ gV3uU/ypbb3edu1s3/5peU+5QsbkRZSYtwyiDwn2QiVchGqQAlTRHehuD7yYQXIVYp/Kl3z Mrx8SWZZrAi+qQcuPbtg05BeprJtJWKt7HDcS930sdhtvcd674pkWpJxZ5jS89kdQPT/gSt KGZX4yP6hXPSR+nxCUegByxf07SZkBQECclubyM4JEYJmecQ20LrAVqcLPU+FkQ1P7HAU4d /IKT2vLybwwSPswWamH7eSdFVve9cquIiH27jD/Cq8Y3e2+gAwnsnYw9Ru3BT+gYh62fYwt XDXGx/C+FsD1smTdKKY+wYV8VJunhxLlvV5nzoAQp9zcUSrj1Q/oPbU9iNo4lmkJ0s9CzGC C9NBCy3EBdwMjumbKLCTYsyEJKFTQf4T9/23IvVz2yTksf9pTTNr+WLiZ698kdtzCTDibde +Q4jhX5vmvq2KsEk85aclslrCw2Kack4j1PJt55AKGOkwlMvD9P5KusBkLmQ5u35zIZxaRr R286ODEl3voJxA8nLZww4i5klTy8YumkZzdyQCpvwaKBxaEepBWqB4Bag6QjYfCQn4lrNgi luB3MeeMu9WMYRWePBOTBHgBO7WbzImIzqwE1/OQF7NmDQah/vLan1AyKx6i//2zCICyW25 DoSNhzFkn3L//u+Bo26s/+DnKRkJcqzftSgpVVw2MfskUEJEWA1F1Nr9edfUzUZrZppJR5Z X6d01RPjVFrXcmGjNcoF2EwUtqDsSKo4qxE2bWSLRqJIgtKyDQnn6xN7KsyU6sAgkyObfuC 9bLgdxJiI+nWdVV/aPbmQefURgBW/RPFEVI8TkCwRTHrwnNDH92oG2Vq97JKpF0mGs56aHu sVjiAUetKomJ7zf4EE9p80UxPu+zaDfT7W5qgdu1NhhlHFBQJ95udvvj9hZvQQYqJpJ9cRP V6TqR4CyJ0kYq7+242PxoSeCcoMZxMykjlyhG/QYTpLhvlr88vinCoCp6F94HVFHep4fZ7H uDkTJycLl+t0hYRIGjg8RHO70iBiNIcmiij0H+JDAMQFdMYQxPthEzgDzju3ddZuwr4VAq4 5hhOSoqTN0HXJVdzpAF9tCeMd+08jwwuQ== X-QQ-XMRINFO: NI4Ajvh11aEjEMj13RCX7UuhPEoou2bs1g== X-QQ-RECHKSPAM: 0 --c50080b08dfc874b0cb25ecf11d489b0d1e616c2128732cb9c89443b278c Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Mon Sep 21, 2026 at 8:36 PM +08, Yixun Lan wrote: > [...] > > +static int ufs_spacemit_link_startup_pre_change(struct ufs_hba *hba) > +{ > + u32 value, sys1clk_1us; > + int err; > + > + err =3D ufs_spacemit_mphy_init(hba); > + if (err < 0) > + return err; > + > + err =3D ufs_spacemit_uniprov1p6_init(hba); > + if (err < 0) > + return err; > + Should this be `if (err)`? The call chain is: ufs_spacemit_uniprov1p6_init() -> ufs_spacemit_dme_set() -> ufshcd_dme_set() -> ufshcd_dme_set_attr() ufshcd_dme_set_attr() returns 0 on success and non-zero on failure, including positive UIC error codes. The current check misses those. Also, ufshcd_link_startup() ignores the PRE_CHANGE return value in this series' base, so returning an error here alone will not abort startup. > [...] > > +static int ufs_spacemit_apply_dev_quirks(struct ufs_hba *hba) > +{ > [...] > + err =3D ufs_spacemit_dme_set(hba, setup_attrs, ARRAY_SIZE(setup_attrs))= ; > + if (err < 0) > + return err; The same `if (err)` check is needed here for positive DME errors. > + > + return ufs_spacemit_wait_mphy_pll_lock(hba); > +} > + > [...] > > +static int ufs_spacemit_init(struct ufs_hba *hba) > +{ > [...] > + hba->caps |=3D UFSHCD_CAP_RPM_AUTOSUSPEND; > + > + return 0; > +} > + --=20 Troy Mitchell --c50080b08dfc874b0cb25ecf11d489b0d1e616c2128732cb9c89443b278c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEABYKACsWIQSL4Ay2cExaPXAQcU2YCe+A+TM0LwUCarJJbw0caUB0cm95LXku b3JnAAoJEJgJ74D5MzQvJ1gA/22uBA65WxxSQ+7npmcBkm5HKq8LkzpjDIOXS2jr brfJAQCOnLcMv4qGA1z+Oh4psRDSDEz61/5c2j+bZNBXkVZIDw== =l/Ay -----END PGP SIGNATURE----- --c50080b08dfc874b0cb25ecf11d489b0d1e616c2128732cb9c89443b278c--