From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy2-f27.google.com (mail-dy2-f27.google.com [74.125.229.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07FFF2D5412 for ; Thu, 24 Sep 2026 01:44:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.229.27 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790214265; cv=none; b=Jg7PEhU2vfzr5SxD3KLwo2HcBDZX/5E8wjW+R9hOJ1wqGZhHQqqB/V84oBlj/CDp4h9sXsVv46/u5yC143Kth4PJCOiLUsFi28MS5vgb8xLoGUX/tpoMYCqauMdvBU5QYDtxfOvsyBWPa5PYSihmosijVWt3byXynyhQIJK96bo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790214265; c=relaxed/simple; bh=TrlkWhLUYKYqpfyhjFtzdNcVUv+jgrxruyGC3ITjANk=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=uvYze0emT8+eN5GmzfuF5SCAPmP+LB3NrrdKnaufE5uxL5gb8Ni+MX+pl2NFzEF3I3p0gCOgDB3q385X83SulYCJdcp4n96Jvz86OwmWF1f4JLyWHztl9MxEaQc6rhhRqyf0geCvhp6KnAY794TuV+5yyG82lfO+MnPTMSBwRCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nexthop.ai; spf=pass smtp.mailfrom=nexthop.ai; dkim=pass (2048-bit key) header.d=nexthop.ai header.i=@nexthop.ai header.b=LZTm7zvC; arc=none smtp.client-ip=74.125.229.27 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nexthop.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nexthop.ai Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nexthop.ai header.i=@nexthop.ai header.b="LZTm7zvC" Received: by mail-dy2-f27.google.com with SMTP id 5a478bee46e88-33e62211987so1766278eec.2 for ; Wed, 23 Sep 2026 18:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexthop.ai; s=google; t=1790214263; x=1790819063; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=WltkXwT4z+eov17Qfylxi2pHojB612CmH3f4OFtUAec=; b=LZTm7zvC+LVqyxsBfBCSFXDg3ILhm0U0VQXEzsfIRqvz/+8UcGAwtrn43Ylkqf5uVK Lhh0UyAbwkR2OdPSK9OoXeTSlJwi73XWd86Cpo1cNhPwUNxMvUwfMdytl0CblXGCPkyR L1f2zFTTlwgg/R2YpCKo+MxJZRGW9iM4Xhw/EbafG6h0USWaowCToS0V3HfnmsatEFpV PNdHB9O8OkgTke5taGtTlNDlWLOvRoj0LoVSo3kDpl/SZY3YGchIUYSXjLCTnR01Sis/ m47Ka232wd0vgCVs/k/3gLXA8sNVt0wyW/PUma601Ckuijlxcx+dxBp0XXy0T+1rU8sV NxtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790214263; x=1790819063; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WltkXwT4z+eov17Qfylxi2pHojB612CmH3f4OFtUAec=; b=I8mb+dccMkXOR9ljuIkpUYsZQ82WBRJ5oJGo4KXFnyG03lZI4JZ5Sn6lyROCKDSznn jsP3Dci/kFRQEjR2TGXGA61TdG7fa3KJtxoteetUXPHXE93yt4Rg4bw44Ycn6d77tgjh A8D16v9rKTYuqW4LQe4RiauueOqji3bz4CbeaRMDVxMxzOsxcLPPCj9SUG7GBO9VuElF djkG27mhIzrpo1PukkQfbApCZKazXYulkgCnIgy7OvprrdxWEJOmHI++WcKedyhhfshW NoIb6i2xkXBkQeEl5OQLEPYUP4hPpzcninSx+vbNf+Jv3zzdwbMHJZoMyDenqrnZP9KB oIbg== X-Forwarded-Encrypted: i=1; AKwUvByHAA4aaufFGSBVY/62eXgR2o2in5Q/k337a+Gqfjj8kStIvn6H7EceBjrlPf+s10NDUiCGugdqpJNe0y0=@vger.kernel.org X-Gm-Message-State: AFuF++nwtb42g3G0ZJEexe7bW5TlciS1z33pNpveGoVGGar3mKW18bPy l3Vjf2AnKz0ePJFlcyyjnBuYBLuCo55cJnHV9jXy3GoH4OPxRQlOS8W7aglaiYNjIaI= X-Gm-Gg: AYBFou3W5DT80KqubKsVntf/EWgTIv3f9iFvuP3tqg3DH96EPQtqQE0AAczKU5fDHad 5FoCGIzq6hp+1APn6yrSO8WTbz6SlfzLQYt8/gvizcYwTkiA08s6VERQhyGuC0X+9mRAyJ5If9A GFRmxxvCQ16CY9kJbgGgUwbqjT2ecs5UCEak7H41ui9cAbr68awnth7RXhHMlA22SqOegvt/eaO CuzjZ2ZevONsyaRMgwCWHbGZ4pR7Kdkr7zW6q9U5/MG7NDw7qgANNUcPKfaMvZ2OvpmwV1mRsd7 k9nKufUh6mhrA/ITjhwFy2NYuqX8WpVsk+phpwzrsUSgGNTti/H5UNCqRzlId8SyiHxXZDhhDHk 1Z1ehqDnM82Q3Vwxpt4BA+JoFoxd1zxK7iqRZDBQo9rVcMJi+4gFUScM+Nt6mdAooZNLPeX/Cx1 kBb/84r7LGi5W2zpA3upww/N6rh7VOvS22GBWW+grghYlmojINZLUPFdJqJj0kqK9yOCw438n0K GvUNldLDg== X-Received: by 2002:a05:7300:238b:b0:33e:451e:c8b2 with SMTP id 5a478bee46e88-34006f826a1mr891609eec.37.1790214262980; Wed, 23 Sep 2026 18:44:22 -0700 (PDT) Received: from localhost ([50.145.100.174]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33e939fdabcsm9920817eec.3.2026.09.23.18.44.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Sep 2026 18:44:22 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 23 Sep 2026 18:44:21 -0700 Message-Id: Subject: Re: [PATCH v5 1/3] i2c: xiic: preserve PEC byte length in SMBus block read setup From: "Abdurrahman Hussain" To: "Andi Shyti" , "Abdurrahman Hussain" Cc: "Michal Simek" , "Wolfram Sang" , "Raviteja Narayanam" , "Wolfram Sang" , "Manikanta Guntupalli" , "Shubhrajyoti Datta" , , , , X-Mailer: aerc 0.22.0 References: <20260921-i2c-xiic-v5-0-2fca81e810ea@nexthop.ai> <20260921-i2c-xiic-v5-1-2fca81e810ea@nexthop.ai> In-Reply-To: On Wed Sep 23, 2026 at 11:04 AM PDT, Andi Shyti wrote: >> + /* >> + * Undo the setup-time padding before rx_msg is cleared, >> + * so the PEC check sees the right byte. >> + */ >> + if (i2c->rx_msg && i2c->smbus_actual_len) >> + i2c->rx_msg->len =3D i2c->smbus_actual_len; > > I think this restore needs to go also in xiic_recv_atomic. > > Andi > Yes. I2C_M_RECV_LEN forces standard mode for the whole transfer, so an atomic block read hits the same padded branch and then completes in xiic_recv_atomic() without the trim. v6 pulls the trim into a xiic_smbus_trim_len() helper and calls it from both sites that clear rx_msg. Patches 2 and 3 unchanged. Abdurrahman