mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aditya Garg <aditya.garg@linux.dev>
To: Thorsten Leemhuis <regressions@leemhuis.info>,
	Lukas Wunner <lukas@wunner.de>,
	Alex Deucher <alexdeucher@gmail.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	"Perlow, Jason" <jperlow@gmail.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	regressions@lists.linux.dev
Subject: Re: [REGRESSION] PCI/AER: MacBookPro16,1 powers off ~20 s after boot
Date: Wed, 07 Oct 2026 16:09:43 +0530	[thread overview]
Message-ID: <F405BE2D-9C00-4E72-B5C4-BA2FD5348E84@linux.dev> (raw)
In-Reply-To: <8925d288-a496-4fcc-9545-7647dfc9ea63@leemhuis.info>



On 7 October 2026 3:59:17 pm IST, Thorsten Leemhuis <regressions@leemhuis.info> wrote:
>On 10/6/26 23:19, Lukas Wunner wrote:
>> On Tue, Oct 06, 2026 at 12:37:18PM -0400, Alex Deucher wrote:
>>> On Mon, Oct 5, 2026 at 7:19 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
>>>> Alex reported something similar at
>>>> https://bugzilla.kernel.org/show_bug.cgi?id=222095.
>>>
>>> Lukas' patches fixes some boards, but unfortunately, I'm still seeing
>>> failures on others.  Reverting the patch fixes those failures.  I've
>>> updated the ticket.
>> 
>> I've added an analysis of the dmesg output as well as a patch.
>> It looks like the BIOS is raising a false alarm in that it signals
>> a Fatal Error even though the Uncorrectable Error Status register is
>> blank.  The patch causes such events to be reported, but otherwise
>> ignored (i.e. no recovery is attempted for a false alarm).
>> 
>> Newly enabled functionality like Advisory Non-Fatal Errors causes
>> BIOS code paths to be exercised which likely haven't been tested
>> by firmware validation folks, hence the fallout.  However I believe
>> ultimately we *want* to see those errors being reported because they
>> may point to BIOS issues which flew under the radar so far.
>Well, not disagreeing, but given that we have two regression reports
>(one speaking about multiple machines being broken) and we are close to
>-rc7 I wonder:
>
>Is this something we should quickly revert or disable for now and retry
>again later? Maybe multiple mainline devel cycles if needed?

I think the patch needs vigorous testing on a variety of hardware before being mainlined. For now a revert seems to be a good solution to ensure we don't have a broken 7.3 for multiple devices. Also, we are close a new LTS kernel, it's really not a good thing to have a broken one.

      reply	other threads:[~2026-10-07 10:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 17:53 Perlow, Jason
2026-10-05 18:37 ` Perlow, Jason
2026-10-05 23:19 ` Bjorn Helgaas
2026-10-06  0:17   ` Perlow, Jason
2026-10-06  2:56     ` Lukas Wunner
2026-10-06  8:31       ` Aditya Garg
2026-10-06  9:44         ` Lukas Wunner
2026-10-06 15:00           ` Perlow, Jason
2026-10-07  5:42           ` Aditya Garg
2026-10-06 16:37   ` Alex Deucher
2026-10-06 18:45     ` Aditya Garg
2026-10-06 21:19     ` Lukas Wunner
2026-10-07 10:29       ` Thorsten Leemhuis
2026-10-07 10:39         ` Aditya Garg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F405BE2D-9C00-4E72-B5C4-BA2FD5348E84@linux.dev \
    --to=aditya.garg@linux.dev \
    --cc=alexdeucher@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=jperlow@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®