mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kristen Carlson Accardi <kristen.c.accardi@intel.com>,
	Jeff Garzik <jeff@garzik.org>, Tejun Heo <htejun@gmail.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] Re: 2.6.23-rc2-mm2: sata disk going slow
Date: Sat, 11 Aug 2007 23:04:17 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0708112256150.18054@blonde.wat.veritas.com> (raw)
In-Reply-To: <20070809224254.11f42716.akpm@linux-foundation.org>

Why is the G5 so slow with 2.6.23-rc2-mm2?  hdparm -t shows 1.8MB/sec
instead of 58MB/sec.  alpm-increase-number-of-allowable-device-flags.patch
(raising ATA_DFLAG_CFG_MASK) turns out to be the guilty party: though the
problem doesn't appear until the next patch, which adds ATA_DFLAG_IPM as
the same bit as ATA_DFLAG_PIO.  Here's a hotfix against top of -rc2-mm2.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
---

 include/linux/libata.h |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- 2.6.23-rc2-mm2/include/linux/libata.h	2007-08-10 12:14:36.000000000 +0100
+++ linux/include/linux/libata.h	2007-08-11 20:21:59.000000000 +0100
@@ -143,9 +143,9 @@ enum {
 	ATA_DFLAG_IPM		= (1 << 8), /* device supports IPM */
 	ATA_DFLAG_CFG_MASK	= (1 << 12) - 1,
 
-	ATA_DFLAG_PIO		= (1 << 8), /* device limited to PIO mode */
-	ATA_DFLAG_NCQ_OFF	= (1 << 9), /* device limited to non-NCQ mode */
-	ATA_DFLAG_SPUNDOWN	= (1 << 10), /* XXX: for spindown_compat */
+	ATA_DFLAG_PIO		= (1 << 12), /* device limited to PIO mode */
+	ATA_DFLAG_NCQ_OFF	= (1 << 13), /* device limited to non-NCQ mode */
+	ATA_DFLAG_SPUNDOWN	= (1 << 14), /* XXX: for spindown_compat */
 	ATA_DFLAG_INIT_MASK	= (1 << 16) - 1,
 
 	ATA_DFLAG_DETACH	= (1 << 16),

  parent reply	other threads:[~2007-08-11 22:05 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-10  5:42 2.6.23-rc2-mm2 Andrew Morton
2007-08-10  7:59 ` 2.6.23-rc2-mm2: possible irq lock inversion dependency detected Mariusz Kozlowski
2007-08-10  8:18 ` 2.6.23-rc2-mm2 Dave Young
2007-08-10  8:32   ` 2.6.23-rc2-mm2 Andrew Morton
2007-08-10  8:37     ` 2.6.23-rc2-mm2 Dave Young
2007-08-10  9:52       ` 2.6.23-rc2-mm2 Dave Young
2007-08-10 11:19         ` 2.6.23-rc2-mm2 Gabriel C
2007-08-10 20:22           ` 2.6.23-rc2-mm2 -- conntrack divide error Jiri Slaby
2007-08-10  9:23 ` 2.6.23-rc2-mm2 Aurelien Jarno
2007-08-10 16:40   ` 2.6.23-rc2-mm2 Valdis.Kletnieks
2007-08-10 16:59     ` 2.6.23-rc2-mm2 Adrian Bunk
2007-08-10 17:21       ` 2.6.23-rc2-mm2 Valdis.Kletnieks
2007-08-10 17:28         ` 2.6.23-rc2-mm2 Adrian Bunk
2007-08-10 10:23 ` 2.6.23-rc2-mm2 Gabriel C
2007-08-10 11:03   ` 2.6.23-rc2-mm2 Gabriel C
2007-08-10 16:05     ` 2.6.23-rc2-mm2 Eric W. Biederman
2007-08-10 12:35   ` 2.6.23-rc2-mm2 Gabriel C
2007-08-10 16:38     ` 2.6.23-rc2-mm2 Andrew Morton
2007-08-12 15:21       ` 2.6.23-rc2-mm2 Gabriel C
2007-08-10 12:37   ` 2.6.23-rc2-mm2 Gabriel C
2007-08-10 13:20     ` [PATCH -mm] Fix some section mismatch warnings Gabriel C
2007-08-14 20:50       ` Andrew Morton
2007-08-10 19:04     ` Section mismatch warnings ( Re: 2.6.23-rc2-mm2 ) Gabriel C
2007-08-10 19:32       ` Andrew Morton
2007-08-10 12:42   ` 2.6.23-rc2-mm2 Gabriel C
2007-08-11 20:58     ` [linux-usb-devel] 2.6.23-rc2-mm2 David Brownell
2007-08-12 10:15       ` Gabriel C
2007-08-10 16:03   ` 2.6.23-rc2-mm2 Eric W. Biederman
2007-08-10 14:38 ` [-mm patch] kernel/sysctl_check.c must #include <linux/string.h> Adrian Bunk
2007-08-10 21:32   ` Eric W. Biederman
2007-08-10 14:53 ` 2.6.23-rc2-mm2 Michal Piotrowski
2007-08-10 15:05   ` 2.6.23-rc2-mm2 Michal Piotrowski
2007-08-10 16:01     ` 2.6.23-rc2-mm2 Eric W. Biederman
2007-08-10 16:05       ` 2.6.23-rc2-mm2 Ingo Molnar
2007-08-10 17:10         ` 2.6.23-rc2-mm2 Andrew Morton
2007-08-10 17:12         ` 2.6.23-rc2-mm2 Eric W. Biederman
2007-08-21 10:41           ` 2.6.23-rc2-mm2 Ingo Molnar
2007-08-10 15:56 ` 2.6.23-rc2-mm2: drivers/s390/char/keyboard.c compile error Adrian Bunk
2007-08-10 16:39   ` Samuel Thibault
2007-08-10 16:16 ` 2.6.23-rc2-mm2 Michal Piotrowski
2007-08-10 16:37   ` 2.6.23-rc2-mm2 Gabriel C
2007-08-10 17:33     ` 2.6.23-rc2-mm2 Eric W. Biederman
2007-08-10 19:41       ` 2.6.23-rc2-mm2 Andrew Morton
2007-08-10 19:54         ` 2.6.23-rc2-mm2 Eric W. Biederman
2007-08-10 21:00         ` [PATCH 1/7] sysctl: Remove broken cdrom binary sysctls Eric W. Biederman
2007-08-10 21:01           ` [PATCH 2/7] sysctl: parport remove binary paths Eric W. Biederman
2007-08-10 21:03             ` [PATCH 3/7] sysctl: Simplify the pty sysctl logic Eric W. Biederman
2007-08-10 21:06               ` [PATCH 4/7] sysctl: remove broken netfilter binary sysctls Eric W. Biederman
2007-08-10 21:08                 ` [PATCH 5/7] sysctl: Cleanup the sched debug sysctl usage Eric W. Biederman
2007-08-10 21:09                   ` [PATCH 6/7] sysctl: Update sysctl_checks list of binary paths Eric W. Biederman
2007-08-10 21:10                     ` [PATCH 7/7] sysctl: Remove the cad_pid binary sysctl path Eric W. Biederman
2007-08-10 21:10           ` [PATCH 1/7] sysctl: Remove broken cdrom binary sysctls Alan Cox
2007-08-10 21:19         ` 2.6.23-rc2-mm2 Eric W. Biederman
2007-08-10 17:38     ` 2.6.23-rc2-mm2 Michal Piotrowski
2007-08-10 17:55 ` arch/i386/kernel/setup.c - compile error (Re: 2.6.23-rc2-mm2) Gabriel C
2007-08-10 18:44   ` Andrew Morton
2007-08-10 19:34     ` Gabriel C
2007-08-10 20:08 ` 2.6.23-rc2-mm2 Aurelien Jarno
2007-08-10 20:20   ` 2.6.23-rc2-mm2 Andrew Morton
2007-08-10 21:43     ` 2.6.23-rc2-mm2 John W. Linville
2007-08-11 22:04 ` Hugh Dickins [this message]
2007-08-13  5:29 ` 2.6.23-rc2-mm2 (libertas) Randy Dunlap
2007-08-14 21:23 ` [-mm patch] unexport ide_tune_dma Adrian Bunk
2007-08-14 21:23 ` [-mm patch] AFLAGS: fix the -g setting Adrian Bunk
2007-08-16 21:02   ` Andrew Morton
2007-08-16 22:16     ` Adrian Bunk
2007-08-16 22:30       ` Roland McGrath
2007-08-14 21:25 ` [-mm patch] remove fs/ext2/balloc.c:reserve_blocks() Adrian Bunk
2007-08-14 21:26 ` [-mm patch] unexport cap_inode_killpriv Adrian Bunk
2007-08-14 21:35   ` Serge E. Hallyn
2007-08-14 23:43     ` Adrian Bunk
2007-08-19 15:56 ` 2.6.23-rc2-mm2 richard kennedy
2007-08-21 23:36   ` 2.6.23-rc2-mm2 Andrew Morton
2007-08-23 15:54     ` 2.6.23-rc2-mm2 richard kennedy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0708112256150.18054@blonde.wat.veritas.com \
    --to=hugh@veritas.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=kristen.c.accardi@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®