mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Chanho Park <parkch98@gmail.com>
Cc: rafael@kernel.org, linux-kernel@vger.kernel.org,
	Chanho Park <chanho61.park@samsung.com>
Subject: Re: [PATCH] drivers core: export symbols for device hotplug
Date: Thu, 26 Nov 2020 18:21:33 +0100	[thread overview]
Message-ID: <X7/kHYpgmRZ6Lwhm@kroah.com> (raw)
In-Reply-To: <20201126150138.159896-1-chanho61.park@samsung.com>

On Fri, Nov 27, 2020 at 12:01:38AM +0900, Chanho Park wrote:
> To support module build for cpu hotplug driver on type-1 hypervisor
> such as drivers/xen/cpu_hotplug.c, we need to export below four symbols.
> 
> lock_device_hotplug / unlock_device_hotplug
> device_online / device_offline
> 
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> ---
>  drivers/base/core.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index d661ada1518f..1bfd0c54a778 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -1586,11 +1586,13 @@ void lock_device_hotplug(void)
>  {
>  	mutex_lock(&device_hotplug_lock);
>  }
> +EXPORT_SYMBOL_GPL(lock_device_hotplug);

Ick, really?  Anyway, where is the follow-on patch that uses this in a
module?  We need that in order to export these otherwise we will just
un-export them with no in-kernel users.

thanks,

greg k-h

      reply	other threads:[~2020-11-26 17:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26 15:01 Chanho Park
2020-11-26 17:21 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X7/kHYpgmRZ6Lwhm@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=chanho61.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=parkch98@gmail.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®