From: Christoph Hellwig <hch@infradead.org>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
Arnaud Ebalard <arno@natisbad.org>,
Srujana Challa <schalla@marvell.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: octeontx2 - Use dma_alloc_coherent() instead of kzalloc/dma_map_single()
Date: Mon, 11 Oct 2021 09:38:33 +0100 [thread overview]
Message-ID: <YWP4CbI7yENsP8/f@infradead.org> (raw)
In-Reply-To: <20211010160010.435-1-caihuoqing@baidu.com>
On Mon, Oct 11, 2021 at 12:00:04AM +0800, Cai Huoqing wrote:
> Replacing kzalloc/kfree/dma_map_single/dma_unmap_single()
> with dma_alloc_coherent/dma_free_coherent() helps to reduce
> code size, and simplify the code, and coherent DMA will not
> clear the cache every time.
As just explained in another patch like this please qualify the
savings as we have actual results that shows the reverse of your claims.
prev parent reply other threads:[~2021-10-11 8:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-10 16:00 Cai Huoqing
2021-10-11 8:38 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWP4CbI7yENsP8/f@infradead.org \
--to=hch@infradead.org \
--cc=arno@natisbad.org \
--cc=bbrezillon@kernel.org \
--cc=caihuoqing@baidu.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schalla@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®