From: Sean Christopherson <seanjc@google.com>
To: Like Xu <like.xu.linux@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Jim Mattson <jmattson@google.com>,
Wanpeng Li <wanpengli@tencent.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Joerg Roedel <joro@8bytes.org>,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] KVM: x86: Make the module parameter of vPMU more common
Date: Wed, 12 Jan 2022 16:20:25 +0000 [thread overview]
Message-ID: <Yd7/yUFQr3pbqVCi@google.com> (raw)
In-Reply-To: <20220112040116.23937-1-likexu@tencent.com>
On Wed, Jan 12, 2022, Like Xu wrote:
> ---
> v1 -> v2 Changelog:
> - prefer we keep "pmu" for the module param; (Sean)
...
> +/* Enable/disable PMU virtualization */
> +bool __read_mostly pmu = true;
> +EXPORT_SYMBOL_GPL(pmu);
> +module_param(pmu, bool, 0444);
Sorry, I should have been more explicit. What I meant was this:
/* Enable/disable PMU virtualization */
bool __read_mostly enable_pmu = true;
module_param_named(pmu, enable_pmu, bool, 0444);
That way KVM can use "enable_pmu" for all its checks, but the user only needs to
type "pmu=?" when manipulating the module param.
prev parent reply other threads:[~2022-01-12 16:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 4:01 Like Xu
2022-01-12 16:20 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd7/yUFQr3pbqVCi@google.com \
--to=seanjc@google.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®