From: Len Brown <lenb@kernel.org>
To: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>
Subject: [PATCH 4/7] tools/power turbostat: fix parameter passing for forked command
Date: Sat, 15 Aug 2015 23:25:45 -0400 [thread overview]
Message-ID: <a01e72fbc41e322ed229465de8b595a7e3ec6549.1439695194.git.len.brown@intel.com> (raw)
In-Reply-To: <1439695548-21174-1-git-send-email-lenb@kernel.org>
In-Reply-To: <75fd7ffa7fab91c2c3234bd3e465ba4f366733f4.1439695194.git.len.brown@intel.com>
From: Len Brown <len.brown@intel.com>
turbostat supports forked command when sampling cpu state. However,
the forked command is not allowed to be executed with options, otherwise
turbostat might regard these options as invalid turbostat options.
For example:
./turbostat stress -c 4 -t 10
./turbostat: unrecognized option '-t'
Reported-by: Chen Yu <yu.c.chen@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
---
tools/power/x86/turbostat/turbostat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
index 5a793be..915eb28 100644
--- a/tools/power/x86/turbostat/turbostat.c
+++ b/tools/power/x86/turbostat/turbostat.c
@@ -3118,7 +3118,7 @@ void cmdline(int argc, char **argv)
progname = argv[0];
- while ((opt = getopt_long_only(argc, argv, "C:c:Ddhi:JM:m:PpST:v",
+ while ((opt = getopt_long_only(argc, argv, "+C:c:Ddhi:JM:m:PpST:v",
long_options, &option_index)) != -1) {
switch (opt) {
case 'C':
--
2.5.0.330.g130be8e
next prev parent reply other threads:[~2015-08-16 3:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-16 3:25 intel_idle, turbostat patches queued for upstream Len Brown
2015-08-16 3:25 ` [PATCH 1/7] tools/power turbostat: update turbostat(8) Len Brown
2015-08-16 3:25 ` [PATCH 2/7] tools/power turbostat: cpu0 is no longer hard-coded, so update output Len Brown
2015-08-16 3:25 ` [PATCH 3/7] tools/power turbostat: dump CONFIG_TDP Len Brown
2015-08-16 3:25 ` Len Brown [this message]
2015-08-16 3:25 ` [PATCH 5/7] tools/power turbostat: fix typo on DRAM column in Joules-mode Len Brown
2015-08-16 3:25 ` [PATCH 6/7] intel_idle: allow idle states to be freeze-mode specific Len Brown
2015-08-16 3:25 ` [PATCH 7/7] intel_idle: Skylake Client Support Len Brown
2015-08-24 21:39 ` intel_idle, turbostat patches queued for upstream Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a01e72fbc41e322ed229465de8b595a7e3ec6549.1439695194.git.len.brown@intel.com \
--to=lenb@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®