mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rodolfo Giometti <giometti@enneenne.com>
To: David Woodhouse <dwmw2@infradead.org>,
	Richard Cochran <richardcochran@gmail.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	John Stultz <jstultz@google.com>,
	Thomas Gleixner <tglx@kernel.org>,
	Stephen Boyd <sboyd@kernel.org>,
	Miroslav Lichvar <mlichvar@redhat.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	Alexander Gordeev <agordeev@linux.ibm.com>
Subject: Re: [PATCH v4 2/4] pps: Drop the !NO_HZ_COMMON dependency from NTP_PPS
Date: Tue, 29 Sep 2026 13:48:29 +0200	[thread overview]
Message-ID: <a174957f-f414-42c9-80f9-5d60f448e044@enneenne.com> (raw)
In-Reply-To: <7f98cef0918465e8d6bc9e76d26afb8b12471773.camel@infradead.org>

Hi David,

On 29/09/2026 11:32, David Woodhouse wrote:
> When second_overflow() is delivering skew, timekeeping_max_deferment()
> should trigger a wakeup at the end of the second to ensure that the
> skew gets recalculated — rather than leaving it active indefinitely.

Please put this fix in the series before 2/4, as for the tick_length
one.

> So the results at https://david.woodhou.se/ntptest-r64/tickless/ need
> to be redone, but you can take a look and shout if you want me to
> change what I'm capturing or how I'm doing it.

What you capture is fine for me: the adjtimex state (offset, jitter,
stabil, errcnt) plus the per-pulse phase are what I wanted to see.

Two questions for the rerun:

- wouldn't it be better to also have the tickful baseline with the same
   board, the same GPS and the same pulse period, so the numbers can be
   compared directly?

- since typical PPS sources deliver 1 Hz, don't you think it would be
   better to also do one run with the timepulse at 1 Hz?

Ciao,

Rodolfo

-- 
GNU/Linux Solutions                  e-mail: giometti@enneenne.com
Linux Device Driver                          giometti@linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming

  reply	other threads:[~2026-09-29 11:48 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-29 20:56 [PATCH v4 0/4] Add ntp_error to clock snapshot, enable NTP_PPS on tickless kernel David Woodhouse
2026-08-29 20:56 ` [PATCH v4 1/4] timekeeping: Apply extrapolated ntp_error to clock snapshots David Woodhouse
2026-08-29 20:57 ` [PATCH v4 2/4] pps: Drop the !NO_HZ_COMMON dependency from NTP_PPS David Woodhouse
2026-09-01 15:35   ` Rodolfo Giometti
2026-09-02  0:13     ` David Woodhouse
2026-09-28 13:37     ` David Woodhouse
2026-09-28 16:41       ` Rodolfo Giometti
2026-09-28 19:28         ` David Woodhouse
2026-09-29  6:33           ` Rodolfo Giometti
2026-09-29  9:32             ` David Woodhouse
2026-09-29 11:48               ` Rodolfo Giometti [this message]
2026-09-29 12:02                 ` David Woodhouse
2026-09-30  1:28                 ` David Woodhouse
2026-09-30 12:57                   ` Rodolfo Giometti
2026-09-30 10:37                 ` David Woodhouse
2026-09-30 12:57                   ` Rodolfo Giometti
2026-09-30 14:05                     ` David Woodhouse
2026-09-30 18:24                       ` David Woodhouse
2026-10-01  8:20                         ` Rodolfo Giometti
2026-10-01  9:08                           ` David Woodhouse
2026-08-29 20:57 ` [PATCH v4 3/4] pps: Always use ktime_get_snapshot_id() for pps_get_ts() David Woodhouse
2026-09-01 15:35   ` Rodolfo Giometti
2026-09-01 23:56     ` David Woodhouse
2026-09-26 20:38     ` David Woodhouse
2026-09-28  7:58       ` Rodolfo Giometti
2026-09-28 12:59         ` David Woodhouse
2026-09-28 16:41           ` Rodolfo Giometti
2026-10-01 13:14         ` Miroslav Lichvar
2026-10-01 15:38           ` David Woodhouse
2026-10-02  7:04           ` Rodolfo Giometti
2026-10-02  9:07             ` David Woodhouse
2026-10-02 12:29               ` David Woodhouse
2026-10-02 13:44                 ` David Woodhouse
2026-10-03 11:29                   ` David Woodhouse
2026-10-05  9:16                   ` Miroslav Lichvar
2026-08-29 20:57 ` [PATCH v4 4/4] [DO NOT MERGE] ptp: ptp_vmclock: Add simulated 1PPS support David Woodhouse
2026-09-01 15:35 ` [PATCH v4 0/4] Add ntp_error to clock snapshot, enable NTP_PPS on tickless kernel Rodolfo Giometti
2026-09-01 23:37   ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a174957f-f414-42c9-80f9-5d60f448e044@enneenne.com \
    --to=giometti@enneenne.com \
    --cc=agordeev@linux.ibm.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dwmw2@infradead.org \
    --cc=edumazet@google.com \
    --cc=jstultz@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlichvar@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=sboyd@kernel.org \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®