From: zhouxianrong <zhouxianrong@huawei.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<akpm@linux-foundation.org>, <rientjes@google.com>,
<hannes@cmpxchg.org>, <chris@chris-wilson.co.uk>,
<vdavydov.dev@gmail.com>, <mgorman@techsingularity.net>,
<joe@perches.com>, <shawn.lin@rock-chips.com>,
<iamjoonsoo.kim@lge.com>, <kuleshovmail@gmail.com>,
<zhouxiyu@huawei.com>, <zhangshiming5@huawei.com>,
<won.ho.park@huawei.com>, <tuxiaobing@huawei.com>
Subject: Re: [PATCH vmalloc] reduce purge_lock range and hold time of
Date: Tue, 18 Oct 2016 10:55:26 +0800 [thread overview]
Message-ID: <a33c5cd3-ce94-b333-af3d-d8fc2b0765e1@huawei.com> (raw)
In-Reply-To: <20161015165521.GB31568@infradead.org>
hey Hellwig:
cond_resched_lock is a good choice. i mixed the cond_resched_lock and batch to balance of
realtime and performance and resubmit this patch.
On 2016/10/16 0:55, Christoph Hellwig wrote:
> On Sat, Oct 15, 2016 at 10:12:48PM +0800, zhouxianrong@huawei.com wrote:
>> From: z00281421 <z00281421@notesmail.huawei.com>
>>
>> i think no need to place __free_vmap_area loop in purge_lock;
>> _free_vmap_area could be non-atomic operations with flushing tlb
>> but must be done after flush tlb. and the whole__free_vmap_area loops
>> also could be non-atomic operations. if so we could improve realtime
>> because the loop times sometimes is larg and spend a few time.
>
> Right, see the previous patch in reply to Joel that drops purge_lock
> entirely.
>
> Instead of your open coded batch counter you probably want to add
> a cond_resched_lock after the call to __free_vmap_area.
>
> .
>
next prev parent reply other threads:[~2016-10-18 2:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-15 14:12 zhouxianrong
2016-10-15 16:55 ` Christoph Hellwig
2016-10-18 2:55 ` zhouxianrong [this message]
2016-10-18 2:25 ` [PATCH vmalloc] reduce purge_lock range and hold time of vmap_area_lock zhouxianrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a33c5cd3-ce94-b333-af3d-d8fc2b0765e1@huawei.com \
--to=zhouxianrong@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=chris@chris-wilson.co.uk \
--cc=hannes@cmpxchg.org \
--cc=hch@infradead.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=rientjes@google.com \
--cc=shawn.lin@rock-chips.com \
--cc=tuxiaobing@huawei.com \
--cc=vdavydov.dev@gmail.com \
--cc=won.ho.park@huawei.com \
--cc=zhangshiming5@huawei.com \
--cc=zhouxiyu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®