mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Chen Ni <nichen@iscas.ac.cn>,
	linux-arm-msm@vger.kernel.org,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Francisco Munoz Ruiz <francisco.ruiz@oss.qualcomm.com>
Subject: Re: [PATCH] soc: qcom: llcc-qcom: Fix error check for devm_memremap()
Date: Tue, 19 May 2026 11:40:14 +0200	[thread overview]
Message-ID: <a979a727-1c59-4281-b9e9-2e5d582f14e7@web.de> (raw)
In-Reply-To: <20260519023841.1995542-1-nichen@iscas.ac.cn>

> The devm_memremap() function returns an error pointer on failure, not
> NULL. Fix the check to use IS_ERR() and return PTR_ERR() to correctly
> handle allocation failures.

Would a summary phrase like “Fix error handling in qcom_llcc_get_fw_config()”
be more appropriate?

Regards,
Markus

      parent reply	other threads:[~2026-05-19  9:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19  2:38 Chen Ni
2026-05-19  8:16 ` Konrad Dybcio
2026-05-19  9:40 ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a979a727-1c59-4281-b9e9-2e5d582f14e7@web.de \
    --to=markus.elfring@web.de \
    --cc=andersson@kernel.org \
    --cc=francisco.ruiz@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nichen@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®