From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78F653E51E4 for ; Mon, 15 Jun 2026 12:12:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781525547; cv=none; b=dAjrxb4KSu82/LrNnk0t09oD61cWLW/0/Xd0qqytIURaKR+skqaWGbJqIq4pzMVQ3rvHuSR+ftcgG5Nk0f54VnHp4tkqV8vbTcM3uqKM0yzY0ZMQF7OL5rkD1wiuUmsYHOdpMXu+mS27FzZGfO3xM9veRV+bbnpCortRf943teQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781525547; c=relaxed/simple; bh=+/7n2Rq1vOpj2Q8D7C+okfFDDw5hzhTjlFZrTWqulM0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NVf1x0uvntN96zXa9m3KLNiNIccC7/eQr081t//5rYOlEGeiVSsGWf0oQ208dz2k2jLM3603Cz8zDifokJ0Su162+fqbhehKuukfdQ+nOfe1k8s9IeuHmKAlSVBFalg0eXFES6Go8VfiUsTAYeBbVYkpF9YJ0+BjoVzvRjaDtuo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=R8asB7bj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=a2gdFCCB; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="R8asB7bj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="a2gdFCCB" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FAohBh3986951 for ; Mon, 15 Jun 2026 12:12:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BsKI60nJ3cRPMhSIVuZjFVkGFqOS9FdBjlayzytfzoQ=; b=R8asB7bjvkXSZB4M jmQagOrX7VJqHo3eIGNqgKXycJiY/adEKkIfYZhlQ2/1ZplgKUz0FZE3lSN4wEw9 PDbiULJ2fUS6N4SOI6+ORmXphM5d21IIX8jrN6sOVdVSaN31E9kuemIkpQ3nFt3f HFCu3SiON9TfEV4RTrZXmCSDae3J5t91EGQYBn6apo7vg/trR1+ScdOpaxgxViXY G0Oz44rS83ab3DAcQQmleQPHLvIF+czEHmVQBDDaHzY6eMpZ43YOoROX+PZj7jO4 K3rG0/AGYJMwvDtCpW8ZbSACUaBKiKZM/Oc06xDW8UOxF3Zoqjlal+fjbj80etXy pkv5uA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4etew0gjmg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 12:12:25 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-36bbdcf36f0so2644807a91.0 for ; Mon, 15 Jun 2026 05:12:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781525545; x=1782130345; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BsKI60nJ3cRPMhSIVuZjFVkGFqOS9FdBjlayzytfzoQ=; b=a2gdFCCBe3fq1NT9F5bxp9TrGrcpFHQNaZk+li2T08VyGvyIEudjHpOkJTC6ZE5W6n /6HF0LZwDEwf/4tooeOln/kZq+gQ09FaP5Ne3MkipmFgJnuzukDCQLr3ZcPniZexVO5o 11nlMmd2t9W8UUw5T9REsNpR0GX6z7Lnq7M9vPTVgk+GfKOlv3/fT0DolWJ/NlPwPUH/ bC+tWjteDbLbKQP4B/h2ZGpzm1D3emMSDYwnmlZaj++x2wu3kCgZJArhr5LbTynBAYmd ohQxe3zfHF1bBdPcAc82GVnwM1V7Fj/V9yzQ2Cv7Rke+TbTjJZG9mFyY5sG0emOswsIm IRQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781525545; x=1782130345; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BsKI60nJ3cRPMhSIVuZjFVkGFqOS9FdBjlayzytfzoQ=; b=maObAb6KskjOxEF9YjI1iuwua53zhBIRZx6BWV6boVL4w/EdP4/uBqfJNGBuNz/sTz h9bB79STs9Cv3qlHCQ0Y4I5EnSDpuuGUz9qn8pj6C1oWK2Q+p3jMbSEMm3qHiY6ZkDVz GsZ+evo2NEPlpABeJjdA3q5Jks77VYP0c9O6tEdlcDZJzIfETp9lCTMkWtFnJBm29h5d qqWKotYH+G5w8hAZnZ5seUxRKz4Txh+U8TWhswvTJWItv+1oOrY127X6wl0Oh1Q4FTaI WkeSYigod8W6TMpQ2BrAtecT3hvMlfAgJzGg3EXvo/xt6MLfdbfvGtk4yZiS1ASRKudg BMow== X-Forwarded-Encrypted: i=1; AFNElJ/fuOka6KkVb4UktbYaqxpbNsOaWkulfwMF7f3nL3wUcl+/X0PefbxIFSi/J01ziSlBQtFt81+hs8JqQfM=@vger.kernel.org X-Gm-Message-State: AOJu0YzOJ+it6uXCndBkQmZznjbYe4HIuCCNW0vnYAumcdixrwTt7vad POxBKMP1WPajiR78GRvk4F9ZoryKMwG7/GA6XY/kNibzg/6dQe+v2FeF+Xp66UA6vqFfcLzHVxy YxP1+qO+cadfgx4O4VQ61jXiJ0ShfIoODyi3jsjbuRCcaiiwOhszwIBex4fbcD2LQgLE= X-Gm-Gg: Acq92OEhrOR76CjG3iVeIpKEgFVY5jhTj4lcDL7HArMTWG1Zk4AwABRKrWTVJ12RJQj 3HGpgmpKJd5YcRjGgs6SpuoEqX5fxMCRb9e4gWqep6Q/wCBh+XHOe8ob6Y0Dq8RoElQl5N0Fiy8 Q+EzQcrm3+/N0AlBrVgK412zZAiSTsZ8DcGa81k2Aqz0sO51C2W7tRtGK2En4XcTJ8V76EvVt7h jE9HucZBm2gVcPlzNbx2I6kICUAv1YFYH8iKJWMT9DDUo/Uoo+m2yyDCIUSQ+QyR64o4laAORKa jfo0Nn69pdh8xEH1dvrqjqKAAVfynZtCH0WJlB2QUdHEgMHxBB5CUIFRmQj8fAychr1wdi5zCTQ g5CtAefiXtbl/iCd+5zrTSiB6ITKRo0ZDk4f98TZeOXBqtGTyaE7v X-Received: by 2002:a17:90b:5205:b0:36b:769c:c037 with SMTP id 98e67ed59e1d1-37a1e0084cdmr9309400a91.5.1781525544097; Mon, 15 Jun 2026 05:12:24 -0700 (PDT) X-Received: by 2002:a17:90b:5205:b0:36b:769c:c037 with SMTP id 98e67ed59e1d1-37a1e0084cdmr9309346a91.5.1781525543224; Mon, 15 Jun 2026 05:12:23 -0700 (PDT) Received: from [192.168.1.13] ([106.222.231.34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-379c298c3d6sm8030534a91.0.2026.06.15.05.12.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 05:12:22 -0700 (PDT) Message-ID: Date: Mon, 15 Jun 2026 17:42:15 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/8] dt-bindings: remoteproc: qcom,pas: add thermal mitigation properties To: Daniel Lezcano , Krzysztof Kozlowski Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Amit Kucheria , Manivannan Sadhasivam , Konrad Dybcio , Kees Cook , "Gustavo A. R. Silva" , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Manaf Meethalavalappu Pallikunhi References: <20260609-qmi-tmd-v3-0-291a2ff4c634@oss.qualcomm.com> <20260609-qmi-tmd-v3-1-291a2ff4c634@oss.qualcomm.com> <20260610-ocelot-of-stimulating-excellence-bcb0fe@quoll> <03d863ee-2caa-41f2-94b5-7332fc930b42@oss.qualcomm.com> <7f1e46fb-15e3-4638-9930-8abc1dd5a778@oss.qualcomm.com> <3cbcaf8c-357e-42d2-91c1-9d1a32c55ed0@oss.qualcomm.com> Content-Language: en-US From: Gaurav Kohli In-Reply-To: <3cbcaf8c-357e-42d2-91c1-9d1a32c55ed0@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDEyNyBTYWx0ZWRfXyl43MAQS71f+ 0wq4fRhQ6nMh6yMyIFO9wc+J8yb4hu0CLBx9TD2Vxm+go82dtMMso9Cv6HHquXwlR9DZfeWdKPO siak+EXaMiGFsPxfLsQWKDpz4ek7LsM= X-Authority-Analysis: v=2.4 cv=QLlYgALL c=1 sm=1 tr=0 ts=6a2fec29 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=JaHktJlP2QtFIg7UHuVw+g==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=DT6rP8QiwiOHS3JImSQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDEyNyBTYWx0ZWRfXyalPKlWqN63z vF3jXSiu0S8zTTadHcYwDId7qNMmviGZSQjBEixnYjjA3N9N1HvR2whJgTFaPAYfUbNXhKF9ske yZ/uufYdyavJbIjX3DmWCD8da0/dN/AKSVUT7Sh//HEUKSRNKK6vFAdQR3PnR6iJr4X+Xzud/U4 cpDpad9CY928OKxY/2J+yMvstm4+tjm86Tfg6PomKgoeQJMw7DoY7d6ODyLf5lBSoCUc5pnRacg +FVZ0G+ZCqyfEIdgC8EmLcEjfUoQ/23g5yuZyOUHzkx3QGVcnhwiiscgWNiKJfFHmKjCxCf1O6X 1Skprv5at0HladqCRXtGDzAcNfwKN3fYeT2HWrYnNfenFQSM1tV7vb8cCrkkJoYAlY6O8NdjL5s HhWucj1ppjXqFbvsPTt6YvJQ8cLvegxKhLIJJxRsSPPvq/KsM21f1QCl7PQghX0we/KNvIPFK1Q HoyhsVCAkdGT4wDKvEw== X-Proofpoint-GUID: 0ri5egKeksRiLFBAldfZhiHtocuFPa33 X-Proofpoint-ORIG-GUID: 0ri5egKeksRiLFBAldfZhiHtocuFPa33 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_03,2026-06-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 priorityscore=1501 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150127 On 6/15/2026 4:04 PM, Daniel Lezcano wrote: > On 6/13/26 13:05, Gaurav Kohli wrote: >> >> >> On 6/13/2026 1:11 PM, Krzysztof Kozlowski wrote: >>> On 12/06/2026 15:52, Gaurav Kohli wrote: >>>> >>>> >>>> On 6/11/2026 5:53 PM, Krzysztof Kozlowski wrote: >>>>> On 11/06/2026 13:12, Gaurav Kohli wrote: >>>>>>> Why? And where is this generic property defined? You cannot just >>>>>>> sprinkle generic properties in random bindings. >>>>>>> >>>>>> >>>>>> Ack, will add why part. >>>>>> These names are matched with the thermal mitigation device >>>>>> identifiers >>>>>> populated by remote firmware over QMI and define mitigation >>>>>> devices are >>>>>> exposed as cooling devices. >>>>> >>>>> No, -names correspond to values passed via DT, not some remote >>>>> firmware. >>>>> The remote firmware should give you interface which is explicit and >>>>> does >>>>> not need such properties. >>>> >>>> thanks Krzysztof for review, We need tmd-names because of following >>>> reasons: >>>> >>>> Following Daniel's series [1], the thermal framework supports >>>> mapping multiple cooling devices per remoteproc/device via indexed >>>> cooling-cells. >>>> >>>> 1) The thermal framework's cooling-maps reference >>>> cooling devices by index (for #cooling-cells = <3>). Without tmd-names, >>>> there's no way to know which index corresponds to which TMD, as >>>> firmware >>>> may return tmd-names in any order. >>>> >>>> below are the changes post new thermal mapping changes: >>>> DT: tmd-names = "cdsp_sw", "xyz"; >>>> Firmware: ["cdsp_sw", "xyz1", "xyz2",] >>>> Driver registers: Only "cdsp_sw" (index 0) and "xyz" (index 1) >>> >>> names property are not to instruct drivers to register or not to >>> register something. >>> >>> I don't understand the problem and explanation in the binding is >>> basically non-existing. >>> >>> Remember that all lists and indices ARE FIXED, so driver knows exactly >>> which index means what. >>> >> >> thanks for review, shall i use driver data, which is basically pas >> data structure like below: >> >> static const struct qcom_pas_data { >>      .crash_reason_smem = 601, >>      .firmware_name = "cdsp.mdt", >>      .tmd_names = (const char *[]){"xyz", NULL}, >>      .num_tmds = 1, >> >> Is something like above acceptable? and this will also help to filter >> tmd names as well? > > > How the thermal framework will bind the thermal zone with the TMD ? > (node pointer, id) ? > Hi Daniel, thanks for review. With id only, in this case instead of taking tmd names from device tree, qmi_tmd will take tmd name from pas_data(driver) and register with the cooling framework with id only. Please let us know if this looks fine. thanks Gaurav