From: Mark Brown <broonie@kernel.org>
To: Maurizio Casciano <mauriziocasciano7@gmail.com>
Cc: linux-sound@vger.kernel.org, cezary.rojewski@intel.com,
liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com,
yung-chuan.liao@linux.intel.com, kai.vehmanen@linux.intel.com,
pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com,
jekhor@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/2] ASoC: Intel: Add Cherry Trail RT5677 machine driver
Date: Wed, 2 Sep 2026 17:24:44 +0100 [thread overview]
Message-ID: <aphNzNx3G4qDt9X-@sirena.org.uk> (raw)
In-Reply-To: <20260902123007.769820-2-mauriziocasciano7@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 933 bytes --]
On Wed, Sep 02, 2026 at 02:30:06PM +0200, Maurizio Casciano wrote:
> The Lenovo Yoga Book YB1-X91F/L uses the Cherry Trail SSP2 link with
> an RT5677 codec and a TS3A227E headset detector. Its amplifiers and
> headphone path also need board-specific GPIO sequencing.
> +static int cht_rt5677_aif1_hw_params(struct snd_pcm_substream *substream,
> + struct snd_pcm_hw_params *params)
> +{
> + struct snd_soc_pcm_runtime *rtd = substream->private_data;
> + struct snd_soc_dai *codec_dai = snd_soc_rtd_to_codec(rtd, 0);
snd_soc_substream_to_rtd()
> +static const struct snd_soc_aux_dev cht_rt5677_headset_dev = {
> + .dlc = COMP_AUX("i2c-ts3a227e"),
Shouldn't this be using an ACPI formatted name? Doesn't really matter I
guess but other Intel stuff does.
> +static const struct acpi_gpio_mapping cht_rt5677_gpios[] = {
> + { "speaker-enable-gpios", &speaker_enable_gpio, 1 },
> + { }
> +};
We ask for more names below...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-09-02 16:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 12:30 [PATCH v7 0/2] ASoC: Intel: Add Yoga Book RT5677 support Maurizio Casciano
2026-09-02 12:30 ` [PATCH v7 1/2] ASoC: Intel: Add Cherry Trail RT5677 machine driver Maurizio Casciano
2026-09-02 16:24 ` Mark Brown [this message]
2026-09-25 0:33 ` Maurizio Casciano
2026-09-02 12:30 ` [PATCH v7 2/2] ASoC: Intel: cht: Add Yoga Book RT5677 machine entry Maurizio Casciano
2026-09-24 21:55 ` [PATCH v7 0/2] ASoC: Intel: Add Yoga Book RT5677 support Maurizio Casciano
2026-09-24 22:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aphNzNx3G4qDt9X-@sirena.org.uk \
--to=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=jekhor@gmail.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mauriziocasciano7@gmail.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®