From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AA844EFFCA for ; Mon, 21 Sep 2026 18:07:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790014065; cv=none; b=j9FTX1Gux4h3nQtrOh5e3QqXHK/J9V/lUQ1h6YJsG7bMODGt/WJOoCe7Cj7L3YIYMU9Rf1aFdV95DlXS12aHHZMiwVgKN5B2dq0oMOOvK6bLuW17TsshqcjVgfH3h3A9LzAOXUyTAafr1vh+Jdlph74A1cVjilkl71tPQltCQKg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790014065; c=relaxed/simple; bh=+T0UsfU3X4YjOf5Y2LRAUCr1O+PNBgrbP5i3+Ui+Rro=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rwXSv7sS5DS4nhDSwrkhO7oW2JY9cxCwXWWVrVMd4NEKps2F+uIOa4icD2NjlNuJYG6DTTGRQ3Tn/I6pdC9XcD1C/ben+SxP19Sv0zt2wY9sPvwI/9Y0CJoutDFiNVfkYcN25RE2d5KIhZFqsY+1yjlwvNvxseaxZLgOoEXTLHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gbpXBHk8; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gbpXBHk8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790014063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ddb+dnisDk6IFrtpOihrh9CoT4KAmSKdN6ihcGxdhtE=; b=gbpXBHk8JfXl9LL0jwEeHUSXzIM6uTLxPxokEIilGsl/uEVhpV3FPWUV7o8ch2liGUBFN7 D/QsaggEAIvX/zbINOeixssrHMqoto8cZ949uMf7tpgLyVvWWpYyJ/Xin21laBSzMWlztS VlSW04dVP3Y2VkkNxNIe5bPlwxIgU2Q= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-21-rQ9njAx6OLyzvpB4FR5SlA-1; Mon, 21 Sep 2026 14:07:39 -0400 X-MC-Unique: rQ9njAx6OLyzvpB4FR5SlA-1 X-Mimecast-MFC-AGG-ID: rQ9njAx6OLyzvpB4FR5SlA_1790014057 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 71C611955D78; Mon, 21 Sep 2026 18:07:37 +0000 (UTC) Received: from bfoster (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8A7F2195604C; Mon, 21 Sep 2026 18:07:35 +0000 (UTC) Date: Mon, 21 Sep 2026 14:07:33 -0400 From: Brian Foster To: Andrea Parri Cc: Christian Brauner , "Darrick J . Wong" , Joanne Koong , Damien Le Moal , Hannes Reinecke , Daniel Gomez , Pankaj Raghav , Dave Chinner , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] iomap: fix error handling regressions Message-ID: References: <20260921083133.2960-1-parri.andrea@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260921083133.2960-1-parri.andrea@gmail.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On Mon, Sep 21, 2026 at 10:31:30AM +0200, Andrea Parri wrote: > Fix three independent error handling regressions in iomap: > > - clear the writeback context after a failed ->writeback_submit() call, > preventing an already completed ioend from being submitted again; > - preserve an iomap iteration error when iomap_fiemap() has a pending > extent to emit; and > - preserve a direct I/O data path error when sub-block tail zeroing > succeeds. > > The fixes have no ordering dependencies and can be applied or backported > independently. Each issue was reproduced before and after its respective > fix. > These all look reasonable to me: Reviewed-by: Brian Foster > Andrea Parri (3): > iomap: don't resubmit an ioend after ->writeback_submit() failed > iomap: don't lose a fiemap iteration error when emitting the last > extent > iomap: don't lose a failed direct I/O bio's error when zeroing the > tail > > fs/iomap/direct-io.c | 11 ++++++++--- > fs/iomap/fiemap.c | 8 ++++---- > fs/iomap/ioend.c | 10 +++++++++- > 3 files changed, 21 insertions(+), 8 deletions(-) > > > base-commit: 93f51579e7df248780214094418f205253383cc5 > -- > 2.53.0 >