mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oliver Upton <oupton@kernel.org>
To: Fuad Tabba <fuad.tabba@linux.dev>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Sean Christopherson <seanjc@google.com>,
	Shuah Khan <shuah@kernel.org>, Will Deacon <will@kernel.org>,
	Fuad Tabba <tabba@google.com>,
	kvmarm@lists.linux.dev, kvm@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: selftests: Fix arm64 sysreg header dependencies
Date: Mon, 21 Sep 2026 13:20:20 -0700	[thread overview]
Message-ID: <arGRhHgP_izSwW4T@kernel.org> (raw)
In-Reply-To: <20260902134118.2718200-1-fuad.tabba@linux.dev>

Hey Fuad,

Thanks for the fix here.

On Wed, Sep 02, 2026 at 02:41:18PM +0100, Fuad Tabba wrote:
> ---
> Unlike the two existing sysreg-defs.h rules, this one's recipe is a recursive
> make, so its prerequisites are not the recipe's arguments. They only decide
> whether to recurse, which is a question tools/arch/arm64/tools/Makefile already
> answers. An alternative is therefore to drop the two explicit inputs in favour
> of:
> 
> 	$(GEN_SYSREG_DEFS): FORCE
> 
> leaving that Makefile as the only place naming the generator's inputs. Both
> forms regenerate the header and rebuild the dependents in the same invocation,
> and neither rebuilds anything when nothing changed. I kept the explicit
> prerequisites so that the recursion stays conditional, but I am happy to respin
> with FORCE if you would rather.

This might be the better approach at this point. In the unlikely event
that new dependencies get added to the kernel side of this, I'll give it
approximately a 0% chance that the author will update this rule :)

Thanks,
Oliver

  parent reply	other threads:[~2026-09-21 20:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 13:41 Fuad Tabba
2026-09-21  7:10 ` Fuad Tabba
2026-09-21 20:20 ` Oliver Upton [this message]
2026-09-22  7:09   ` Fuad Tabba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arGRhHgP_izSwW4T@kernel.org \
    --to=oupton@kernel.org \
    --cc=fuad.tabba@linux.dev \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=shuah@kernel.org \
    --cc=tabba@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®