Re: [PATCH v2 2/3] arm64: rsi: Add realm hash algorithm defines

[Kohei Enju <enju.kohei@fujitsu.com>]

On 09/29 17:57, Yeoreum Yun wrote:
> From: Sami Mujawar <sami.mujawar@arm.com>
> 
> Add macro definitions for the hash algorithm identifiers, as
> specified in the Realm Management Monitor (RMM) specification.
> 
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
>  include/linux/arm-smccc-rsi.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/linux/arm-smccc-rsi.h b/include/linux/arm-smccc-rsi.h
> index fddb77986f70..a83df2655808 100644
> --- a/include/linux/arm-smccc-rsi.h
> +++ b/include/linux/arm-smccc-rsi.h
> @@ -144,6 +144,13 @@ struct realm_config {
>  
>  #endif /* __ASSEMBLER__ */
>  
> +/*
> + * The RSI definition of the Hash Algorithm (as specified by the Secure
> + * Hash Standard) returned in the realm_config data structure.
> + */
> +#define RSI_HASH_SHA_256	0
> +#define RSI_HASH_SHA_512	1

Is it intentional to omit RSI_HASH_SHA_384 here? I realize it might not
be implemented in RMM yet, but would it be worth adding the constant now
for future support?

Thanks,
Kohei

> +
>  /*
>   * Read configuration for the current Realm.
>   *
> 
> -- 
> 2.43.0
>