mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krishna Chomal <krishna.chomal108@gmail.com>
To: Ciro Pedrini <ciro.pedrini@gmail.com>
Cc: "Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] platform/x86: hp-wmi: Add OMEN board 8A17 thermal profile support
Date: Tue, 6 Oct 2026 10:21:56 +0530	[thread overview]
Message-ID: <asR-FLwLfpyT8uOz@archlinux> (raw)
In-Reply-To: <20260925205226.883724-1-ciro.pedrini@gmail.com>

On Fri, Sep 25, 2026 at 05:52:26PM -0300, Ciro Pedrini wrote:
>The HP OMEN 17-ck1xxx (board 8A17) isn't in omen_thermal_profile_boards,
>so hp-wmi uses the generic thermal profile query. The firmware only
>stores that value and never acts on it, so the EC stays in its default
>mode and the CPU is held at 45 W whatever profile is selected.
>
>The board uses the OMEN interface (mode byte at EC 0x95, thermal policy
>v1) and also needs the timed profile quirk: without it, the EC drops
>back to the default mode about two minutes after each profile change.
>
>Add 8A17 to omen_thermal_profile_boards and
>omen_timed_thermal_profile_boards.
>
>With this, all three profiles work and sustained package power under
>load goes from 45 W to 56-79 W.

Hi Ciro Pedrini,

I was working a patch[1] involving omen_timed_thermal_profile_boards[]
and needed some diagostic info. Would you mind attaching the acpidump
for your board 8A17?

Thanks!

[1]: https://lore.kernel.org/platform-driver-x86/asPy5Q5wNYaMzTqJ@archlinux/#m922ff6cf9a68285d2b0f64e578fd6d2d6fa573f4

>Cc: stable@vger.kernel.org
>Assisted-by: Claude:claude-opus-5-5
>Signed-off-by: Ciro Pedrini <ciro.pedrini@gmail.com>
>---
>
>Notes:
>    Tested on 7.2.7, whose OMEN profile code matches for-next. Without the
>    timed quirk, EC 0x63 counts down from about 120 after each profile
>    write, and at zero the EC resets 0x95 to 0x30.
>
>    8A13, 8A14, 8A16 and 8A18 appear in the same DSDT. 8A18 is in the OMEN
>    list but not the timed one, so it may have the same two-minute
>    fallback. I can't test it.
>
>    I used an AI assistant (Claude) for the ACPI analysis and to draft this
>    message. I tested the change on my machine and reviewed everything.
>
> drivers/platform/x86/hp/hp-wmi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
>index 7ab81ce5f..76f489d5d 100644
>--- a/drivers/platform/x86/hp/hp-wmi.c
>+++ b/drivers/platform/x86/hp/hp-wmi.c
>@@ -207,7 +207,7 @@ static const char * const omen_thermal_profile_boards[] = {
> 	"886B", "886C", "88C8", "88CB", "88D1", "88D2", "88F4", "88F5", "88F6",
> 	"88F7", "88FD", "88FE", "88FF",
> 	"8900", "8901", "8902", "8912", "8917", "8918", "8949", "894A", "89EB",
>-	"8A15", "8A18", "8A42", "8A43",
>+	"8A15", "8A17", "8A18", "8A42", "8A43",
> 	"8BAD",
> 	"8E41",
> };
>@@ -226,7 +226,7 @@ static const char * const omen_thermal_profile_force_v0_boards[] = {
>  * "balanced" when reaching zero.
>  */
> static const char * const omen_timed_thermal_profile_boards[] = {
>-	"8A15", "8A42",
>+	"8A15", "8A17", "8A42",
> 	"8BAD",
> };
>
>
>base-commit: f475845eaf3d749114a63270bf2efea459e14dd2
>-- 
>2.55.0
>

      parent reply	other threads:[~2026-10-06  4:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 20:52 Ciro Pedrini
2026-10-05 18:52 ` Ilpo Järvinen
2026-10-06  4:51 ` Krishna Chomal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asR-FLwLfpyT8uOz@archlinux \
    --to=krishna.chomal108@gmail.com \
    --cc=ciro.pedrini@gmail.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®