From: Andrea della Porta <andrea.porta@suse.com>
To: Andrea della Porta <andrea.porta@suse.com>
Cc: "Uwe Kleine-König" <ukleinek@kernel.org>,
linux-pwm@vger.kernel.org, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Naushir Patuck" <naush@raspberrypi.com>,
"Stanimir Varbanov" <svarbanov@suse.de>,
mbrugger@suse.com, "Sean Young" <sean@mess.org>,
"Julian Braha" <julianbraha@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH v12 0/2] Add RP1 PWM controller support
Date: Tue, 6 Oct 2026 15:54:22 +0200 [thread overview]
Message-ID: <asT9ji8v8gw8XfcB@apocalypse> (raw)
In-Reply-To: <cover.1790686331.git.andrea.porta@suse.com>
Hi Uwe,
since all of the patches have received at least one Reviewed/Tested-By
and Sashiko doesn't seem to complain anymore, could we go on with
this patchset?
Many thanks,
Andrea
On 15:02 Tue 29 Sep , Andrea della Porta wrote:
> This patchset adds support for the PWM controller found on the
> Raspberry Pi RP1 southbridge. This is necessary to operate the
> cooling fan connected to one of the PWM channels.
>
> The tachometer pin for the fan speed is managed by the firmware
> running on the RP1's M-core. It uses the PHASE2 register
> to report the RPM, which will be exported by this driver via
> a function. A subsequent patch will add the function to read the
> speed to this driver and a new device and driver to read the RPM
> and export this value via hwmon.
>
> Subsequent patches will also add the CPU thermal zone, which
> acts as a consumer of the PWM device.
>
> Best regards,
> Andrea
>
>
> CHANGES in V12:
>
> - added a comment to better explain why we don't need to save and
> restore config registers upon suspend/resume, hopefully Sashiko
> will stop complaining about that.
> - the RMW access to teh global control register is not synchronized
> via spinlock.
> - patch 3 from previous release:
> "arm64: dts: broadcom: rpi-5: Add RP1 PWM node"
> has been dropped from this patchset since it's already applied
> to Florian's devicetre-arm64/next branch.
>
> Link to V11:
> https://lore.kernel.org/all/cover.1790606188.git.andrea.porta@suse.com/
>
>
> Naushir Patuck (2):
> dt-bindings: pwm: Add Raspberry Pi RP1 PWM controller
> pwm: rp1: Add RP1 PWM controller driver
>
> .../bindings/pwm/raspberrypi,rp1-pwm.yaml | 66 +++
> drivers/pwm/Kconfig | 7 +
> drivers/pwm/Makefile | 1 +
> drivers/pwm/pwm-rp1.c | 428 ++++++++++++++++++
> 4 files changed, 502 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/raspberrypi,rp1-pwm.yaml
> create mode 100644 drivers/pwm/pwm-rp1.c
>
> --
> 2.35.3
>
prev parent reply other threads:[~2026-10-06 13:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 13:02 Andrea della Porta
2026-09-29 13:02 ` [PATCH v12 1/2] dt-bindings: pwm: Add Raspberry Pi RP1 PWM controller Andrea della Porta
2026-09-29 21:37 ` Rob Herring (Arm)
2026-09-29 13:02 ` [PATCH v12 2/2] pwm: rp1: Add RP1 PWM controller driver Andrea della Porta
2026-09-29 18:56 ` Gary Guo
2026-10-06 13:54 ` Andrea della Porta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asT9ji8v8gw8XfcB@apocalypse \
--to=andrea.porta@suse.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=gary@garyguo.net \
--cc=julianbraha@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mbrugger@suse.com \
--cc=naush@raspberrypi.com \
--cc=robh@kernel.org \
--cc=sean@mess.org \
--cc=svarbanov@suse.de \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®