mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jisheng Zhang <jszhang@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart
Date: Thu, 8 Oct 2026 21:49:07 +0800	[thread overview]
Message-ID: <asefUxK90dlGkW8a@xhacker> (raw)
In-Reply-To: <20261007-450d3d9a4f4a2c07cc088067@squawk>

On Wed, Oct 07, 2026 at 02:04:05PM +0100, Conor Dooley wrote:
> On Mon, Oct 05, 2026 at 11:19:18PM +0800, Jisheng Zhang wrote:
> > Add the compatible for the UARTs of the Synaptics SL2610, which are
> > compatible with the Synopsys DesignWare APB UART.
> > 
> > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> > ---
> > 
> > since v1:
> >  - use sl2610 instead of sl261x
> >  - send as a separate patch
> > 
> >  .../devicetree/bindings/serial/snps-dw-apb-uart.yaml | 12 +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> > index 664305de4986..a40f2737e71b 100644
> > --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> > @@ -34,7 +34,16 @@ allOf:
> >        properties:
> >          resets:
> >            minItems: 2
> > -    else:
> > +
> > +  - if:
> > +      not:
> > +        properties:
> > +          compatible:
> > +            contains:
> > +              enum:
> > +                - starfive,jh7110-uart
> > +                - syna,sl2610-uart
> 
> Is the number of uart resets on this device variable?

Yes, some uarts have only 1 reset, while others have two resets.

> 
> > +    then:
> >        properties:
> >          resets:
> >            maxItems: 1
> > @@ -80,6 +89,7 @@ properties:
> >                - starfive,jh7100-hsuart
> >                - starfive,jh7100-uart
> >                - starfive,jh7110-uart
> > +              - syna,sl2610-uart
> >                - ultrarisc,dp1000-uart
> >            - const: snps,dw-apb-uart
> >        - const: snps,dw-apb-uart
> > -- 
> > 2.53.0
> > 



      reply	other threads:[~2026-10-08 14:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 15:19 Jisheng Zhang
2026-10-07 13:04 ` Conor Dooley
2026-10-08 13:49   ` Jisheng Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asefUxK90dlGkW8a@xhacker \
    --to=jszhang@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®