From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756284AbcJ3PDL (ORCPT ); Sun, 30 Oct 2016 11:03:11 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:59451 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752783AbcJ3PDI (ORCPT ); Sun, 30 Oct 2016 11:03:08 -0400 Subject: Re: [PATCH] nbd: Fix error handling To: Christophe JAILLET , , References: <20161030042827.10160-1-christophe.jaillet@wanadoo.fr> CC: , , From: Jens Axboe Message-ID: Date: Sun, 30 Oct 2016 09:02:45 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161030042827.10160-1-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [166.170.49.218] X-ClientProxiedBy: CY1PR15CA0016.namprd15.prod.outlook.com (10.163.14.26) To BN6PR15MB1185.namprd15.prod.outlook.com (10.172.205.139) X-MS-Office365-Filtering-Correlation-Id: 8cb4e873-7b3a-45b4-32ae-08d400d5d3d5 X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;2:Ky5GcsRzLlAKLzl2ohI4eBcQ8CAv/gWyONc4N+/GOdDvgX3ux2j4WbdpNlOVSUfu5Bq6/LQj0sisvc+i1c8AYnNbaWYrE41AWuhn1thur5XSXhJ9FdZmJYbHPC0f81ZcfhQga8epBPJTgC5XWWFeLh3rLhSXUMgP6r7tcRrKhDB0Srl1IFeEUFji2AUWHUox5grByLfeJTEHOrRvFRXCzg==;3:5Ab+rVRDty5tRdjbgxSe/gRl1/0qyo37tQprpn87KKBFJfwfKXLgw9YR2O/uEBNKIGcKmoIJfauEzMwfq0rcdqfHIBDVMgmIMCXFk5Ju8EsKjOZieoLWlITTXbQOs442rtV1G834RAXikAD46ylj/g==;25:PsJ2MrzVhTqtQNj7woIj9FhHsrq36E9zx3ECRn+XgJyTR3cZs8l/NPd/1urO2JL852AYs+B/Zxf91ubdm94yJE0EG5Or5MSdmSDNjeiZTZcI9Pkr6mvhZvdUrmF6gXSIRpNy3hCT59tSUgoExjTND5jBPOaVUw3mu7/IAljDYhfhYp888qsvdCoZgg6/prol9HxUWd7yk7cF2RXxUqfoUbgyShRsmzehN07UmeZTU2Z4KL3mVsdSL4ohZNPV5P8Yd58VuiIFs0/nKtJBFYQn9ZanPtRRen3XD5Gq/xYT0pDQMfqb6nUrbcdUzYgQ1p0AIrbC7YvwAcPmJPv6dAmpu8uwg6kf9KEKnmneSEdGMqiFKKrwDpvc/zTnRCZLstbV6AqNLFCG2UD7HNMjBRPFEr1ykA4jtQM3Q5QBYjn0RW0= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1185; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;31:lX9PDC2vnVZSpjFJzep5HrCsD4ptthya63UrrGzZ1eHjI7yz34UXoOJ81Xx7VjUvnUikSC0ugn1LpmxtA5tSfCliw0Bivt7n14OD5HlZhOrFiy+XF2UJooVje3Mt0KzKTSFGB0xp1HzO0gDvReofekMdWWw7QeyWA7LGUom8TkmR6foRs0uWx6v2kkob9E05x9rjpsKITyDzgZNntBU1woxloQ+BSgKlvJ2aE49pMiVqBrSdTbJQcL0OSsjxnZyjsxMIN6wwgS0RLXmrUy8ZpQ==;20:vdCE5I3ETaVkjM2WaH6rNApPcOEvbNTVrvDITB/QyREn8dySCvYiXw+ZVgEzlSe0sPQILo9ulBx0Pdj+Cr6wwqfMdoShxpj+aPlue3RbC8LWXcw29u/BRhIgoWupyRdSzMDzuyAKWmXfFrEofcJY0i/sp+XHP/ElRDxUh5XXhe8=;4:Z8Z2DlFVNGe2jBCosGcghSXNbVT5cXMWjlnvN4ppyleXXN2eZaOcOz2/mjCJzK5sa1DcOzUyjHNvHoGPrVpxmD/4UU+x1Yy2ZJAsggyzZ8Ov+qDx02OMIW1av8CzxLvby3jrtwWIiKY3AMn6J9S8hf8wRIs34RrjzFEFsKokcz6EHv0TvSFw/p9D4SFBW11xmJMPKcZncVbFpyuFCxkE/tsFU0FP5wSYw8iDWymcfACohQE1IlKU8a7+NmYs0GT8+ox/dBF56T9SoObxb7uSHSzOhzgWlQlbyha+Y6Mk412jOTQZrNjAzS9xOUcqgSNlG+j1NuZ+oXPmgtLWo6ZanHwIVRIEJ0U9BkHVLGrNahmmYup4ALto8h903LaqLtxKg5a2YTTyKUr41oaqKfG+aA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:BN6PR15MB1185;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1185; X-Forefront-PRVS: 01110342A5 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(199003)(189002)(377454003)(24454002)(81156014)(33646002)(101416001)(81166006)(31696002)(65826007)(8676002)(86362001)(76176999)(54356999)(106356001)(50986999)(105586002)(31686004)(42186005)(68736007)(5660300001)(4001350100001)(77096005)(97736004)(47776003)(23746002)(64126003)(5001770100001)(2950100002)(558084003)(65806001)(65956001)(7846002)(230700001)(36756003)(50466002)(6666003)(586003)(2906002)(3846002)(6116002)(2201001)(4326007)(189998001)(92566002)(83506001)(7736002)(6636002)(66066001)(305945005)(3480600002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1185;H:[172.20.10.9];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR15MB1185;23:z6FJukW0lHBwEyh6XXlhET4K4zM7jgBzJ80vS?= =?Windows-1252?Q?l+hneII12WcZUE50QPEPAmmbmdnEFZefNt6Z0qh/VRLH1lddTNE3P1Zr?= =?Windows-1252?Q?UebNbgn2frhZPEkbRbS5nEnsFql+/bqokscmmGu8L11Axh3h0ihTr2Sx?= =?Windows-1252?Q?ODZ4NuuUdXq3D1QEaC3nfFgu16O0nJ/jlx7AYHI7nVisQ5uTUgKSRBYL?= =?Windows-1252?Q?ZK/NekTELfU+KgOke5R3QsmQtLUi82rwRSuTOOCVOmCk9oKXk6OpZ9CM?= =?Windows-1252?Q?xgb3C/1f9szb59BqnQ74uDvfhl8kGDRIwlvSa9RLFyS0mAo0MkclD+VR?= =?Windows-1252?Q?NSH4TvQrsmlUTleF7anWNLu7OM1vD/aPqdL2MxDCIl5VsSangx/i/dew?= =?Windows-1252?Q?flZe2SzsX54QB7jNysfEcOZHno3CZFTOYzBs45c2jUkYj1gyZINX8bmt?= =?Windows-1252?Q?KgSsOPk29jPvoxoSZmxItx5a7hslAfZJtu8fqw7NaV1Ppns07owlLUDB?= =?Windows-1252?Q?hWIy/NQ5xbSLPzVUEOizI9gmzxIP9TXgMEOvml3h+gMVy5Q9ylAkg46n?= =?Windows-1252?Q?QOOmfkzgbQF6YiyKZxDKOqdBWtE6C0T5y7CCOsGcDB2BnOkOcpgBo0Ga?= =?Windows-1252?Q?xq5x6Ckb8E7QI54aGK07oyFDkRe0MgdBiGPg0iPA1i1+FEuzoTD71m4F?= =?Windows-1252?Q?gsr6GzINycDoxybGAxoxPMY3iUHA9vijiQ/kLtsfPWhJS4MfyYclHPsZ?= =?Windows-1252?Q?rAi9Kqf2nsaEp2i8qZotofaHnQYfKDVmeKZuVLQ9+LORqCQpIcm3Kcut?= =?Windows-1252?Q?c4FYe2U4OqrAFcB9CyIn3dSiXSpoKqmc+gGGaP9nBIxNDTEJwrZ/y11i?= =?Windows-1252?Q?U9+aG1Pxwo8+AyrgVlO7XYF0cbs2tuSyYqt6rKiyWlp27rB1qK9NhE0J?= =?Windows-1252?Q?LeIYhevsD7tQdjGGbJij557YajB5+aM0tSNOrIjKYGLw836KyHjvTh5i?= =?Windows-1252?Q?5SRwMteOkuTwsSjICYhzGsoI46FPC1o4JBAJYgAFpUO2pL4pPi4S0eP0?= =?Windows-1252?Q?aUbxXJjPsy0T7JqqygL2WOwW7jbYlvpWJCSYVeYs/bF8qhmrdHKvUdSr?= =?Windows-1252?Q?AyKnzBKVWEjpKiz5TnwOd/Kqb1xZpc9YBYX6a20dtcVcFjyuo9jgpce7?= =?Windows-1252?Q?D1nBn4NkQKpF1ISOu8Ask2oBega/bfGuCU6x/V6ZES0mbHHnlJiucae5?= =?Windows-1252?Q?trsms7SmbhbQyNWekpbe0uxlN4Ov7RisjP9sIySOD5T8V+qnYlv0Kf3K?= =?Windows-1252?Q?jUjciY144Wl2evsHkN+4s97rfYVyGNYWcalmY2nSlWI8SO/3gkx7N01W?= =?Windows-1252?Q?kFZFc5Ca9LHaQAXi1+z/3CeWZKt9nHnY3+J72l5FX5qPxF8+QvstHM/M?= =?Windows-1252?Q?mcRd+CDpYRy/phaz1HSQYpCvht9dYoh9cgoBGypFw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;6:GKPmjGEzwO3Ghh6fOwir0aVyRmxSOCbUDpotYnvOkmPUNgz74+AsMaYv9qllc8GOTbC4IZhBETws6EB1RxGYYkWtBusoFSxdR+9SSrh/C0J5Cb8DA3JUPw6AohiMfpx9IFw23YaPG7avlCtboEW1KYWZ10HqZ1HCj1EAfk5SWw5hgDr7HM2bMSoPfr6NoayOvOsIkM+5naRcTNmfysUBmbBYeourbrjbod5UbTnqJADBJAwfapGBPKjPzmDmLl9PRZSWokCedknmiEW0I6CxZdEI02mjlEIB2s+f8ZnWF+C8W1tWrd7R8ai4A7Oh8b9G;5:fWAEM0Ia4SHhPvyj5gVsrHfBwNxn90i9cmo7vyf/Zp+5nJRDxfQTL3vHp6nmIHZSDKcJnQN+z4ynNnZa/X3ebGNOBY1BeqR+2PYnM2tbj7+fp5ci4I3W52t0Ktjt1q6fOxqdK3Bxd3z3n31b888QzQ==;24:x8EJ8mKgRwKAytqwADnu8NuNcubV7exGauhKImYffDA/GBcs5McnzRWmWmHJ8M3Ih9mzyNrPs++R0Amx7dvJ12LWeZxhhzeiOxI4TuP/sAM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;7:poGATkG2sRzXGzHdgLTz268cCZvKuhdOchqG7B1rWgXJPP9oD48xyOzuMf3oZ1afvuQg9TT6nAv8aB094maMxx3UFgdUA6Ay1vQ2EOZVOgCktfKUGKDZmsPwPR+y1Ibpdi/zcx1lIfl15PsNKkLaY75XCgVBI9FGRiBt/2kTILfLZmjnEM6/Qm7d4fJNMBATkdNSeXVVdddSQl9Q7gl7t22QbRM8ktV85TEnkHrwpLS6Uk0E7O8pOsortAI/rj5TrFcF1lpZbG3jFl82urbO1/pHX8hhXrjcPaNUrVW/0R5WJoTM+ATuv53IhBW8j9zFfDPPh9zveL6YPVayFxwDTB9kZq0Y2iYgkPEssQXbJcs=;20:5lp7Zg/ScbG5VRLxCnjqC1ZA0Eo8Rwxz4AB5oVvjrkDTCFntjhtRmA+rk3BiQdjjk+icGaI3i0Ltiuumgsjre1XEHRAu4D+3kHRItQL/qGDmM3n5OB8dGFcwVPKUNGN1MZRwUChrCYopO7gfyX63UAgQBAsXqTlXjii483wpwd8= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2016 15:02:52.1519 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1185 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-30_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/29/2016 10:28 PM, Christophe JAILLET wrote: > 'blk_mq_alloc_request()' returns an error pointer in case of error, not > NULL. So test it with IS_ERR. > > Fixes: fd8383fd88a2 ("nbd: convert to blkmq") Applied, thanks. -- Jens Axboe