From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C04744BC009 for ; Wed, 1 Jul 2026 17:47:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782928076; cv=none; b=BurStNtX8SMzhMI4QxeoRiD+PPVJBTtoMDlNls1z/x/yM4s2EISsLYLCyc3pNcHCtz+kx4/wEsyKud+LwnO0CGC/69ICsbvsp9sh7I6HPljhX93TszfwoJhdOkNq6DGpzr9qicfVBOMDEr7N+lDZgKdpaoBw5owL/sE8sRhIOt0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782928076; c=relaxed/simple; bh=Dip23BDhnUJis+qxR7eva4Y6chDo7mwatYq6gf43E7Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TCSTChsVkUNet03dxw88eAh/7wqUkGv5PiaUDN7JtlYVH2Nepk5zkHSKyQhXY0WrjVXc1lovBLzPYHX/FucInbyzXrgJ3qeGvS62FJ5yn4NVyXK6OMYCm6GYcPZxhglvCwgVxLwFSxF7Ljf0YExo9uABSsuslGaDTIPDiHgOlsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T8RqQpLa; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=W857RdcH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T8RqQpLa"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="W857RdcH" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 661GmbXU1691931 for ; Wed, 1 Jul 2026 17:47:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wYFO4m0SG1MdW6YcRZcCBQ8zJ28koOmhlPhOmjE04rw=; b=T8RqQpLaV1KsUpBv 4OjtB+MvqGvE07QLdzeM3J01iAOBQfNO3RdebvU64qeU49RjjDfX44QWDJtkEFnv OuxF/jOGaVGhgYMjbaAz0Yuv8H2ADqsj44j2034tO54YT9dowJF+Z2XijLsBJrm8 ZwCIzAOsU/GSwlv8mMBgqTH79mIIj59t5i3vRW3yQeq08qIYugsXmoZLHNbJ3ctf VC3xVJ1LLtSozH/HdN2qhoo55w4WSIdYvrIze1ING0tbh8FwbnBDX7Bdy2z5XDsb PRmUfVDDwihgHcpXf3+EMS1b1EWTREzBEpw5Sc8M8sZsCEVpYJRY7rWC84S5h/zL rgYu/Q== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4x0tjwv7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Jul 2026 17:47:54 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c85a298cd62so792667a12.0 for ; Wed, 01 Jul 2026 10:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782928074; x=1783532874; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wYFO4m0SG1MdW6YcRZcCBQ8zJ28koOmhlPhOmjE04rw=; b=W857RdcH6/7sHFic4DP+WeAawQmuEL7zHK/FEnBwmIPyZfBO55ftVRixJojoSgoaHp V3RPHznBholRSpST/OtSGc1o9jCPWOOHnBPo/7/joU2gWnOAXBLW/9PTa9FvbolL2nuF EQo6pJcbUjfzGP9rffXmXB6xUA+NLAHlpqimGjDsOokI3VZOaPaPR2tGHS8REWRjet4X YlknufmF/ABLfFlToeiESQkNbGGU1Yiy0ELYsSGHUwVth+Z2uuBcrMQud2gBc6evTcie lv8J1NHlBGGOX3P4c7sn/jAqQV1pGafcPm/4MqCM5O+XyGFnLdmVqpJ7lMWJyvwGRGMf HJuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782928074; x=1783532874; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wYFO4m0SG1MdW6YcRZcCBQ8zJ28koOmhlPhOmjE04rw=; b=RftVo2bvdIZJ7WNoMlB9UXBOOXtp27e5+ZabVyUdLZSOmZbVGDLqPZSjPxyPB49fqm IwrucT7pgGOUtVGQFNuTVrRwDCd1UzME2ApeqhLaCG1f25gpj4oLnqnoauqtIUm89nmH K0q6ZHgTotRtlXX1hW2bXZkSY1qpBW9txAEGfwWUWwFo68wwTmf8IpMAIql94GjhTu5f jZxYQMWUOzZaQLYppRtslnkdxzfJkS01XcpMs+LTNO+RuLxjHyUyYhoNSrhegd/4cs72 yBrTVxbphaC5huBFG2o2rbL/IdxmIOkBwBsDiWar3RNp/gh8QcaxkQBCAd1kY4IqB3CA EELw== X-Forwarded-Encrypted: i=1; AFNElJ+VAyNiZCjBvnQW6SJeA9K8yJqt88ilV/PuwVoHGPH+fUaCigHxBbq4eCHtam4fEp7VZB1bI9mn7tQOhVM=@vger.kernel.org X-Gm-Message-State: AOJu0Yycb4Oo41SUZcvCPoV2ieC6yEaWWe6NWYKooqefQQtV0UfXoCPq faqseOIr7MN1bw9lv63Q9/W9or1X4Mtgj6/DdHgCruhF5LyGpc1vkXondJ9Z7907dKUXZkQe9yb GoYi2OkGg1dojN2d40egBrUbwBmq7jWBRcs7vd235hdYZiuYu3BjtSsN7NXfRkuOQZV6piNNGjC Q= X-Gm-Gg: AfdE7clEJ5lcXWb8ZB70iXwL3VYE9wY/UvSssPC/YnhpunQMoAgra+THPrA6udI1qYt SCq8uGSGeC6GgoMvz0ZTqe9ZbM9NlSE5vne/oaH65cVDjtj21YncfQmg9wPhJ7fhTe5mGtxzYvC H75Trr5H8AqeMpvc/D2try2cMO+r+uuegALAn/iSzLw+qyU20zap97qd101YvckjfFDufdoVojk 7syXtpirErmNXC3sEsxYb2JT0QeoiW3GlouxAe2AfSy4Yr99+8Ztti3TBqWz4CCqqt0sOo2Kcjw IBR+1fV14EFbcuqmaP6/2fNtf2CGuMhcazxP45lZktBEN2/27rlzfakWESEFFcihMJjuIhUlUXt hQfP1cHDzGigb6FrfUEzVAqPPn2zrowDMo3GSOtFRdNRc9/WMtDTDP/Z27mMgAIKxDDbMlb8= X-Received: by 2002:a05:6a21:4c08:b0:3bf:49c8:f69 with SMTP id adf61e73a8af0-3bfed3e6060mr2697822637.39.1782928073720; Wed, 01 Jul 2026 10:47:53 -0700 (PDT) X-Received: by 2002:a05:6a21:4c08:b0:3bf:49c8:f69 with SMTP id adf61e73a8af0-3bfed3e6060mr2697793637.39.1782928073236; Wed, 01 Jul 2026 10:47:53 -0700 (PDT) Received: from [10.227.110.203] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f0bb84405sm31660eec.17.2026.07.01.10.47.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 10:47:52 -0700 (PDT) Message-ID: Date: Wed, 1 Jul 2026 10:47:51 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/3] wifi: carl9170: firmware trust boundary hardening To: Tristan Madani , Christian Lamparter Cc: Johannes Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Tristan Madani References: <20260421134929.325662-1-tristmd@gmail.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20260421134929.325662-1-tristmd@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: CixsQetnRC_skiku8i9izi7krGEMYYaT X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAxMDE4OSBTYWx0ZWRfX9Nevql8k5Tq4 e/23WHLjsgMHrjgl1TIHwN7KV/2C25vY14w06lylOiJL9zP7Fu9pQOjInW77AQVGmjXuOnqAv0j C+MH5tr5wHceSv9t5k4Sq3GHbiwZMcA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAxMDE4OSBTYWx0ZWRfX4E0ODhGfyHtX Wfgi6wYjjqXUjQJhQhpHjOTPDnAuVj/GEU/s+bFKKlEy4tsfKXvHhprEA27RelNf47lMWy/A4ym DStbMfeFNEDZs2nImz2XX3xtlYx/bJ+S5C4vTro1dOKBeL1AOHqV/tvXVv2VjSgolA7+CyNtr+F 1+8B/1+N1mLrV0T+p591sMtTfUYrNajYc54KuZi1o7Qzg7kEh4I22/FxQcVLtULI1LArXYRqERg 3910XRO1vR+9vSfyFG3ABmnWNYvTeRzYXdcxTWoZglOQJxqvgelCj6n7v9IeMWztDUwdKhludNo A8aKmQQ6yglsNLmMgqnpkH+4REe3q6J6YeE8HXXzEdeIO1EgAeKByWo3Oz5QJunolPL4c64yLXB nQMntuHTAMkfsIltg5VE5FtYosyFOasWfp2QH60LCbB+4IWfsWnpOBt1A7KqVQGmjixeKAXtSMg qeJqyuOQrmszPyLQYnA== X-Authority-Analysis: v=2.4 cv=T5+8ifKQ c=1 sm=1 tr=0 ts=6a4552ca cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=J_-Nd1mkAAAA:8 a=Ta6mM2YIzGmWju0K0HUA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 a=n8ForQn92ZFaZtFqRdMw:22 X-Proofpoint-ORIG-GUID: CixsQetnRC_skiku8i9izi7krGEMYYaT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-01_04,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607010189 On 4/21/2026 6:49 AM, Tristan Madani wrote: > From: Tristan Madani > > This series adds missing bounds checks for firmware-controlled fields > in the carl9170 USB driver. > > Patch 1 bounds the cmd callback memcpy to prevent heap overflow from > an oversized firmware response. Patch 2 fixes an off-by-two in the TX > status handler. Patch 3 caps the failover copy to rx_failover_missing > bytes, using min_t per Christian Lamparter. > > Changes in v3: > - Regenerated from wireless-next with proper git format-patch. > > Changes in v2: > - Use min_t() instead of separate if-check in patch 3, per > Christian Lamparter. > > Tristan Madani (3): > wifi: carl9170: bound memcpy length in cmd callback to prevent OOB > read > wifi: carl9170: fix OOB read from off-by-two in TX status handler > wifi: carl9170: fix buffer overflow in rx_stream failover path > > drivers/net/wireless/ath/carl9170/rx.c | 7 +++++-- > drivers/net/wireless/ath/carl9170/tx.c | 2 +- > 2 files changed, 6 insertions(+), 3 deletions(-) > Christian, will you be able to review this series? I'll take it once I get reviewed-by or acked-by tags. And then we can ignore the dups from others. /jeff