From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A38773DD520 for ; Mon, 27 Jul 2026 20:39:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785184800; cv=none; b=IBq9c0jl2cMMjjF1wmeQ6CeSt8mF+nBUUyRo89rSsdjBX7ddhYnNhXbcyISZLrNB69nRVwR+XE5KTNQ4UofL8yv8zF/cLmofLfu1YO7wc2Sy9tUJ31zJ2BY0fW0bTVvJkRPvW3+RhDXAPdSJb9+zJtzn5J4x+DKotSA82mTG/gQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785184800; c=relaxed/simple; bh=G6/IJHg9ZfawuIhfMl16xfedAJ/VcZRm//94paOs4Pk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AB1FZulqOVolMxMZZUNoKcVw+szEUILmZTCFuoy1RC0strKK0SZE6NXPiaN4UMPJFoxvBum5VS7NV1f4ojZOq5YIsQeIiiVZAUi4dUsvvNjTaQt1yxddNUCfE4LE0NsoJMzZbFDwjqHa1Jiuu+z0QctlDT0CJDbswdB2ATzcqXA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rHDiVath; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rHDiVath" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-84e584c7a5bso1512373b3a.2 for ; Mon, 27 Jul 2026 13:39:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785184798; x=1785789598; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YDT8AeYU1cj6+14UCdg7b6IhlALSVP8OOPhCYBI4fqM=; b=rHDiVath01YJZWEO1lvb750p+2ugtTqVJDYBRQNdC1QSyI5XQ5MKgEUG+PgGE3rWD3 qQGx6BfNP4uRVKoJuKFfzudfKqEBEM1VFzkNTVIMw5Ts5HXwPN5qgbFljdzHuOfdg3/v owHKe0MpVHKCKhzOBDxo8rc/5gbXE5w9/a2TSEgAwuntmu8P7zg5CnOqqb3rqPG5+XEI hQricWgEfOLTXfzIDi5UZuEjBk6/SaGEVV5YmbDtilR6Rn9H8OaCgLtzunrc2eFLBBBc fB5Riz9h5/6jkJYcXPRLiOdBc9/YoCFnt4QeAFwrjxngknC/kvYkqhHqosGMjuAE3NHr jsUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785184798; x=1785789598; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=YDT8AeYU1cj6+14UCdg7b6IhlALSVP8OOPhCYBI4fqM=; b=ei0hiHJLrECHdD/Andlyf+yYwWj90spUe/s/qUJWJRmvJPj5Hwrf+83sEB/kF4K4Mu DwQzSktijn+3mrwjVDvSVp62og8r+ssVzk4L+4hjtJS3lsRG/wghNxtmjDSHRqP1NWGY oOyuZOHuYnkjPf5OoGjnQcE4fynFr/1jrJUu4WBK1cub8l7cxDMJTDvvzKn6Wqu6Ox26 NtRTms6QOWaFV1Lxj9B/fBM0rolDt74HoWvvhjTu6W31do+F+8J8eDliMbSQnGZqylKu ti6+32zIqunBCCWgLmwDEb86HUXqSCwbHeSX8hLsXYH3l3FAhX9cxkrUgeYXfSKvO/q8 vT3w== X-Forwarded-Encrypted: i=1; AHgh+Rq3y6I2WLuVdBWLNtNndaXSqTL0CqUAh+DGRnGZ7b7ULNPRbfbB6L0ZofXn2xziojBaquJc7SzHwD+Fjxo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5gkO85xr3RH0ibXrv43IJ4dKoojxFrO5LSFJuBvIrFuh/WotL +Oe3lbEvwGbcy97XEZA7QfAZ6A4Tp0wNFEMnm9Qwp3XZ95G343n4XXYG X-Gm-Gg: AR+sD10aNcdZzncm5eUWRnlrW5rCjDX88LFLT2Cfo0dPuLEcODe+7wAz1P1MDaYEbq6 Qhd5nFNU81ov9ZnYJKI5gnRnW1JPhd6mOMvvpblxoKn2i0SJx0SH0ywVnrN+Ob9cPfuyqnyZ0UF 6Ey+XTz3FHNS1ESDIUmEO4pBwWydoLZeDtZg4TL43bZvegMjJQeBD9mojpzaJ/sgRPJ22YAHT4r sf9Gack6R8Z8pwTF9pqMeSSZMFkJ9Ua/DHsleB+nna8TK29s5Jm7bAVOrCUxzO1Gdt45yp6NEmL mVF87P80bFMfQ+ES/PsYwjcpwCKSvtWKJqAMzr7eB99BrJ3uxup4NXczuR/WIfNi01ZtsE2VnOW Ag5xGovn/f9KlfEVym3I/sE6ajGowna4hPjdJsYkL0SFFpfv6G/yT7szZmyUXxYRmxJbyTzcBik fZXBYJ X-Received: by 2002:a05:6a00:1a8a:b0:846:7507:4e07 with SMTP id d2e1a72fcca58-84e8d36e6d4mr793252b3a.39.1785184797919; Mon, 27 Jul 2026 13:39:57 -0700 (PDT) Received: from cryptic.lan ([2001:569:7fab:e200:3789:64f9:8855:c0af]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e533d1351sm3583338b3a.39.2026.07.27.13.39.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 13:39:57 -0700 (PDT) From: Allen Pais To: Vinod Koul , Frank Li Cc: Allen Pais , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Kees Cook , Olivier Dautricourt , Stefan Roese Subject: [PATCH v2 35/64] dmaengine: altera-msgdma: use channel BH helpers Date: Mon, 27 Jul 2026 13:38:57 -0700 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20260108080332.2341725-1-allen.lkml@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the device tasklet with the per-channel BH helper so completion handling runs via dma_chan_*_bh. Signed-off-by: Allen Pais --- drivers/dma/altera-msgdma.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c index e23e5b441a24..5969bbc84ab9 100644 --- a/drivers/dma/altera-msgdma.c +++ b/drivers/dma/altera-msgdma.c @@ -170,7 +170,6 @@ struct msgdma_sw_desc { struct msgdma_device { spinlock_t lock; struct device *dev; - struct tasklet_struct irq_tasklet; struct list_head pending_list; struct list_head free_list; struct list_head active_list; @@ -684,11 +683,12 @@ static int msgdma_alloc_chan_resources(struct dma_chan *dchan) /** * msgdma_tasklet - Schedule completion tasklet - * @t: Pointer to the Altera sSGDMA channel structure + * @chan: Pointer to the Altera sSGDMA channel structure */ -static void msgdma_tasklet(struct tasklet_struct *t) +static void msgdma_tasklet(struct dma_chan *chan) { - struct msgdma_device *mdev = from_tasklet(mdev, t, irq_tasklet); + struct msgdma_device *mdev = container_of(chan, struct msgdma_device, + dmachan); u32 count; u32 __maybe_unused size; u32 __maybe_unused status; @@ -748,7 +748,7 @@ static irqreturn_t msgdma_irq_handler(int irq, void *data) spin_unlock(&mdev->lock); } - tasklet_schedule(&mdev->irq_tasklet); + dma_chan_schedule_bh(&mdev->dmachan); /* Clear interrupt in mSGDMA controller */ iowrite32(MSGDMA_CSR_STAT_IRQ, mdev->csr + MSGDMA_CSR_STATUS); @@ -766,7 +766,7 @@ static void msgdma_dev_remove(struct msgdma_device *mdev) return; devm_free_irq(mdev->dev, mdev->irq, mdev); - tasklet_kill(&mdev->irq_tasklet); + dma_chan_kill_bh(&mdev->dmachan); list_del(&mdev->dmachan.device_node); } @@ -852,7 +852,7 @@ static int msgdma_probe(struct platform_device *pdev) if (ret) return ret; - tasklet_setup(&mdev->irq_tasklet, msgdma_tasklet); + dma_chan_init_bh(&mdev->dmachan, msgdma_tasklet); dma_cookie_init(&mdev->dmachan); -- 2.43.0