Re: [PATCH v4 3/3] nvme-tcp: parallelize I/O queue allocation and startup

[Martin Belanger <martin.nvme.dev@gmail.com>]

On 10/30/26 17:25, Surabhi Gogte (she/her) wrote:
> 
> Hey Martin, can you try the tests once with tlshd using commit 3a6658e
> ("tlshd: Link the NFS keyrings per handshake instead of at startup")
> or ktls-utils 1.5. blktests nvme/062 and nvme/063 passed with this
> commit. I believe that change fixed the keyring race in tlshd
> independently. If the issue persists, let me know the reproducer
> script so I can also take a look. I saw the same errors while running
> blktests with an older tlshd version from ktls-utils 1.3.1 and
> updating tlshd worked.
> 
> Best,
> Surabhi

Hi Surabhi,

You are right, thanks. The tlshd in my test was too old.

Same kernel 4 CPUs, 4 I/O queues, 40 connects:

- tlshd a0bd51d: 19 of 40 connects fail.
- tlshd from ktls-utils 1.5.0: 40 of 40 connects pass, no handshake
   errors.

So this patch only exposed a race in older tlshd versions, and there
is nothing to fix in the kernel. Sorry for the noise.

Martin