mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcel Hellwig <mhellwig@mut-group.com>
To: 'Eric Dumazet' <eric.dumazet@gmail.com>,
	'David Laight' <David.Laight@ACULAB.COM>,
	"'davem@davemloft.net'" <davem@davemloft.net>,
	"'kuznet@ms2.inr.ac.ru'" <kuznet@ms2.inr.ac.ru>,
	"'yoshfuji@linux-ipv6.org'" <yoshfuji@linux-ipv6.org>,
	"'andrew@lunn.ch'" <andrew@lunn.ch>
Cc: "'netdev@vger.kernel.org'" <netdev@vger.kernel.org>,
	"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
	"Matthias Wystrik" <mwystrik@mut-group.com>
Subject: AW: AW: AW: PROBLEM: Kernel Oops in UDP stack
Date: Tue, 7 Aug 2018 13:42:53 +0000	[thread overview]
Message-ID: <b8b9b9f905164e36a8fea24aa84e124a@ZCOM03.mut-group.com> (raw)
In-Reply-To: <936fbc1f39424adea318bcd95f50d63d@ZCOM03.mut-group.com>

>>
>> Well, this driver does not use NET_IP_ALIGN reservation, meaning IP header is not 4-byte aligned.
>>
>> No idea why mis-alignments are okay in IP layer, but not in UDP
>>
>> You could try to patch it to use netdev_alloc_skb_ip_align() instead of dev_alloc_skb()
> 
> Looks very promising! CPU runs for 3 hours and no panic so far. Let's hope it survives the weekend! *fingers crossed* The strange thing I don't understand is, why does the 3.5.7 kernel does not crash (or 4.17.12, yes I managed to run a recent kernel on our machine! \o/ )? It does not use netdev_alloc_skb_ip_align either[0][1], but one thing, that I noticed it, that there is a difference in /proc/iomem
> 
> 3.4.113
> # cat /proc/iomem
> 08000000-0801ffff : lpc-eth.0
> 31060000-31060fff : lpc-eth.0
> 40088000-4008801f : serial
> [...]
> 
> 3.5.7
> # cat /proc/iomem
> 20084000-20084fff : /ahb/apb/ssp@20084000
> 2008c000-2008cfff : /ahb/apb/ssp@2008c000
> 31000000-31000fff : /ahb/dma@31000000
> 40088000-4008801f : serial
> [...]
> 
> As you notice lpc-eth.0 (or 31060000.ethernet as it's called nowadays) is not listed, so my guess it is served by DMA?
> 
> May that the reason why it does not crash (Notice: 3.5.7 runs via device tree file)?
> 
> So just my thought: If I would disable dma (somehow) would the error still occur in today's kernel?

I think, that it is implicitly aligned today (I think!), so that's the reason why the oops does not occur anymore.

Our machines survived the 4 days now, so we are very confident, that this solved the problem for us!

Thank you very much, you all helped us a lot! 

Mit freundlichen Grüßen / With kind regards 

Marcel Hellwig
B. Sc. Informatik
Entwickler

m-u-t GmbH
Am Marienhof 2
22880 Wedel
Germany

Phone:	+49 4103 9308 - 474
Fax:  	+49 4103 9308 - 99
mhellwig@mut-group.com

www.mut-group.com

Geschäftsführer (Managing Director): Fabian Peters Amtsgericht Pinneberg (Commercial Register No.): HRB 10304 PI USt-IdNr. (VAT-No.): DE228275390
WEEE-Reg-Nr.: DE 72271808

      reply	other threads:[~2018-08-07 13:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31 15:06 Marcel Hellwig
2018-07-31 15:59 ` Eric Dumazet
2018-08-01  5:55   ` AW: " Marcel Hellwig
2018-08-01 10:20     ` Eric Dumazet
2018-08-01 10:35       ` AW: " Marcel Hellwig
2018-08-01 10:44         ` Paolo Abeni
2018-08-01 10:49           ` Eric Dumazet
2018-08-01 11:25             ` Eric Dumazet
2018-08-01 11:31               ` AW: " Marcel Hellwig
2018-08-01 13:27                 ` Marcel Hellwig
2018-08-02 11:02                   ` Marcel Hellwig
2018-08-02 13:05                     ` Eric Dumazet
2018-08-02  9:17         ` David Laight
2018-08-02 13:13           ` Eric Dumazet
2018-08-02 13:18             ` David Laight
2018-08-02 13:57             ` AW: " Marcel Hellwig
2018-08-02 15:07               ` Eric Dumazet
2018-08-03  8:24                 ` AW: " Marcel Hellwig
2018-08-07 13:42                   ` Marcel Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8b9b9f905164e36a8fea24aa84e124a@ZCOM03.mut-group.com \
    --to=mhellwig@mut-group.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mwystrik@mut-group.com \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®