From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752292AbdDJFCm (ORCPT ); Mon, 10 Apr 2017 01:02:42 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:40121 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751239AbdDJFCl (ORCPT ); Mon, 10 Apr 2017 01:02:41 -0400 Subject: Re: [PATCH] phy: qcom-qmp: select COMMON_CLK To: =?UTF-8?Q?J=c3=a9r=c3=a9my_Lefaure?= , Vivek Gautam References: <20170409211539.12680-1-jeremy.lefaure@lse.epita.fr> CC: From: Kishon Vijay Abraham I Message-ID: Date: Mon, 10 Apr 2017 10:31:57 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170409211539.12680-1-jeremy.lefaure@lse.epita.fr> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Monday 10 April 2017 02:45 AM, Jérémy Lefaure wrote: > It is impossible to build Qualcom QMP phy driver without COMMON_CLK > enabled: > CC drivers/phy/phy-qcom-qmp.o > drivers/phy/phy-qcom-qmp.c: In function ‘phy_pipe_clk_register’: > drivers/phy/phy-qcom-qmp.c:932:9: error: variable ‘init’ has initializer > but incomplete type > struct clk_init_data init = { }; > ^~~~~~~~~~~~~ > drivers/phy/phy-qcom-qmp.c:932:23: error: storage size of ‘init’ isn’t > known > struct clk_init_data init = { }; > ^~~~ > ... > > Selecting COMMON_CLK when PHY_QCOM_QMP is enabled fix this issue. > > Fixes: 93a8c0c7b1ad ("phy: qcom-qmp: new qmp phy driver for qcom-chipsets") > Signed-off-by: Jérémy Lefaure Vivek has already sent a patch for this. I have picked that. Thanks Kishon > --- > drivers/phy/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index c120071fd2c8..e881eb2ef305 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -443,6 +443,7 @@ config PHY_QCOM_QMP > tristate "Qualcomm QMP PHY Driver" > depends on OF && (ARCH_QCOM || COMPILE_TEST) > select GENERIC_PHY > + select COMMON_CLK > help > Enable this to support the QMP PHY transceiver that is used > with controllers such as PCIe, UFS, and USB on Qualcomm chips. >