Re: [PATCH v2 00/10] Extend PKWM to support user-created wrapping keys

[Srish Srinivasan <ssrish@linux.ibm.com>]

Hi Nayna,

On 9/21/26 7:09 PM, nayna wrote:
> On 2026-08-31 07:17, Srish Srinivasan wrote:
>> The PKWM trusted source currently uses a single default wrapping key per
>> LPAR. This key is created during trusted source initialization, and all
>> trusted keys backed by PKWM are sealed and unsealed using it.
>>
>> Recent versions of PKWM allow users to create and manage their own 
>> wrapping
>> keys through a set of lifecycle operations. This patch series brings 
>> these
>> PKWM capabilities into the kernel, allowing users to create, manage, and
>> select wrapping keys for sealing and unsealing their trusted keys, 
>> rather
>> than requiring all trusted keys to use the default wrapping key.
>>
>> This series adds support for user-created wrapping keys to PLPKS and 
>> PKWM.
>> It begins with seven preparatory cleanup and bug-fix patches that 
>> improve
>> error handling and type consistency, clarify macro naming, prevent
>> unsupported capabilities from being exposed through sysfs, and update 
>> the
>> documentation and MAINTAINERS entry.
>>
>> The final three patches add the required hcalls, enable wrapping key
>> selection by label for PKWM-backed trusted keys, and provide a sysfs
>> interface for managing wrapping keys from userspace.
>
> Thanks Srish for your work.
>
> It would be cleaner to split these into two separate series: one for 
> the cleanups and one for the user-created wrapping keys management 
> feature. This makes each series easier to review and test. Also, this 
> allows cleanup patches to be accepted even if the wrapping key 
> management feature is still under review.


Sure, that makes sense.
Will split them up into two separate series.


>
> Thanks & Regards,
>    - Nayna

Thanks,
Srish.