mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Laura Abbott <labbott@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rob Herring <robh@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning
Date: Fri, 7 Oct 2016 08:40:26 -0700	[thread overview]
Message-ID: <c1fe5707-6b21-003a-14ff-5874290eeec3@redhat.com> (raw)
In-Reply-To: <20161007035649.GA17183@kroah.com>

On 10/06/2016 08:56 PM, Greg Kroah-Hartman wrote:
> On Thu, Oct 06, 2016 at 04:53:20PM -0700, Laura Abbott wrote:
>> On a whim, I decided to turn on CONFIG_DEBUG_TEST_DRIVER_REMOVE on
>> Fedora rawhide since it sounded harmless enough. It spewed warnings
>> and panicked some systems. Clearly it's  doing its job
>> well of finding drivers that can't handle remove properly and I
>> underestimated it.
>
> Yes, we knew it was going to find bugs, you were brave :)
>

Sure, let's go with brave. That makes me sound good ;)

>> I was expecting to maybe find a driver or two.
>> Can we get stronger Kconfig text indicating that this shouldn't be
>> turned on lightly? I'll be turning the option off in Fedora but sending
>> out reports from what was found.
>
> Care to send a patch with the wording change you would have found better
> to warn yourself not to do this?
>

Sure.

> thanks,
>
> greg k-h
>

Thanks,
Laura

  reply	other threads:[~2016-10-07 15:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-06 23:53 Laura Abbott
2016-10-07  3:56 ` Greg Kroah-Hartman
2016-10-07 15:40   ` Laura Abbott [this message]
2016-10-07  4:06 ` Rob Herring
2016-10-07 15:45   ` Laura Abbott
2016-10-07 16:09 ` [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger Laura Abbott
2016-10-31 10:12   ` Geert Uytterhoeven
2016-10-31 12:21     ` Greg Kroah-Hartman
2016-10-31 12:28       ` Geert Uytterhoeven
2016-10-31 14:10         ` Rob Herring
2016-10-31 15:07           ` Greg Kroah-Hartman
2016-10-31 15:07             ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1fe5707-6b21-003a-14ff-5874290eeec3@redhat.com \
    --to=labbott@redhat.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®