mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thorsten Leemhuis <regressions@leemhuis.info>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	Andreas Wild <andiwild@gmail.com>,
	linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	linux-kernel@vger.kernel.org,
	M M <restafvalendergelijke@outlook.com>,
	regressions@lists.linux.dev
Subject: Re: [PATCH v3] PCI: Skip Target Speed quirk on clamped ports with no link
Date: Fri, 18 Sep 2026 14:50:51 +0200	[thread overview]
Message-ID: <c4d64244-0fef-4b2a-ab34-a0d107bffffd@leemhuis.info> (raw)
In-Reply-To: <alpine.DEB.2.21.2609181231300.57799@angie.orcam.me.uk>

On 9/18/26 14:18, Maciej W. Rozycki wrote:
> On Fri, 18 Sep 2026, Thorsten Leemhuis wrote:
>> That being said and wrt to the "a lot going on": seems this causes some
>> devices to not work for iirc at least two reporters. Would it maybe be
>> better to revert the culprit and reapply it later once that is sorted
>> out? Or is this not an option or a bad one for some reason? Reminder,
>> normally Linus in a situation like this wants regressions ideally 'fixed
>> "within a week", preferably before the next rc':
>> https://lore.kernel.org/all/CAHk-%3Dwi86AosXs66-yi54%2BmpQjPu0upxB8ZAfG%2BLsMyJmcuMSA@mail.gmail.com/

Disclaimer/reminder: I'm an outsider trying to ensure regressions are
handled well, I'm neither affected by the problems nor involved in PCI
subsystem development.
>  Reverting will cause other configurations to regress, so this would be 
> replacing one regression with another.

Well, guess so, as regressions and fixes for them iirc have stacked
here, so there might be no good established base to go back to. But
*normally* going back to one is what Linus afaics wants to actually
prevent exactly a back-and-forth or an exchange of one bug for another.
He wants to ensure that people can always feel safe to update. See these
quotes from Linus for details:
https://www.kernel.org/doc/html/latest/process/handling-regressions.html#on-back-and-forth

So yes, not reverting might be the best at this point, as 7.2 is out for
a while already and so far there are only two reports iirc. You folks
are the best to judge here. That's why I'll also leave the other aspects
you raised to others.

Ciao, Thorsten

  reply	other threads:[~2026-09-18 12:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-01 20:11 Andreas Wild
2026-08-03  5:39 ` Thorsten Leemhuis
2026-08-03 22:07   ` Maciej W. Rozycki
2026-08-04  5:32     ` Thorsten Leemhuis
2026-08-07 19:59 ` Aoxtj
2026-08-08  6:31   ` Andreas Wild
2026-08-11  3:43     ` Aoxtj
2026-08-11  6:42       ` Andreas Wild
2026-08-24 14:26         ` Thorsten Leemhuis
2026-08-25  7:05           ` Andreas Wild
2026-08-25 10:18             ` Maciej W. Rozycki
2026-09-02 15:48               ` Thorsten Leemhuis
2026-09-07 12:33                 ` Maciej W. Rozycki
2026-09-17 23:33 ` Bjorn Helgaas
2026-09-18  5:39   ` Thorsten Leemhuis
2026-09-18 10:39     ` Maciej W. Rozycki
2026-09-18 11:00       ` Thorsten Leemhuis
2026-09-18 12:18         ` Maciej W. Rozycki
2026-09-18 12:50           ` Thorsten Leemhuis [this message]
2026-09-21 10:33       ` Thorsten Leemhuis
2026-09-29  5:45         ` Thorsten Leemhuis
2026-09-29  7:59           ` Andreas Wild
2026-09-20  8:15 blaat windows

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4d64244-0fef-4b2a-ab34-a0d107bffffd@leemhuis.info \
    --to=regressions@leemhuis.info \
    --cc=andiwild@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=macro@orcam.me.uk \
    --cc=regressions@lists.linux.dev \
    --cc=restafvalendergelijke@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®