From: Joe Perches <joe@perches.com>
To: linux-kernel@vger.kernel.org
Cc: Chris Metcalf <cmetcalf@tilera.com>
Subject: [PATCH 01/16] tile: Convert dev_printk(KERN_<LEVEL> to dev_<level>(
Date: Sun, 28 Oct 2012 01:05:39 -0700 [thread overview]
Message-ID: <c7c947ee63de15e20b7a7e2f47aee66ef02ca50f.1351411047.git.joe@perches.com> (raw)
In-Reply-To: <cover.1351411047.git.joe@perches.com>
dev_<level> calls take less code than dev_printk(KERN_<LEVEL>
and reducing object size is good.
Coalesce formats for easier grep.
Signed-off-by: Joe Perches <joe@perches.com>
---
arch/tile/kernel/pci_gx.c | 15 ++++++---------
1 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/arch/tile/kernel/pci_gx.c b/arch/tile/kernel/pci_gx.c
index 2ba6d05..cf1b378 100644
--- a/arch/tile/kernel/pci_gx.c
+++ b/arch/tile/kernel/pci_gx.c
@@ -1454,9 +1454,8 @@ int arch_setup_msi_irq(struct pci_dev *pdev, struct msi_desc *desc)
* Most PCIe endpoint devices do support 64-bit message addressing.
*/
if (desc->msi_attrib.is_64 == 0) {
- dev_printk(KERN_INFO, &pdev->dev,
- "64-bit MSI message address not supported, "
- "falling back to legacy interrupts.\n");
+ dev_info(&pdev->dev,
+ "64-bit MSI message address not supported, falling back to legacy interrupts\n");
ret = -ENOMEM;
goto is_64_failure;
@@ -1475,11 +1474,9 @@ int arch_setup_msi_irq(struct pci_dev *pdev, struct msi_desc *desc)
*/
mem_map = gxio_trio_alloc_memory_maps(trio_context, 1, 0, 0);
if (mem_map < 0) {
- dev_printk(KERN_INFO, &pdev->dev,
- "%s Mem-Map alloc failure. "
- "Failed to initialize MSI interrupts. "
- "Falling back to legacy interrupts.\n",
- desc->msi_attrib.is_msix ? "MSI-X" : "MSI");
+ dev_info(&pdev->dev,
+ "%s Mem-Map alloc failure. Failed to initialize MSI interrupts. Falling back to legacy interrupts.\n",
+ desc->msi_attrib.is_msix ? "MSI-X" : "MSI");
ret = -ENOMEM;
goto msi_mem_map_alloc_failure;
@@ -1501,7 +1498,7 @@ int arch_setup_msi_irq(struct pci_dev *pdev, struct msi_desc *desc)
mem_map, mem_map_base, mem_map_limit,
trio_context->asid);
if (ret < 0) {
- dev_printk(KERN_INFO, &pdev->dev, "HV MSI config failed.\n");
+ dev_info(&pdev->dev, "HV MSI config failed\n");
goto hv_msi_config_failure;
}
--
1.7.8.112.g3fd21
next prev parent reply other threads:[~2012-10-28 8:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 8:05 [PATCH 00/16] treewide: " Joe Perches
2012-10-28 8:05 ` Joe Perches [this message]
2012-10-28 12:54 ` [PATCH 01/16] tile: " Chris Metcalf
2012-10-28 8:05 ` [PATCH 02/16] ata: " Joe Perches
2012-11-28 17:42 ` Jeff Garzik
2012-10-28 8:05 ` [PATCH 03/16] drivers: base: " Joe Perches
2012-10-28 8:05 ` [PATCH 04/16] block: " Joe Perches
2012-10-28 8:05 ` [PATCH 05/16] pcmcia: " Joe Perches
2012-10-28 8:05 ` [PATCH 06/16] dma: " Joe Perches
2012-10-29 5:54 ` Vinod Koul
2012-10-28 8:05 ` [PATCH 07/16] gpu: " Joe Perches
2012-10-28 8:05 ` [PATCH 08/16] i2c: " Joe Perches
2012-10-28 11:45 ` Jean Delvare
2012-10-28 8:05 ` [PATCH 09/16] wireless: " Joe Perches
2012-10-28 8:05 ` [PATCH 10/16] ethernet: " Joe Perches
2012-11-03 2:00 ` David Miller
2012-10-28 8:05 ` [PATCH 11/16] pci: " Joe Perches
2012-11-05 22:28 ` Bjorn Helgaas
2012-10-28 8:05 ` [PATCH 12/16] scsi: " Joe Perches
2012-10-28 8:05 ` [PATCH 13/16] usb: " Joe Perches
2012-10-28 8:05 ` [PATCH 14/16] virtio: " Joe Perches
2012-10-31 23:54 ` Rusty Russell
2012-10-28 8:05 ` [PATCH 15/16] watchdog: " Joe Perches
2012-10-28 8:05 ` [PATCH 16/16] sound: " Joe Perches
2012-10-28 8:59 ` Takashi Iwai
2012-10-28 10:54 ` [PATCH 00/16] treewide: " Sergei Shtylyov
2012-10-28 12:12 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7c947ee63de15e20b7a7e2f47aee66ef02ca50f.1351411047.git.joe@perches.com \
--to=joe@perches.com \
--cc=cmetcalf@tilera.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®