From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-kernel@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andrew Morton <akpm@linux-foundation.org>,
Stefan Wahren <wahrenst@gmx.net>
Subject: Re: [PATCH v3 2/3] ARM: bcm2835: Switch to use %ptT
Date: Tue, 16 Jun 2020 18:22:17 +0200 [thread overview]
Message-ID: <cabeb88787e032d0b241369884720b410142f72b.camel@suse.de> (raw)
In-Reply-To: <20200616161346.GW2428291@smile.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1846 bytes --]
On Tue, 2020-06-16 at 19:13 +0300, Andy Shevchenko wrote:
> On Tue, Jun 16, 2020 at 05:53:23PM +0200, Nicolas Saenz Julienne wrote:
> > On Wed, 2020-04-15 at 20:00 +0300, Andy Shevchenko wrote:
> > > Use %ptT instead of open coded variant to print content of
> > > time64_t type in human readable format.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> >
> > as originally reported by Stefan Wahren, this patch is likely to be the
> > cause
> > for a regression on RPi3b+ 32bit mode (multi_v7_defconfig,
> > 5.8.0-rc1-00019-ga5dc8300df75):
> >
> > [ 3.759892] raspberrypi-firmware soc:firmware: Attached to firmware from
> > 18446744073709048425-02-19T15:52:16
> >
> > Whereas the same doesn't seem to happen in 64bit mode:
> >
> > [ 1.584126] raspberrypi-firmware soc:firmware: Attached to firmware from
> > 2020-02-12T12:39:27
>
> Had you chance to run test_printf on that machine and see if it reports any
> failure?
> If no, can you provide a raw date which makes this happen?
>
> Ah, I think I have an idea what is going on... stay tuned!
>
> Does below fix it?
Yes :)
> --- a/drivers/firmware/raspberrypi.c
> +++ b/drivers/firmware/raspberrypi.c
> @@ -181,6 +181,7 @@ EXPORT_SYMBOL_GPL(rpi_firmware_property);
> static void
> rpi_firmware_print_firmware_revision(struct rpi_firmware *fw)
> {
> + time64_t date_and_time;
> u32 packet;
> int ret = rpi_firmware_property(fw,
> RPI_FIRMWARE_GET_FIRMWARE_REVISION,
> @@ -189,7 +190,8 @@ rpi_firmware_print_firmware_revision(struct rpi_firmware
> *fw)
> if (ret)
> return;
>
> - dev_info(fw->cl.dev, "Attached to firmware from %ptT\n", &packet);
> + date_and_time = packet;
> + dev_info(fw->cl.dev, "Attached to firmware from %ptT\n",
> &date_and_time);
> }
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-16 16:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 17:00 [PATCH v3 0/3] lib/vsprintf: Introduce %ptT for time64_t Andy Shevchenko
2020-04-15 17:00 ` [PATCH v3 1/3] lib/vsprintf: Print time64_t in human readable format Andy Shevchenko
2020-04-16 2:32 ` Sergey Senozhatsky
2020-04-21 13:08 ` Andy Shevchenko
2020-04-23 1:54 ` Sergey Senozhatsky
2020-04-23 10:43 ` Andy Shevchenko
2020-04-15 17:00 ` [PATCH v3 2/3] ARM: bcm2835: Switch to use %ptT Andy Shevchenko
2020-04-16 2:53 ` Sergey Senozhatsky
2020-04-16 3:02 ` Sergey Senozhatsky
2020-04-21 13:09 ` Andy Shevchenko
2020-06-16 15:53 ` Nicolas Saenz Julienne
2020-06-16 16:13 ` Andy Shevchenko
2020-06-16 16:22 ` Nicolas Saenz Julienne [this message]
2020-06-16 16:32 ` Andy Shevchenko
2020-04-15 17:00 ` [PATCH v3 3/3] [media] usb: pulse8-cec: " Andy Shevchenko
2020-04-15 17:20 ` [PATCH v3 0/3] lib/vsprintf: Introduce %ptT for time64_t Steven Rostedt
2020-04-16 2:34 ` Sergey Senozhatsky
2020-04-16 2:46 ` Joe Perches
2020-04-21 13:07 ` Andy Shevchenko
2020-05-15 16:02 ` Petr Mladek
2020-05-20 11:43 ` Sergey Senozhatsky
2020-05-21 8:45 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cabeb88787e032d0b241369884720b410142f72b.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®