RE: [V2 6/7] hvsock: introduce Hyper-V VM Sockets feature

[Dexuan Cui <decui@microsoft.com>]

> From: David Miller
> Sent: Thursday, July 16, 2015 12:19
> 
> From: Dexuan Cui
> Date: Tue, 14 Jul 2015 03:00:48 -0700
> 
> > +	pr_debug("hvsock_sk_destruct: called\n");
> 
> Debug logging just to state that a function is called is not appropriate,
> we have very sophisticated tracing facilities in the kernel that can do
> that transparently, and more.
> 
> Please remove this.
OK. 
 
> > +	if (hvsk->channel) {
> > +		pr_debug("hvsock_sk_destruct: calling vmbus_close()\n");
> 
> Likewise, these kinds of debug logs are totally inappropriate.
OK, I'll remove all the pr_debug() in the patch.
 
> > +static int hvsock_release(struct socket *sock)
> > +{
> > +	/* sock->sk is NULL, if accept() is interrupted by a signal */
> > +	if (sock->sk) {
> > +		__hvsock_release(sock->sk);
> > +		sock->sk = NULL;
> > +	}
> > +
> > +	sock->state = SS_FREE;
> > +	pr_debug("hvsock_release called\n\n");
> 
> Likewise.
OK. Will fix it.

Thanks,
-- Dexuan