From: Jens Axboe <axboe@fb.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>, <axboe@kernel.dk>,
<linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <paolo.valente@linaro.org>, <osandov@fb.com>
Subject: Re: [PATCH 6/7] mq-deadline: add blk-mq adaptation of the deadline IO scheduler
Date: Wed, 14 Dec 2016 08:02:59 -0700 [thread overview]
Message-ID: <d48260a6-c7f1-d5ed-bc21-80b69ed9d2f6@fb.com> (raw)
In-Reply-To: <d4534a17-7fc3-3c55-37fd-aa2fff326795@sandisk.com>
On 12/14/2016 01:09 AM, Bart Van Assche wrote:
> On 12/08/2016 09:13 PM, Jens Axboe wrote:
>> +static inline bool dd_rq_is_shadow(struct request *rq)
>> +{
>> + return rq->rq_flags & RQF_ALLOCED;
>> +}
>
> Hello Jens,
>
> Something minor: because req_flags_t has been defined using __bitwise
> (typedef __u32 __bitwise req_flags_t) sparse complains for the above
> function about converting req_flags_t into bool. How about changing the
> body of that function into "return (rq->rq_flags & RQF_ALLOCED) != 0" to
> keep sparse happy?
Sure, I can fold in that change.
--
Jens Axboe
next prev parent reply other threads:[~2016-12-14 15:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 20:13 [PATCHSET/RFC v2] blk-mq scheduling framework Jens Axboe
2016-12-08 20:13 ` [PATCH 1/7] blk-mq: add blk_mq_start_stopped_hw_queue() Jens Axboe
2016-12-13 8:48 ` Bart Van Assche
2016-12-08 20:13 ` [PATCH 2/7] blk-mq: abstract out blk_mq_dispatch_rq_list() helper Jens Axboe
2016-12-09 6:44 ` Hannes Reinecke
2016-12-13 8:51 ` Bart Van Assche
2016-12-13 15:05 ` Jens Axboe
2016-12-13 9:18 ` Ritesh Harjani
2016-12-13 9:29 ` Bart Van Assche
2016-12-08 20:13 ` [PATCH 3/7] elevator: make the rqhash helpers exported Jens Axboe
2016-12-09 6:45 ` Hannes Reinecke
2016-12-08 20:13 ` [PATCH 4/7] blk-flush: run the queue when inserting blk-mq flush Jens Axboe
2016-12-09 6:45 ` Hannes Reinecke
2016-12-08 20:13 ` [PATCH 5/7] blk-mq-sched: add framework for MQ capable IO schedulers Jens Axboe
2016-12-13 13:56 ` Bart Van Assche
2016-12-13 15:14 ` Jens Axboe
2016-12-14 10:31 ` Bart Van Assche
2016-12-14 15:05 ` Jens Axboe
2016-12-13 14:29 ` Bart Van Assche
2016-12-13 15:20 ` Jens Axboe
2016-12-08 20:13 ` [PATCH 6/7] mq-deadline: add blk-mq adaptation of the deadline IO scheduler Jens Axboe
2016-12-13 11:04 ` Bart Van Assche
2016-12-13 15:08 ` Jens Axboe
2016-12-14 8:09 ` Bart Van Assche
2016-12-14 15:02 ` Jens Axboe [this message]
2016-12-08 20:13 ` [PATCH 7/7] blk-mq-sched: allow setting of default " Jens Axboe
2016-12-13 10:13 ` Bart Van Assche
2016-12-13 15:06 ` Jens Axboe
2016-12-13 9:26 ` [PATCHSET/RFC v2] blk-mq scheduling framework Paolo Valente
2016-12-13 15:17 ` Jens Axboe
2016-12-13 16:15 ` Paolo Valente
2016-12-13 16:28 ` Jens Axboe
2016-12-13 21:51 ` Jens Axboe
2016-12-15 5:26 [PATCHSET v3] " Jens Axboe
2016-12-15 5:26 ` [PATCH 6/7] mq-deadline: add blk-mq adaptation of the deadline IO scheduler Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d48260a6-c7f1-d5ed-bc21-80b69ed9d2f6@fb.com \
--to=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@sandisk.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@fb.com \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®