mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sekhar Nori <nsekhar@ti.com>
To: Alexandre Bailon <abailon@baylibre.com>, <khilman@baylibre.com>,
	<robh+dt@kernel.org>, <b-liu@ti.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 4/4] ARM: dts: da850: Add the usb otg device node
Date: Wed, 16 Nov 2016 16:11:46 +0530	[thread overview]
Message-ID: <d4c8da0e-d66d-1268-78e5-d994399c9166@ti.com> (raw)
In-Reply-To: <d2050c80-255e-25d6-99ba-7634f2c7e39a@baylibre.com>

On Wednesday 16 November 2016 04:05 PM, Alexandre Bailon wrote:
> On 11/15/2016 11:46 AM, Sekhar Nori wrote:
>> On Thursday 03 November 2016 09:29 PM, Alexandre Bailon wrote:
>>> This adds the device tree node for the usb otg
>>> controller present in the da850 family of SoC's.
>>> This also enables the otg usb controller for the lcdk board.
>>>
>>> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
>>> ---
>>>  arch/arm/boot/dts/da850-lcdk.dts |  8 ++++++++
>>>  arch/arm/boot/dts/da850.dtsi     | 15 +++++++++++++++
>>>  2 files changed, 23 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts
>>> index 7b8ab21..9f5040c 100644
>>> --- a/arch/arm/boot/dts/da850-lcdk.dts
>>> +++ b/arch/arm/boot/dts/da850-lcdk.dts
>>> @@ -158,6 +158,14 @@
>>>  	rx-num-evt = <32>;
>>>  };
>>>  
>>> +&usb_phy {
>>> +	status = "okay";
>>> +	};
>>
>> As mentioned by David already, this node needs to be removed. Please

> I have missed it. But why should I remove it?
> Without it, usb otg won't work.

Grr, I replied to the wrong hunk. The part in da850-lcdk.dts needs to be
preserved (but please fix the indentation on the closing brace).

The part in da850.dtsi needs to be removed as it is already merged.

Thanks,
Sekhar

  reply	other threads:[~2016-11-16 10:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-03 15:59 [PATCH v4 0/4] Add DT support for DA8xx Alexandre Bailon
2016-11-03 15:59 ` [PATCH v4 1/4] dt/bindings: Add binding for the DA8xx MUSB driver Alexandre Bailon
2016-11-03 15:59 ` [PATCH v4 2/4] usb: musb: core: added helper function for parsing DT Alexandre Bailon
2016-11-03 15:59 ` [PATCH v4 3/4] usb: musb: da8xx: Add DT support for the DA8xx driver Alexandre Bailon
2016-11-03 15:59 ` [PATCH v4 4/4] ARM: dts: da850: Add the usb otg device node Alexandre Bailon
2016-11-15 10:46   ` Sekhar Nori
2016-11-15 21:19     ` [PATCH v4 4/4] ARM: dts: da850: Add the usb otg device nodeg Bin Liu
2016-11-16  6:36       ` Sekhar Nori
2016-11-16 17:24         ` Bin Liu
2016-11-16 10:35     ` [PATCH v4 4/4] ARM: dts: da850: Add the usb otg device node Alexandre Bailon
2016-11-16 10:41       ` Sekhar Nori [this message]
2016-11-16 10:47         ` Alexandre Bailon
2016-11-15 21:12 ` [PATCH v4 0/4] Add DT support for DA8xx Bin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4c8da0e-d66d-1268-78e5-d994399c9166@ti.com \
    --to=nsekhar@ti.com \
    --cc=abailon@baylibre.com \
    --cc=b-liu@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®