From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: josh@joshtriplett.org
Cc: linux-kernel@vger.kernel.org, Tom Zanussi <tom.zanussi@linux.intel.com>
Subject: [PATCH 09/10] drivers/char: Support compiling out /dev/kmsg
Date: Fri, 23 Jan 2015 12:37:15 -0600 [thread overview]
Message-ID: <d6aa6b4ddb71e34d173f9b2874de60c2836ecc6c.1422035184.git.tom.zanussi@linux.intel.com> (raw)
In-Reply-To: <cover.1422035184.git.tom.zanussi@linux.intel.com>
In-Reply-To: <cover.1422035184.git.tom.zanussi@linux.intel.com>
Some embedded systems with tightly controlled userspace have no use
for /dev/kmsg, and could benefit from the size savings gained by
omitting it. Add a new EMBEDDED config option to disable it.
bloat-o-meter (based on tinyconfig):
add/remove: 0/8 grow/shrink: 1/1 up/down: 92/-1538 (-1446)
function old new delta
do_syslog 1027 1119 +92
devkmsg_release 15 - -15
devlist 192 160 -32
devkmsg_poll 97 - -97
devkmsg_open 112 - -112
check_syslog_permissions 114 - -114
kmsg_fops 116 - -116
devkmsg_llseek 144 - -144
devkmsg_write 209 - -209
devkmsg_read 699 - -699
Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
---
drivers/char/Kconfig | 14 ++++++++++++++
drivers/char/mem.c | 2 +-
kernel/printk/printk.c | 2 ++
3 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 1af4551..25fe627 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -89,6 +89,20 @@ config DEVURANDOM
disabled on systems that will never use it in production,
such as many embedded systems. When in doubt, say "Y".
+config DEVKMSG
+ bool "/dev/kmsg virtual device support" if EMBEDDED
+ depends on DEVMEM_BASE && PRINTK
+ default y
+ help
+ Say Y here if you want to support the /dev/kmsg device. The
+ /dev/kmsg device provides access to the raw kernel message
+ ring buffer, and can be disabled on systems that will never
+ use it in production, such as many embedded systems. The
+ kernel log buffer is also accessible via the syslog() kernel
+ interface and userspace tools such as dmesg (using -S) can
+ be directed to use that interface instead. When in doubt,
+ say "Y".
+
config SGI_SNSC
bool "SGI Altix system controller communication support"
depends on (IA64_SGI_SN2 || IA64_GENERIC)
diff --git a/drivers/char/mem.c b/drivers/char/mem.c
index 5315f63..6cc26ea 100644
--- a/drivers/char/mem.c
+++ b/drivers/char/mem.c
@@ -832,7 +832,7 @@ static const struct memdev {
#ifdef CONFIG_DEVURANDOM
[9] = { "urandom", 0666, &urandom_fops, NULL },
#endif
-#ifdef CONFIG_PRINTK
+#ifdef CONFIG_DEVKMSG
[11] = { "kmsg", 0644, &kmsg_fops, NULL },
#endif
};
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 02d6b6d..fbd05d8 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -505,6 +505,7 @@ int check_syslog_permissions(int type, bool from_file)
return security_syslog(type);
}
+#ifdef CONFIG_DEVKMSG
/* /dev/kmsg - userspace message inject/listen interface */
struct devkmsg_user {
@@ -797,6 +798,7 @@ const struct file_operations kmsg_fops = {
.poll = devkmsg_poll,
.release = devkmsg_release,
};
+#endif
#ifdef CONFIG_KEXEC
/*
--
1.9.3
next prev parent reply other threads:[~2015-01-23 18:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 18:37 [PATCH 00/10] tinification: Make memory-access char devices optional Tom Zanussi
2015-01-23 18:37 ` [PATCH 01/10] drivers/char: Support compiling out memory-access char devices Tom Zanussi
2015-01-23 18:37 ` [PATCH 02/10] drivers/char: Support compiling out /dev/mem Tom Zanussi
2015-01-23 18:37 ` [PATCH 03/10] drivers/char: Support compiling out /dev/port Tom Zanussi
2015-01-23 18:37 ` [PATCH 04/10] drivers/char: Support compiling out /dev/null Tom Zanussi
2015-01-23 18:37 ` [PATCH 05/10] drivers/char: Support compiling out /dev/zero Tom Zanussi
2015-01-28 21:07 ` Pavel Machek
2015-01-28 21:51 ` josh
2015-01-28 21:52 ` Pavel Machek
2015-01-28 23:20 ` Tom Zanussi
2015-01-31 23:08 ` Josh Triplett
2015-01-23 18:37 ` [PATCH 06/10] drivers/char: Support compiling out /dev/full Tom Zanussi
2015-01-23 18:37 ` [PATCH 07/10] drivers/char: Support compiling out /dev/random Tom Zanussi
2015-01-23 18:37 ` [PATCH 08/10] drivers/char: Support compiling out /dev/urandom Tom Zanussi
2015-01-23 18:37 ` Tom Zanussi [this message]
2015-01-23 18:37 ` [PATCH 10/10] drivers/char: Support compiling out the getrandom(2) syscall Tom Zanussi
2015-01-23 19:46 ` Theodore Ts'o
2015-01-23 20:04 ` Tom Zanussi
2015-01-23 22:30 ` josh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6aa6b4ddb71e34d173f9b2874de60c2836ecc6c.1422035184.git.tom.zanussi@linux.intel.com \
--to=tom.zanussi@linux.intel.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®