Re: [PATCH] crypto: loongson - Select CRYPTO_RNG

[Qunqin Zhao <zhaoqunqin@loongson.cn>]

在 2026/5/22 上午10:57, Eric Biggers 写道:
> On Fri, May 22, 2026 at 10:52:42AM +0800, Huacai Chen wrote:
>> On Fri, May 22, 2026 at 10:26 AM Eric Biggers <ebiggers@kernel.org> wrote:
>>> This driver registers a rng_alg, so it requires CRYPTO_RNG.
>>>
>>> Fixes: 766b2d724c8d ("crypto: loongson - add Loongson RNG driver support")
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Closes: https://lore.kernel.org/oe-kbuild-all/202605201622.qWOiiZTV-lkp@intel.com/
>>> Cc: stable@vger.kernel.org
>>> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
>> Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
>>> ---
>>>   drivers/crypto/loongson/Kconfig | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
> By the way, do any of the loongson people have any comment on what they
> think the point of this driver is?  It's not registered with the actual

To provide an AF_ALG-based random number generation interface for other 
modules and user-space programs.

Thanks,

Qunqin

> hwrng subsystem, but rather the pointless crypto_rng system which no one
> uses.  So if it was intended to provide entropy for /dev/urandom etc.,
> that isn't what it's doing.

>
> Can we just delete this driver?
>
> - Eric